fix(ci): unblock inherited #4028 lint failures#4039
Merged
Conversation
…nblock Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
…ed CI unblock PR Co-Authored-By: Codex <noreply@openai.com>
There was a problem hiding this comment.
Pull request overview
This PR unblocks inherited CI failures by correcting tick-shard cross-references and making the Amazon orders extractor compatible with strict TypeScript checks.
Changes:
- Fixes
.claude/rulesrelative links in a hygiene tick shard. - Adds a typed runtime-only Playwright loader to avoid static module-resolution failures.
- Narrows unchecked array access in the extractor’s URL dedup logic.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tools/inventory/amazon-orders-extract.ts |
Updates Playwright loading and dedup fallback for strict TypeScript compatibility. |
docs/hygiene-history/ticks/2026/05/17/0221Z.md |
Corrects rule links from the tick shard to repo-root .claude/rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks inherited CI failures currently visible on #4028, without widening #4028's tally-fix scope.
What changed:
docs/hygiene-history/ticks/2026/05/17/0221Z.md.claude/rules relative links from 5-up to 6-up so they resolve to repo root.tools/inventory/amazon-orders-extract.tsto use a typed runtime-only Playwright import loader and strictdedupfallback fornoUncheckedIndexedAccess.Verification:
/opt/homebrew/bin/bun tools/hygiene/audit-tick-shard-relative-paths.ts --enforce --baseline tools/hygiene/audit-tick-shard-relative-paths.baseline.json/opt/homebrew/bin/bun install --frozen-lockfile/opt/homebrew/bin/bun --bun tsc --noEmit -p tsconfig.jsonRelated:
Claim lifecycle: