backlog(B-0591): wire tick-shard schema validator to CI (B-0529 Later item)#4012
Merged
Merged
Conversation
Files B-0591 as the explicit decomposition of B-0529's "Later (separate row)" Recommendation. Two slices: - Slice 1 (this row, P3): wire validator as non-required check in .github/workflows/gate.yml. Observability without enforcement. - Slice 2 (separate row, after Slice 1 + bulk-retrofit lands): promote to required. Pre-requisite is 0 violations on main. Composes with B-0529 (parent), the validator at tools/hygiene/check-tick-history-shard-schema.ts, the retrofit tool at tools/hygiene/add-pipe-row-header.ts (PR #3990), and the README docs updated in PR #4004. Not in scope: bulk retrofit --write run (separate row); legacy pre-2026-04-29 shard migration. Co-Authored-By: Claude <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
Adds a new P3 backlog row decomposing B-0529’s later CI-wiring recommendation for the tick-shard schema validator.
Changes:
- Adds B-0591 with frontmatter and context tying the work to B-0529.
- Defines acceptance criteria for advisory CI wiring and future required-check promotion.
- Cross-links the validator, retrofit tool, target workflow, and shard schema docs.
| title: Wire tick-shard schema validator into gate.yml (non-required → required) | ||
| created: 2026-05-17 | ||
| last_updated: 2026-05-17 | ||
| depends_on: [B-0529] |
|
|
||
| ## Acceptance | ||
|
|
||
| - [ ] **Slice 1 (this row, P3): wire validator as non-required check** in `.github/workflows/gate.yml`. Job runs on every PR that touches `docs/hygiene-history/ticks/**.md`. Non-required means CI surfaces the violation but does not block merge. Provides observability without enforcement. |
| @@ -0,0 +1,67 @@ | |||
| --- | |||
| id: B-0591 | |||
| ## Acceptance | ||
|
|
||
| - [ ] **Slice 1 (this row, P3): wire validator as non-required check** in `.github/workflows/gate.yml`. Job runs on every PR that touches `docs/hygiene-history/ticks/**.md`. Non-required means CI surfaces the violation but does not block merge. Provides observability without enforcement. | ||
| - [ ] **Slice 2 (separate row, after Slice 1 + bulk-retrofit lands): promote to required check**. Pre-requisite: 0 existing violations on `main` (so the required check passes on every PR touching shards). Bulk retrofit (running `tools/hygiene/add-pipe-row-header.ts --write` on all 359 non-compliant shards) is the precondition. |
| - [`tools/hygiene/check-tick-history-shard-schema.ts`](../../../tools/hygiene/check-tick-history-shard-schema.ts) (the validator to wire) | ||
| - [`tools/hygiene/add-pipe-row-header.ts`](../../../tools/hygiene/add-pipe-row-header.ts) (the retrofit tool; bulk-run is precondition for Slice 2) | ||
| - [`.github/workflows/gate.yml`](../../../.github/workflows/gate.yml) (target workflow) | ||
| - [`docs/hygiene-history/ticks/README.md`](../../hygiene-history/ticks/README.md) (schema docs; updated in PR #4004) |
Comment on lines
+34
to
+37
| The B-0529 cycle landed two pieces of substrate on main today (2026-05-17): | ||
|
|
||
| - [PR #3990](https://github.com/Lucent-Financial-Group/Zeta/pull/3990) — `tools/hygiene/add-pipe-row-header.ts` (the retrofit tool + 28 unit tests) | ||
| - [PR #4004](https://github.com/Lucent-Financial-Group/Zeta/pull/4004) — README hybrid-pattern endorsement |
This was referenced May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files B-0591 as the explicit decomposition of B-0529's "Later (separate row)" Recommendation.
Two slices documented:
.github/workflows/gate.yml. Provides observability of new shard schema violations without blocking merge.main(bulk-retrofit must run first).Composes with
docs/backlog/P2/B-0529-tick-shard-schema-validator-vs-practice-drift-2026-05-15.md(parent)tools/hygiene/check-tick-history-shard-schema.ts(validator to wire)tools/hygiene/add-pipe-row-header.ts(retrofit tool from PR #3990)docs/hygiene-history/ticks/README.md(schema docs from PR #4004)Test plan
🤖 Generated with Claude Code