-
Notifications
You must be signed in to change notification settings - Fork 1
docs(archive): Maji preservation of merged PRs #3997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| --- | ||
| pr_number: 3973 | ||
| title: "docs(archive): Lior preservation of merged PRs 3949, 3945" | ||
| author: "AceHack" | ||
| state: "MERGED" | ||
| created_at: "2026-05-16T23:29:58Z" | ||
| merged_at: "2026-05-17T00:42:52Z" | ||
| closed_at: "2026-05-17T00:42:52Z" | ||
| head_ref: "lior/preserve-batch-1930Z" | ||
| base_ref: "main" | ||
| archived_at: "2026-05-17T01:13:19Z" | ||
| archive_tool: "tools/pr-preservation/archive-pr.ts" | ||
| --- | ||
|
|
||
| # PR #3973: docs(archive): Lior preservation of merged PRs 3949, 3945 | ||
|
|
||
| ## PR description | ||
|
|
||
| Maji Antigravity Check: Preservation discipline. Archiving recently merged PRs into the native repository memory. | ||
|
|
||
| ## Reviews | ||
|
|
||
| ### COMMENTED — @copilot-pull-request-reviewer (2026-05-16T23:37:27Z) | ||
|
|
||
| ## Pull request overview | ||
|
|
||
| Archives the discussions/metadata for two recently merged PRs into `docs/pr-discussions/`, preserving the PR narrative and review threads as part of the repository’s long-term audit trail. | ||
|
|
||
| **Changes:** | ||
| - Adds an archived discussion document for PR #3949 (B-0156 Phase 6 `.py` policy CI gate). | ||
| - Adds an archived discussion document for PR #3945 (re-open B-0441 to satisfy parent/child status invariant). | ||
|
|
||
| ### Reviewed changes | ||
|
|
||
| Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment. | ||
|
|
||
| | File | Description | | ||
| | ---- | ----------- | | ||
| | docs/pr-discussions/PR-3949-feat-b-0156-phase-6-py-policy-ci-gate-no-python-files-lint.md | Adds the preserved PR #3949 discussion, summary, checks, and review threads. | | ||
| | docs/pr-discussions/PR-3945-fix-b-0441-re-open-per-parent-child-status-invariant-b-0532.md | Adds the preserved PR #3945 discussion, rationale, and review threads. | | ||
|
|
||
| ## Review threads | ||
|
|
||
| ### Thread 1: docs/pr-discussions/PR-3949-feat-b-0156-phase-6-py-policy-ci-gate-no-python-files-lint.md:21 (resolved) | ||
|
|
||
| **@copilot-pull-request-reviewer** (2026-05-16T23:37:26Z): | ||
|
|
||
| The markdown link to B-0156 uses `docs/backlog/...`, which will resolve relative to `docs/pr-discussions/` (i.e., `docs/pr-discussions/docs/backlog/...`) and appears to be a broken path when browsing on GitHub. Use a link that is correct from this file’s location (e.g., `../backlog/...`) so the archive remains navigable. | ||
|
|
||
| ## General comments | ||
|
|
||
| ### @AceHack (2026-05-17T00:39:04Z) | ||
|
|
||
| Thread resolved via 4850f6a — relative link `[B-0156](docs/backlog/...)` corrected to `[B-0156](../backlog/...)` (resolves from `docs/pr-discussions/` correctly). Otto-bg-worker. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| --- | ||
| pr_number: 3974 | ||
| title: "backlog(B-0583): cross-machine account-scoped scarcity bus \u2014 refine B-0570 substrate location" | ||
| author: "AceHack" | ||
| state: "MERGED" | ||
| created_at: "2026-05-16T23:31:43Z" | ||
| merged_at: "2026-05-17T00:15:11Z" | ||
| closed_at: "2026-05-17T00:15:11Z" | ||
| head_ref: "backlog/b-0583-cross-machine-account-scoped-scarcity-bus-2026-05-16" | ||
| base_ref: "main" | ||
| archived_at: "2026-05-17T01:13:19Z" | ||
| archive_tool: "tools/pr-preservation/archive-pr.ts" | ||
| --- | ||
|
|
||
| # PR #3974: backlog(B-0583): cross-machine account-scoped scarcity bus — refine B-0570 substrate location | ||
|
|
||
| ## PR description | ||
|
|
||
| ## Summary | ||
|
|
||
| Refines B-0570 (scarcity tracker) substrate location after Aaron's 2026-05-16 correction: rate-limit is account-scoped (tied to AceHack), not agent-scoped; cross-machine matters because Otto-CLI on Aaron's laptop + ServiceTitan-replicated Otto share the same bucket. | ||
|
|
||
| ## Why | ||
|
|
||
| Per-agent-named files mis-frame the partition key. Machine-local /tmp/zeta-bus is insufficient for cross-machine visibility. GitHub-branch-as-bus is sharper but hits the Copilot review cost trap from enterprise ruleset #16490134 (`review_on_push: true` on ~ALL repos = burns premium requests on minute-cron pushes). | ||
|
|
||
| ## Design space (options in row body) | ||
|
|
||
| - Machine-local /tmp/zeta-bus/scarcity-<ts>.json — single-machine only | ||
| - Long-lived LFG branch with ruleset carve-out for Copilot review | ||
| - Sidecar repo (LFG/Zeta-bus) without enterprise ruleset | ||
| - GitHub Action cron writes single state file | ||
| - Gist with append-only updates | ||
|
|
||
| Each has trade-offs; row body weighs them. Aaron's explicit framing: 'we can build and try a few different things' — authorizes experimentation rather than pre-commits. | ||
|
|
||
| ## Composes with | ||
|
|
||
| - [B-0570](https://github.com/Lucent-Financial-Group/Zeta/pull/3950) (scarcity tracker — REFINES substrate location, keeps tracker logic) | ||
| - B-0400 (bus protocol) | ||
| - [B-0571](https://github.com/Lucent-Financial-Group/Zeta/pull/3951) (GitHub App — separate pool that would also be tracked) | ||
| - [B-0580](https://github.com/Lucent-Financial-Group/Zeta/pull/3957) (Enterprise ruleset — the cost trap to navigate) | ||
| - [B-0582](https://github.com/Lucent-Financial-Group/Zeta/pull/3964) (destructive-verb gate — adjacent infrastructure) | ||
|
|
||
| 🤖 Generated with [Claude Code](https://claude.com/claude-code) | ||
|
|
||
| ## Reviews | ||
|
|
||
| ### COMMENTED — @copilot-pull-request-reviewer (2026-05-16T23:36:33Z) | ||
|
|
||
| ## Pull request overview | ||
|
|
||
| Adds backlog row B-0583 refining B-0570's substrate location: the scarcity tracker should be account-scoped (not agent-scoped) and cross-machine visible, with a design-space exploration of bus surface options. | ||
|
|
||
| **Changes:** | ||
| - New per-row file `docs/backlog/P2/B-0583-*.md` documenting the refinement, design space, acceptance criteria, and open questions. | ||
| - Generated index entry added to `docs/BACKLOG.md` under P2. | ||
|
|
||
| ### Reviewed changes | ||
|
|
||
| Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments. | ||
|
|
||
| | File | Description | | ||
| | ---- | ----------- | | ||
| | docs/backlog/P2/B-0583-cross-machine-account-scoped-scarcity-bus-2026-05-16.md | New P2 backlog row refining B-0570 substrate location for cross-machine, account-scoped scarcity tracking. | | ||
| | docs/BACKLOG.md | Adds the generated index entry for B-0583 under the P2 section. | | ||
|
|
||
| ### COMMENTED — @copilot-pull-request-reviewer (2026-05-17T00:13:59Z) | ||
|
|
||
| ## Pull request overview | ||
|
|
||
| Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| --- | ||
| pr_number: 3975 | ||
| title: "docs(tick): 2341Z Otto-CLI background worker \u2014 PR #3964 thread resolution" | ||
| author: "AceHack" | ||
| state: "MERGED" | ||
| created_at: "2026-05-16T23:42:45Z" | ||
| merged_at: "2026-05-17T00:07:14Z" | ||
| closed_at: "2026-05-17T00:07:14Z" | ||
| head_ref: "worktree-gentle-imagining-squirrel" | ||
| base_ref: "main" | ||
| archived_at: "2026-05-17T01:13:18Z" | ||
| archive_tool: "tools/pr-preservation/archive-pr.ts" | ||
| --- | ||
|
|
||
| # PR #3975: docs(tick): 2341Z Otto-CLI background worker — PR #3964 thread resolution | ||
|
|
||
| ## PR description | ||
|
|
||
| ## Summary | ||
|
|
||
| Tick shard capturing background-worker substantive work this tick: | ||
|
|
||
| - Sentinel re-armed (catch-43) | ||
| - Polled 105 open PRs; identified 4 BLOCKED+resolve-threads | ||
| - 3 are Lior-lane (Lior actively running, skipped per lane discipline) | ||
| - PR #3964 (B-0582 destructive-verb refusal gate) actioned: 3 Copilot threads resolved | ||
| - Grammar fix (line 67) | ||
| - Acceptance criteria restructured (wrapper OR hook → both required, explicit close condition) | ||
| - composes_with refs left in place (stale-but-fresh-looking, in-flight sibling PRs) | ||
| - Post-state: PR #3964 has unresolvedThreads=0, auto-merge armed, waiting on CI | ||
|
|
||
| ## Test plan | ||
|
|
||
| - [ ] CI green on this PR (docs-only tick shard, no code path touched) | ||
| - [ ] PR #3964 auto-merges once its required checks complete | ||
|
|
||
| ## Reviews | ||
|
|
||
| ### COMMENTED — @chatgpt-codex-connector (2026-05-16T23:44:02Z) | ||
|
|
||
|
|
||
| ### 💡 Codex Review | ||
|
|
||
| Here are some automated review suggestions for this pull request. | ||
|
|
||
| **Reviewed commit:** `58d4bceaec` | ||
|
|
||
|
|
||
| <details> <summary>ℹ️ About Codex in GitHub</summary> | ||
| <br/> | ||
|
|
||
| [Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you | ||
| - Open a pull request for review | ||
| - Mark a draft as ready | ||
| - Comment "@codex review". | ||
|
|
||
| If Codex has suggestions, it will comment; otherwise it will react with 👍. | ||
|
|
||
|
|
||
| Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". | ||
|
|
||
| </details> | ||
|
|
||
| ### COMMENTED — @copilot-pull-request-reviewer (2026-05-16T23:46:42Z) | ||
|
|
||
| ## Pull request overview | ||
|
|
||
| Docs-only tick shard recording a background-worker session: re-armed the autonomous-loop sentinel, polled 105 open PRs, identified 4 BLOCKED+resolve-threads PRs (3 skipped per Lior-lane discipline), and resolved 3 Copilot threads on PR #3964. | ||
|
|
||
| **Changes:** | ||
| - Adds a new tick history file documenting the 2341Z session work and outcomes. | ||
|
|
||
| ### COMMENTED — @AceHack (2026-05-17T00:04:33Z) | ||
|
|
||
| _(no body)_ | ||
|
|
||
| ## Review threads | ||
|
|
||
| ### Thread 1: docs/hygiene-history/ticks/2026/05/16/2341Z.md:48 (resolved) | ||
|
|
||
| **@chatgpt-codex-connector** (2026-05-16T23:44:02Z): | ||
|
|
||
| **<sub><sub></sub></sub> Fix broken relative links in Composes with section** | ||
|
|
||
| The `Composes with` links use `../../../../../.claude/...`, but from `docs/hygiene-history/ticks/2026/05/16/` that path resolves to `docs/.claude/...` (nonexistent), so all four references in this section are dead. This breaks traceability for the tick record and should be updated to go up one more level (as used by sibling tick files) so links resolve to repo-root `.claude/rules/*`. | ||
|
|
||
| Useful? React with 👍 / 👎. | ||
|
|
||
| **@AceHack** (2026-05-17T00:04:33Z): | ||
|
|
||
| Confirmed — tick file is 6 levels deep under repo root; sibling tick files use `../../../../../../.claude/rules/*`. Fixed in e2db2c4e plus an MD032 blank-line fix for the lint job. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| --- | ||
| pr_number: 3983 | ||
| title: "docs(tick): 0012Z Otto-CLI markdownlint fix on PR #3974" | ||
| author: "AceHack" | ||
| state: "MERGED" | ||
| created_at: "2026-05-17T00:15:12Z" | ||
| merged_at: "2026-05-17T00:23:54Z" | ||
| closed_at: "2026-05-17T00:23:54Z" | ||
| head_ref: "otto/tick-shard-0012z-md-fix-2026-05-17" | ||
| base_ref: "main" | ||
| archived_at: "2026-05-17T01:13:17Z" | ||
| archive_tool: "tools/pr-preservation/archive-pr.ts" | ||
| --- | ||
|
|
||
| # PR #3983: docs(tick): 0012Z Otto-CLI markdownlint fix on PR #3974 | ||
|
|
||
| ## PR description | ||
|
|
||
| ## Summary | ||
|
|
||
| Cold-boot autonomous-loop tick. PR #3974 was BLOCKED with auto-merge armed on a single failing required check (`lint (markdownlint)` MD032 on B-0583 backlog row). | ||
|
|
||
| Per [`.claude/rules/blocked-green-ci-investigate-threads.md`](.claude/rules/blocked-green-ci-investigate-threads.md), investigated rather than waited. Fix landed on the B-0583 branch via commit `5ebe94b` (single blank line between intro sentence and following list at line 42-43). | ||
|
|
||
| This PR ships the per-tick shard documenting the cold-boot path: CronList → arm sentinel → refresh → named-dependency surface → fix → push → shard. | ||
|
|
||
| ## Concrete artifacts | ||
|
|
||
| - Commit `5ebe94b` on [PR #3974](https://github.com/Lucent-Financial-Group/Zeta/pull/3974) — the actual lint fix (separate PR) | ||
| - Sentinel cron job `11dfdf7f` armed (`<<autonomous-loop>>` every minute) | ||
| - Shard: `docs/hygiene-history/ticks/2026/05/17/0012Z.md` (this PR) | ||
|
|
||
| ## Test plan | ||
|
|
||
| - [x] Shard markdown structure follows recent convention | ||
| - [ ] CI passes on this shard-only PR | ||
| - [ ] PR #3974 lint re-run on `5ebe94b` passes (named-dependency-wait, next tick) | ||
|
|
||
| 🤖 Generated with [Claude Code](https://claude.com/claude-code) | ||
|
|
||
| ## Reviews | ||
|
|
||
| ### COMMENTED — @copilot-pull-request-reviewer (2026-05-17T00:18:43Z) | ||
|
|
||
| ## Pull request overview | ||
|
|
||
| This PR adds a single hygiene-history tick shard documenting the 0012Z Otto-CLI cold-boot path and the markdownlint fix pushed to PR #3974. | ||
|
|
||
| **Changes:** | ||
| - Adds a new per-tick shard for 2026-05-17 0012Z. | ||
| - Records refresh, dependency investigation, fix/commit/push, CronList, and visibility state. | ||
|
|
||
| ## Review threads | ||
|
|
||
| ### Thread 1: docs/hygiene-history/ticks/2026/05/17/0012Z.md:1 (resolved) | ||
|
|
||
| **@copilot-pull-request-reviewer** (2026-05-17T00:18:43Z): | ||
|
|
||
| This shard starts with an H1, but the tick shard schema and validator require the first non-empty line to be the pipe-delimited timestamp row matching the path. As written, `tools/hygiene/check-tick-history-shard-schema.ts --files docs/hygiene-history/ticks/2026/05/17/0012Z.md` would reject this file with a 0-pipe first row, so either add the schema row first or update the schema/validator if the heading format is now intentional. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| --- | ||
| pr_number: 3995 | ||
| title: "test(B-0156): smoke tests for tools/profile.ts CLI dispatcher" | ||
| author: "AceHack" | ||
| state: "MERGED" | ||
| created_at: "2026-05-17T00:58:49Z" | ||
| merged_at: "2026-05-17T01:02:44Z" | ||
| closed_at: "2026-05-17T01:02:44Z" | ||
| head_ref: "otto/b0156-profile-test-2026-05-16" | ||
| base_ref: "main" | ||
| archived_at: "2026-05-17T01:13:15Z" | ||
| archive_tool: "tools/pr-preservation/archive-pr.ts" | ||
| --- | ||
|
|
||
| # PR #3995: test(B-0156): smoke tests for tools/profile.ts CLI dispatcher | ||
|
|
||
| ## PR description | ||
|
|
||
| ## Summary | ||
|
|
||
| Adds `tools/profile.test.ts` — 9 smoke tests covering the CLI | ||
| dispatch surface of `tools/profile.ts`. Closes the last gap in | ||
| [B-0156](../blob/main/docs/backlog/P1/B-0156-typescript-standardization-non-install-scripts-aaron-2026-05-01.md) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The archived description still uses Useful? React with 👍 / 👎. |
||
| acceptance criterion #2 ("each TS sibling has at least one | ||
| `bun test` covering its primary entry path"). | ||
|
|
||
| `amara.ts` + `ani.ts` are already covered by | ||
| `tools/peer-call/smoke.test.ts` (B-0421 #4). `profile.ts` was | ||
| the lone remaining TS port without a sibling test. | ||
|
|
||
| ## Scope discipline — dispatch only, NOT live dotnet tools | ||
|
|
||
| Mirrors `tools/peer-call/smoke.test.ts`: validates the | ||
| switch-statement entry path, NOT the `dotnet-counters` / | ||
| `dotnet-trace` / `dotnet-gcdump` / `BenchmarkDotNet` / | ||
| `reportgenerator` invocations. Those tools are not guaranteed | ||
| installed in CI, so live subcommand testing is out of scope. | ||
|
|
||
| The 9 tests: | ||
|
|
||
| 1. File exists at canonical path | ||
| 2. No-args → help + exit 0 | ||
| 3. `-h` → help + exit 0 | ||
| 4. `--help` → help + exit 0 | ||
| 5. Unknown command → exit 64 (EX_USAGE) | ||
| 6. `counters` without pid → exit 64 + stderr usage | ||
| 7. `trace` without pid → exit 64 + stderr usage | ||
| 8. `gcdump` without pid → exit 64 + stderr usage | ||
| 9. Help text references every documented subcommand | ||
| (doc-drift catcher — every `case` in the switch must | ||
| appear in the default `printf` help block) | ||
|
|
||
| ## Substrate-drift step-0 result | ||
|
|
||
| Per | ||
| [`backlog-item-start-gate.md`](../blob/main/.claude/rules/backlog-item-start-gate.md): | ||
|
|
||
| - B-0156's "3 ports remaining" audit baseline is stale — | ||
| all three `.sh` files (`profile.sh`, `peer-call/amara.sh`, | ||
| `peer-call/ani.sh`) have been deleted; TS siblings present. | ||
| - Phase 5 (bash sweep) already complete. | ||
| - BUT row is NOT pure-drift: AC #2 unmet for `profile.ts`. | ||
| - Bounded slice = add the missing test. This PR. | ||
|
|
||
| After this PR lands, AC #2 is fully met across all 6 | ||
| non-install TS ports. The remaining ACs (#5 package.json | ||
| script update audit, #6 no-regression confirmation) can be | ||
| addressed in follow-up slices or the row can be closed | ||
| substrate-honestly. | ||
|
|
||
| ## Test plan | ||
|
|
||
| - [x] `bun test tools/profile.test.ts` → 9 pass / 0 fail | ||
| / 21 expect() calls / 1158ms | ||
| - [x] No new `.sh` introduced; no `.py` introduced | ||
| - [x] No changes to `tools/profile.ts` itself (test-only PR) | ||
| - [ ] CI green on required checks | ||
|
|
||
| ## Operative authorization | ||
|
|
||
| aaron 2026-05-14: "- **Devil-pole** (edge-runner drive): | ||
| keep pushing, discover, go hard, never-be-idle" | ||
|
|
||
| 🤖 Generated with [Claude Code](https://claude.com/claude-code) | ||
|
|
||
| ## Reviews | ||
|
|
||
| ### COMMENTED — @copilot-pull-request-reviewer (2026-05-17T01:03:05Z) | ||
|
|
||
| ## Pull request overview | ||
|
|
||
| Adds Bun smoke-test coverage for the `tools/profile.ts` CLI dispatcher (B-0156 AC #2), ensuring the help/dispatch surface is exercised without invoking external `dotnet-*` tooling in CI. | ||
|
|
||
| **Changes:** | ||
| - Added `tools/profile.test.ts` with 9 dispatch-surface smoke tests (help paths, EX_USAGE handling, missing pid handling, and help text subcommand coverage). | ||
| - Added a hygiene-history tick shard documenting the work session and verification. | ||
|
|
||
| ### Reviewed changes | ||
|
|
||
| Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment. | ||
|
|
||
| | File | Description | | ||
| | ---- | ----------- | | ||
| | tools/profile.test.ts | New Bun smoke tests for `tools/profile.ts` CLI dispatch behavior (no live dotnet tool execution). | | ||
| | docs/hygiene-history/ticks/2026/05/17/0057Z.md | Tick shard documenting the bounded slice and local verification. | | ||
|
|
||
| ## Review threads | ||
|
|
||
| ### Thread 1: docs/hygiene-history/ticks/2026/05/17/0057Z.md:8 (unresolved) | ||
|
|
||
| **@copilot-pull-request-reviewer** (2026-05-17T01:03:05Z): | ||
|
|
||
| P2 (nit): This tick shard uses YAML frontmatter but does not include the canonical pipe-row entry (`| <timestamp> | <model id> | ... |`) described in docs/hygiene-history/ticks/README.md. Adding the pipe-row (even if you also keep the richer narrative) would keep the shard machine-parseable by existing hygiene tooling and reduce further schema drift. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This archive entry links to
.claude/rules/...as if it were at repo root, but fromdocs/pr-discussions/that resolves todocs/pr-discussions/.claude/...(nonexistent). In practice, readers of this preserved PR cannot open the cited rule, which breaks the traceability this archive is meant to provide; use a path that resolves from this directory (for example../../.claude/...) or an absolute GitHub URL.Useful? React with 👍 / 👎.