-
Notifications
You must be signed in to change notification settings - Fork 1
docs: file actual HB-005 — AceHack fork settings mirror LFG (un-phantomize #377 reference) #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -237,6 +237,8 @@ are ordered by `State: Open` first, then `Stale`, then | |||||||||
|
|
||||||||||
| | HB-004 | 2026-04-23 | decision / branch-protection | **REVISED TWICE 2026-04-23 same day; finally resolved on empirical finding.** First revision: the human maintainer's sharpening ("more checks that gate merges the better ... ignore with peer-reviewed justification") inverted my initial "remove from required" recommendation. Second revision (auto-loop-69): empirical check of LFG's actual `branches/main/protection` via `gh api` showed `submit-nuget` is **NOT in required checks**. Required set: `build-and-test (ubuntu-22.04)`, `lint (semgrep)`, `lint (shellcheck)`, `lint (actionlint)`, `lint (markdownlint)`. Verified on PR #170: all required checks pass (`submit-nuget: FAILURE` but not in required set); `mergeStateStatus: BLOCKED` with `req_failing: []`. Real blocker is `required_status_checks.strict: true` (branch-currency — PR base is at `d548219`, main has advanced); PR must be updated with main before merge. Correct resolution: **no settings change needed** — submit-nuget isn't gating merges. Stuck PRs should rebase / update from main (mechanical free work) or enable auto-merge-with-squash so GitHub updates + merges when criteria met. HB-004's entire premise ("submit-nuget blocks merge") was wrong; I saw `FAILURE` in the checks list and assumed it blocked without reading the protection rules. Lesson: investigate the actual gate-set before proposing gate-changes. | `gh api /repos/Lucent-Financial-Group/Zeta/branches/main/protection` (2026-04-23 auto-loop-69) + `gh pr view 170 --json mergeStateStatus,mergeable,reviewDecision` + the human maintainer's 2026-04-23 branch-protection delegation + same-day sharpening directive + per-user memory (not in-repo; lives at `~/.claude/projects/<slug>/memory/feedback_branch_protection_settings_are_agent_call_external_contribution_ready_2026_04_23.md`) | Resolved | No settings change. Stuck PRs unblock by rebasing / updating from main (mechanical free work) or enabling auto-merge-with-squash. `submit-nuget` FAILURE is visible but non-blocking. Real gate: `strict: true` branch-currency. | | ||||||||||
|
|
||||||||||
| | HB-005 | 2026-04-24 | decision / settings-parity | Crank up AceHack fork's branch-protection + settings to match Lucent-Financial-Group/Zeta (LFG) canonical, where the feature is available on personal accounts. Aaron directive 2026-04-24: *"they are cranked up good on LFG but should also be cranked up good on AceHack very similar if not the same where possible."* Some features are **platform-limit asymmetric** (merge queue is GitHub-org-only; personal repos like AceHack/Zeta cannot enable it — per HB-001 migration rationale). This asymmetry is unwanted — Aaron 2026-04-24 on the correction: *"it's not intentional, i wish we could use merge queue on acehack but i don't think they give that to personal repos only org repos."* Everything else (required-status-checks, required-conversation-resolution, dismiss-stale-reviews, auto-delete-head-branch, auto-merge, dependabot, secret-scanning where available on personal tier, etc) should be symmetric. PR hygiene implication: AceHack's `strict=true` is tolerable because all PRs post-drain route two-hop (AceHack → LFG, per Otto-223), so LFG's merge queue + stricter settings catch stale-merge cases downstream; document the platform-forced merge-queue asymmetry (not a preference) in `docs/GITHUB-SETTINGS.md`. Approach: run `tools/hygiene/snapshot-github-settings.sh --repo AceHack/Zeta` + same for LFG; diff the 13 settings groups; write up the diff for human review; apply changes where the feature is available. | maintainer 2026-04-24 tick *"ACTIONLINT_VERSION should be part of our deployed tooling... dev machines will need this to, remember the dev machine / build machine parity requirement"* + same-day *"they are cranked up good on LFG but should also be cranked up good on AceHack very similar if not the same where possible"*; HB-001 (org migration) established the LFG canonical + AceHack fork two-repo setup; Otto-223 two-hop flow (`feedback_post_drain_prs_to_acehack_first_for_copilot_then_push_to_lfg_otto_223_2026_04_24.md`). | Open | | | ||||||||||
|
||||||||||
| | HB-005 | 2026-04-24 | decision / settings-parity | Crank up AceHack fork's branch-protection + settings to match Lucent-Financial-Group/Zeta (LFG) canonical, where the feature is available on personal accounts. Aaron directive 2026-04-24: *"they are cranked up good on LFG but should also be cranked up good on AceHack very similar if not the same where possible."* Some features are **platform-limit asymmetric** (merge queue is GitHub-org-only; personal repos like AceHack/Zeta cannot enable it — per HB-001 migration rationale). This asymmetry is unwanted — Aaron 2026-04-24 on the correction: *"it's not intentional, i wish we could use merge queue on acehack but i don't think they give that to personal repos only org repos."* Everything else (required-status-checks, required-conversation-resolution, dismiss-stale-reviews, auto-delete-head-branch, auto-merge, dependabot, secret-scanning where available on personal tier, etc) should be symmetric. PR hygiene implication: AceHack's `strict=true` is tolerable because all PRs post-drain route two-hop (AceHack → LFG, per Otto-223), so LFG's merge queue + stricter settings catch stale-merge cases downstream; document the platform-forced merge-queue asymmetry (not a preference) in `docs/GITHUB-SETTINGS.md`. Approach: run `tools/hygiene/snapshot-github-settings.sh --repo AceHack/Zeta` + same for LFG; diff the 13 settings groups; write up the diff for human review; apply changes where the feature is available. | maintainer 2026-04-24 tick *"ACTIONLINT_VERSION should be part of our deployed tooling... dev machines will need this to, remember the dev machine / build machine parity requirement"* + same-day *"they are cranked up good on LFG but should also be cranked up good on AceHack very similar if not the same where possible"*; HB-001 (org migration) established the LFG canonical + AceHack fork two-repo setup; Otto-223 two-hop flow (`feedback_post_drain_prs_to_acehack_first_for_copilot_then_push_to_lfg_otto_223_2026_04_24.md`). | Open | | | |
| | HB-005 | 2026-04-24 | decision / settings-parity | Crank up AceHack fork's branch-protection + settings to match Lucent-Financial-Group/Zeta (LFG) canonical, where the feature is available on personal accounts. Human maintainer directive 2026-04-24: *"they are cranked up good on LFG but should also be cranked up good on AceHack very similar if not the same where possible."* Some features are **platform-limit asymmetric** (merge queue is GitHub-org-only; personal repos like AceHack/Zeta cannot enable it — per HB-001 migration rationale). This asymmetry is unwanted — Aaron 2026-04-24 on the correction: *"it's not intentional, i wish we could use merge queue on acehack but i don't think they give that to personal repos only org repos."* Everything else (required-status-checks, required-conversation-resolution, dismiss-stale-reviews, auto-delete-head-branch, auto-merge, dependabot, secret-scanning where available on personal tier, etc) should be symmetric. PR hygiene implication: AceHack's `strict=true` is tolerable because all PRs post-drain route two-hop (AceHack → LFG, per Otto-223), so LFG's merge queue + stricter settings catch stale-merge cases downstream; document the platform-forced merge-queue asymmetry (not a preference) in `docs/GITHUB-SETTINGS.md`. Approach: run `tools/hygiene/snapshot-github-settings.sh --repo AceHack/Zeta` + same for LFG; diff the 13 settings groups; write up the diff for human review; apply changes where the feature is available. | maintainer 2026-04-24 tick *"ACTIONLINT_VERSION should be part of our deployed tooling... dev machines will need this to, remember the dev machine / build machine parity requirement"* + same-day *"they are cranked up good on LFG but should also be cranked up good on AceHack very similar if not the same where possible"*; HB-001 (org migration) established the LFG canonical + AceHack fork two-repo setup; Otto-223 two-hop flow (`feedback_post_drain_prs_to_acehack_first_for_copilot_then_push_to_lfg_otto_223_2026_04_24.md`). | Open | | |
Copilot
AI
Apr 24, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1 (truth drift): HB-005 asserts that “LFG’s merge queue … catch[es] stale-merge cases downstream”, but the checked-in settings snapshot for Lucent-Financial-Group/Zeta doesn’t show any merge-queue rule enabled (see tools/hygiene/github-settings.expected.json rulesets). If merge queue is still an opt-in future step, please reword this to be conditional (“once/if merge queue is enabled on LFG…”) so the row doesn’t read as claiming it’s already active.
| | HB-005 | 2026-04-24 | decision / settings-parity | Crank up AceHack fork's branch-protection + settings to match Lucent-Financial-Group/Zeta (LFG) canonical, where the feature is available on personal accounts. Aaron directive 2026-04-24: *"they are cranked up good on LFG but should also be cranked up good on AceHack very similar if not the same where possible."* Some features are **platform-limit asymmetric** (merge queue is GitHub-org-only; personal repos like AceHack/Zeta cannot enable it — per HB-001 migration rationale). This asymmetry is unwanted — Aaron 2026-04-24 on the correction: *"it's not intentional, i wish we could use merge queue on acehack but i don't think they give that to personal repos only org repos."* Everything else (required-status-checks, required-conversation-resolution, dismiss-stale-reviews, auto-delete-head-branch, auto-merge, dependabot, secret-scanning where available on personal tier, etc) should be symmetric. PR hygiene implication: AceHack's `strict=true` is tolerable because all PRs post-drain route two-hop (AceHack → LFG, per Otto-223), so LFG's merge queue + stricter settings catch stale-merge cases downstream; document the platform-forced merge-queue asymmetry (not a preference) in `docs/GITHUB-SETTINGS.md`. Approach: run `tools/hygiene/snapshot-github-settings.sh --repo AceHack/Zeta` + same for LFG; diff the 13 settings groups; write up the diff for human review; apply changes where the feature is available. | maintainer 2026-04-24 tick *"ACTIONLINT_VERSION should be part of our deployed tooling... dev machines will need this to, remember the dev machine / build machine parity requirement"* + same-day *"they are cranked up good on LFG but should also be cranked up good on AceHack very similar if not the same where possible"*; HB-001 (org migration) established the LFG canonical + AceHack fork two-repo setup; Otto-223 two-hop flow (`feedback_post_drain_prs_to_acehack_first_for_copilot_then_push_to_lfg_otto_223_2026_04_24.md`). | Open | | | |
| | HB-005 | 2026-04-24 | decision / settings-parity | Crank up AceHack fork's branch-protection + settings to match Lucent-Financial-Group/Zeta (LFG) canonical, where the feature is available on personal accounts. Aaron directive 2026-04-24: *"they are cranked up good on LFG but should also be cranked up good on AceHack very similar if not the same where possible."* Some features are **platform-limit asymmetric** (merge queue is GitHub-org-only; personal repos like AceHack/Zeta cannot enable it — per HB-001 migration rationale). This asymmetry is unwanted — Aaron 2026-04-24 on the correction: *"it's not intentional, i wish we could use merge queue on acehack but i don't think they give that to personal repos only org repos."* Everything else (required-status-checks, required-conversation-resolution, dismiss-stale-reviews, auto-delete-head-branch, auto-merge, dependabot, secret-scanning where available on personal tier, etc) should be symmetric. PR hygiene implication: AceHack's `strict=true` is tolerable because all PRs post-drain route two-hop (AceHack → LFG, per Otto-223), so, once LFG enables merge queue, LFG's merge queue plus its stricter settings will catch stale-merge cases downstream; until then, only the stricter settings apply downstream. Document the platform-forced merge-queue asymmetry (not a preference) in `docs/GITHUB-SETTINGS.md`. Approach: run `tools/hygiene/snapshot-github-settings.sh --repo AceHack/Zeta` + same for LFG; diff the 13 settings groups; write up the diff for human review; apply changes where the feature is available. | maintainer 2026-04-24 tick *"ACTIONLINT_VERSION should be part of our deployed tooling... dev machines will need this to, remember the dev machine / build machine parity requirement"* + same-day *"they are cranked up good on LFG but should also be cranked up good on AceHack very similar if not the same where possible"*; HB-001 (org migration) established the LFG canonical + AceHack fork two-repo setup; Otto-223 two-hop flow (`feedback_post_drain_prs_to_acehack_first_for_copilot_then_push_to_lfg_otto_223_2026_04_24.md`). | Open | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1 (xref): The row cites
feedback_post_drain_prs_to_acehack_first_for_copilot_then_push_to_lfg_otto_223_2026_04_24.md, but that file does not exist anywhere in-repo (including undermemory/). This makes the HB-005 provenance non-auditable; either add the missing memory entry (matching the filename) or update the reference to an existing artifact (e.g., amemory/feedback_*file that actually records the AceHack→LFG two-hop rule, ordocs/FACTORY-DISCIPLINE.mdwhere the rule is already summarized).