Skip to content

shard(tick): 2026-05-16T02:52Z — audit filter triage (17→10) + baseline-cleanup question#3695

Merged
AceHack merged 2 commits into
mainfrom
shard/tick-0252z-otto-cli-2026-05-16
May 16, 2026
Merged

shard(tick): 2026-05-16T02:52Z — audit filter triage (17→10) + baseline-cleanup question#3695
AceHack merged 2 commits into
mainfrom
shard/tick-0252z-otto-cli-2026-05-16

Conversation

@AceHack
Copy link
Copy Markdown
Member

@AceHack AceHack commented May 16, 2026

Tick 8 substantive landing: filter improvement on PR #3692's audit script (isPlaceholderTarget skips ellipsis/paren/identifier placeholders), reducing baseline 17 → 10 findings. The 10 remaining are real wrong-depth .. bugs in 2 shards.

Open question for next tick: tick-shard immutability discipline strict vs pragmatic — can the 10 be edited in-place (treat as bug-fix), or do they need a grandfather mechanism (Stryker-baseline-style)?

GraphQL rate-limit still 0; resets 02:55:28Z. 3 PRs queued un-armed: #3690 #3692 #3693.

Co-Authored-By: Claude noreply@anthropic.com

…ne-cleanup question

Fixup commit on PR #3692 branch: skip placeholder targets in the tick-shard
relative-path audit. Filter: target contains ... (ellipsis), parens (fragment),
or pure identifier (no / and no .) — drops the 7 false positives.

Remaining 10 findings concentrated in 2 shards (1436Z + 0329Z) with real
wrong-depth .. bugs. Baseline-cleanup question opens: tick-shard immutability
discipline strict vs pragmatic reading. Decision deferred to next-tick or
coordinated review.

GraphQL still 0/5000 (resets 02:55:28Z, 158s away). 3 PRs in queue un-armed.

Co-Authored-By: Claude <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 16, 2026 02:54
@AceHack AceHack enabled auto-merge (squash) May 16, 2026 02:55
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new tick shard documenting the 02:52Z audit-filter triage work, including the PR #3692 placeholder-target filter improvement and the remaining baseline-cleanup decision.

Changes:

  • Records the 17→10 audit finding reduction after placeholder filtering.
  • Documents the open strategy question for tick-shard relative-path baseline cleanup.
  • Captures current PR queue state and next-tick candidates.

Comment thread docs/hygiene-history/ticks/2026/05/16/0252Z.md
Comment thread docs/hygiene-history/ticks/2026/05/16/0252Z.md Outdated
Comment thread docs/hygiene-history/ticks/2026/05/16/0252Z.md Outdated
Copilot P1 #1 (line 53): citation said "claim-acquire-before-worktree-work.md
rule's ID allocation discipline section" — but that section is in
otto-channels-reference-card.md, not the acquire rule. Replace with the
canonical statement at docs/hygiene-history/ticks/README.md ("Each shard
is an immutable per-tick event") + the Event Sourcing / CQRS framing
that's actually the basis.

Copilot P1 #2 (line 96): "check at 25:44 from then = 02:44Z+" was wrong
math. Bus-claim 24h TTL from 01:44Z expires at 2026-05-17T01:44Z, not
02:44Z same day. Fix the calculation.

The third thread (line 4 — parent-tick link to 0249Z.md "not present") is
now stale: PR #3693 merged 0249Z to main at 02:55:44Z. Will resolve no-op.

Co-Authored-By: Claude <noreply@anthropic.com>
@AceHack AceHack merged commit bb4782d into main May 16, 2026
24 checks passed
@AceHack AceHack deleted the shard/tick-0252z-otto-cli-2026-05-16 branch May 16, 2026 03:02
AceHack added a commit that referenced this pull request May 16, 2026
…cleanup (#3697)

GraphQL reset at 02:55:28Z. Arm wave on 4 queued PRs (3690/3692/3693/3695):
- #3693 was already MERGED at 02:55:44Z by AceHack (16s after reset)
- #3690 + #3692 + #3695 armed (auto-merge squash)

8 unresolved threads investigated:
- #3690 (1 thread): table-pipe complaint = Copilot false positive (verified
  by awk; lines 18/37/65 all use single |). Resolved no-op.
- #3692 (4 threads): ALL real — sonarjs disable comment, main+import.meta.main
  guard, generic URI scheme regex (ftp/file/tel/data), --files validation.
  Fixed via commit d299c7d. Resolved.
- #3695 (3 threads): 2 real prose errors in 0252Z shard (wrong rule citation;
  wrong TTL math), 1 stale link (0249Z.md now on main via merged #3693).
  Fixed via commit e0828b5. Resolved.

3 PRs queued + armed + thread-clean: #3690 #3692 #3695. Awaiting CI.

Discipline reinforced: verify-before-fixing applies to Copilot reviewer
output too. Direct line-level inspection (awk) beats taking review at face
value.

Co-authored-by: Claude <noreply@anthropic.com>
AceHack added a commit that referenced this pull request May 16, 2026
…eal cross-platform fixes) (#3698)

PR #3695 (0252Z + prose fixes) merged 03:02:45Z. Second-pass Copilot review
on PR #3692 surfaced 2 real findings:
- P1: --files validation rejected only missing paths; directories pass
  existsSync but fail later in readFileSync. Add statSync.isFile() check.
- P2: ROOT + "/" prefix breaks on Windows (resolve returns \\-separated
  paths). Use platform-correct PATH_SEP from node:path.

Fixup commit 4e80655 pushed; both threads resolved. 6-tick audit lifecycle
matches §33 pattern (PR #3513#3552 → enforce) compressed.

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants