docs(archive): Lior preservation of merged PR 3607#3610
Open
AceHack wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Manual preservation of merged PR #3607 due to a GraphQL rate limit blocking the automated archive tool, plus a shadow lesson log documenting an Array failure mode and the corrective intervention.
Changes:
- Add manual fallback PR archive for #3607 under
docs/pr-discussions/. - Add shadow lesson log under
docs/research/capturing worktree-isolation and action-over-narration lessons.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8da1378253
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4 tasks
AceHack
added a commit
that referenced
this pull request
May 15, 2026
…hread PRs left (#3620) - 6 min post rate-limit reset; 4177 GraphQL remaining at tick start - Cheap-survey via gh pr list (single call) instead of poll-pr-gate-batch (37 calls) - 2 thread-free candidates armed: #3618 (B-0544 research) + #3617 (Lior 23:05Z drift; merged immediately) - 2 thread-laden candidates LEFT alone: #3610 (codex P2 archive naming) + #3609 (copilot P1+P2 on Lior content) — Lior-payload thread resolution pending peer-Lior cycle - Budget consumption: 26 units this tick — sustainable - New rule of thumb: avoid poll-pr-gate-batch --all-open unless budget < 30%; prefer gh pr list + per-candidate thread query Co-authored-by: Claude <noreply@anthropic.com>
AceHack
added a commit
that referenced
this pull request
May 15, 2026
… artifact + safe-lock-removal note - Cross-references the preserved discussion artifact `docs/pr-discussions/PR-3607.md` (landing in companion PR #3610) so the "PR preservation protocol for #3607" reference is traceable in-repo without #3609 carrying the artifact itself. - Replaces the unsafe "cleared the config.lock file" guidance with an explicit 4-step safe-remediation sequence: process check → name the specific lock → prefer resolving the originating process → re-verify with git status. Names .git/config.lock vs .git/index.lock vs worktree-scoped locks to prevent future agents from blanket rm .git/*.lock. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
AceHack
added a commit
that referenced
this pull request
May 15, 2026
* docs(shadow): Lior antigravity check 22:45Z - drift report * docs(shadow): address Copilot review on PR #3609 — cross-link PR-3607 artifact + safe-lock-removal note - Cross-references the preserved discussion artifact `docs/pr-discussions/PR-3607.md` (landing in companion PR #3610) so the "PR preservation protocol for #3607" reference is traceable in-repo without #3609 carrying the artifact itself. - Replaces the unsafe "cleared the config.lock file" guidance with an explicit 4-step safe-remediation sequence: process check → name the specific lock → prefer resolving the originating process → re-verify with git status. Names .git/config.lock vs .git/index.lock vs worktree-scoped locks to prevent future agents from blanket rm .git/*.lock. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
… (Codex P2) Codex review on PR #3610 flagged that the manual fallback archive `PR-3607.md` would not be detected by `tools/pr-preservation/archive-pr.ts`'s `findExistingArchive`, which matches the `PR-<NNNN>-<slug>.md` pattern (prefix = `PR-${padStart(4, "0")}-`). A future archive-pr.ts re-run for #3607 after rate-limits recover would create a second archive file, breaking the one-PR/one-archive update contract. Renaming to the canonical shape preserves the idempotency contract. Slug computed from the PR title "shard(tick): 2220Z — null arm-sweep; prior-tick PRs landing" via the same `makeSlug` regex used in archive-pr.ts: `shard-tick-2220z-null-arm-sweep-prior-tick-prs-landing` (54 chars, under the 60-char limit). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic preservation discipline for PR 3607 (Manual fallback due to GraphQL rate limit).