fix(otto-279): role-refs in tools/github/test + tools/peer-call (2 hits)#3576
Merged
AceHack merged 1 commit intoMay 15, 2026
Merged
Conversation
Otto-279 cleanup batch #4. Same fix pattern as batches #1-#3 (PRs #3570, #3572, #3574). Files: - tools/github/poll-pr-gate-batch.test.ts:9 — `Per Aaron 2026-05-01` → `Per the human maintainer 2026-05-01` - tools/peer-call/append-identity-receipt.ts:307 — `Per Copilot 2026-05-06 review on PR #1702` → `Per PR #1702 review 2026-05-06` Verbatim quote content preserved in both cases. Auditor verification: `bun tools/hygiene/audit-orphan-role-refs.ts` re-run shows 0 hits in target scope after fix. Remaining (next-batch candidates): - src/Core/Maji.fs + tests + tools/hygiene/audit-agencysignature-main-tip.ts + tools/hygiene/validate-agencysignature-pr-body.ts + docs/trajectories/.../slice-audits.md — `orphan-ferry-ref` class (different fix pattern — requires per-occurrence judgment) Composes with: PR #3570 (.claude/), PR #3572 (docs/), PR #3574 (tools/hygiene/audit-*.ts), tools/hygiene/audit-orphan-role-refs.ts, Otto-279 carve-out. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR continues the Otto-279 cleanup by removing remaining Per <Name> attributions in tools/* surfaces and replacing them with role-refs / non-personal attribution while preserving provenance (PR number + date) in comments.
Changes:
- Updated a peer-call tool comment to remove tool/persona-name attribution (“Per Copilot…”) while retaining traceability (“Per PR #1702 review…”).
- Updated a GitHub tooling test comment to replace a personal name with the role-ref “the human maintainer”.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/peer-call/append-identity-receipt.ts | Comment attribution adjusted to remove persona/tool name while keeping PR+date provenance. |
| tools/github/poll-pr-gate-batch.test.ts | Comment attribution updated from a personal name to the role-ref “the human maintainer”. |
3 tasks
AceHack
deleted the
fix/otto-279-role-refs-tools-test-peer-call-otto-cli-2026-05-15
branch
AceHack
added a commit
that referenced
this pull request
May 15, 2026
…tools/github/test + tools/peer-call (#3577) - PR #3572 + #3574 + #3575 wait-CI - PR #3576 — 2 final hits (Per Aaron in test, Per Copilot in peer-call) - 17 per-name-attribution fixes across 4 batches; all audit-flagged hits addressed - Remaining: orphan-ferry-ref class (different fix pattern; per-occurrence judgment) - Observation: audit regex doesn't catch multi-name attributions (e.g., "Per Codex + Copilot") - 20-tick session arc Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
AceHack
added a commit
that referenced
this pull request
May 15, 2026
…ilename paths (#3578) Captures the substrate-honest residual after this session's 4-batch Otto-279 per-name-attribution cleanup arc completed. Two issues: Part A — orphan-ferry-ref cleanup (5+ hits) requires per-occurrence judgment (not mechanical substitution), so deferred to its own row. Part B — audit-orphan-role-refs.ts has a false-positive: filenames containing "ferry-N" (e.g., maji-formal-operational-model-deep-research- peer-courier-ferry-2026-04-26.md) get flagged when referenced inside .fs/.ts/.md files. The audit regex needs to skip filename-path matches. ID allocation discipline: B-0531/B-0532/B-0533/B-0534/B-0535 taken on main; B-0536 verified free via gh pr list search. Composes with: 4-batch Otto-279 arc this session (PRs #3570, #3572, #3574, #3576), memory/feedback_orphan_role_ref_after_name_stripping_*.md (fix-pattern reference), tools/hygiene/audit-orphan-role-refs.ts. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
AceHack
added a commit
that referenced
this pull request
May 15, 2026
…alse-positive (#3579) - PR #3576 (Otto-279 batch #4) MERGED; full per-name-attribution arc on main + in-flight - PR #3574 + #3577 still wait-CI - PR #3578 — B-0536 backlog row filed (2-slice plan: per-occurrence cleanup + audit fix) - Substrate-honest residual capture: orphan-ferry-ref class is content-judgment, not mechanical - 21-tick session arc; cron live Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
AceHack
added a commit
that referenced
this pull request
May 15, 2026
…fix / row / quiet (#3583) Captures the explicit pattern empirically validated across the 23-tick Otto-CLI session 2026-05-15 (1718Z–2038Z): when uncertain what to do at a tick boundary, run an audit FIRST; let the result determine which of three actions applies. Three-way classification: - Mechanical fix-class → fix this tick as small atomic PR (Otto-279 4-batch arc: 17 fixes, PRs #3570/#3572/#3574/#3576) - Content-judgment class → file as backlog row (B-0535, B-0536, B-0537 — substrate-honest residual capture) - Null actionable → write quiet checkpoint shard (1919Z, 1952Z, 2038Z precedents) Resolves apparent tension between never-be-idle (do speculative work), razor-discipline (don't manufacture findings), and holding-without- named-dependency-is-standing-by-failure (Holding without real wait is the failure pattern). The audit output routes the decision. Composes with razor-discipline, no-op-cadence-failure-mode, holding- without-named-dependency-is-standing-by-failure, never-be-idle, encoding-rules-without-mechanizing, substrate-or-it-didn't-happen. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Otto-279 cleanup batch #4 — 2 remaining `Per ` hits in tools/* surfaces. Same fix pattern as PR #3570, PR #3572, PR #3574.
Files
Auditor verification
After fix: 0
per-name-attributionhits in target files (re-scan via `bun tools/hygiene/audit-orphan-role-refs.ts`).Otto-279 cleanup progress
Total: 17 `Per ` fixes across 4 batches. All `per-name-attribution` class violations addressed; `orphan-ferry-ref` class deferred (different fix pattern).
Test plan
🤖 Generated with Claude Code