Skip to content

fix(otto-279): role-refs not persona-names in tools/hygiene/audit-*.ts (9 hits) #3574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AceHack merged 2 commits into from
May 15, 2026
Merged

fix(otto-279): role-refs not persona-names in tools/hygiene/audit-*.ts (9 hits) #3574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
167a388
fix(otto-279): role-refs not persona-names in tools/hygiene/audit-*.t…
AceHack May 15, 2026
ba0c9f3
fix(otto-279): add PR #1702 number to ambiguous attribution comments …
AceHack May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/hygiene/audit-backlog-items.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ async function reportMergedCandidates(
"--json",
"number,title",
]);
// Per Codex 2026-05-06 review on PR #1702: never silently swallow
// Per PR #1702 review 2026-05-06: never silently swallow
// a non-zero exit. A failed gh call would otherwise scan zero PRs
// and report no candidates -- identical to genuine cleanliness --
// hiding auth/network breakage. Surface the failure as a SKIP.
Expand Down
8 changes: 4 additions & 4 deletions tools/hygiene/audit-lost-files.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ async function classClosedNotMergedPRs(ghAvailable: boolean): Promise<void> {
"--json",
"number,title,closedAt,mergedAt,headRefName",
]);
// Per Codex 2026-05-06 review: never silently swallow a non-zero
// Per PR #1702 review 2026-05-06: never silently swallow a non-zero
// exit. A failed gh call would otherwise produce "Count: 0", which
// looks identical to genuine cleanliness and hides auth/network
// breakage. Surface the failure as a SKIP with the gh stderr.
Expand Down Expand Up @@ -142,7 +142,7 @@ async function classOrphanBranches(ghAvailable: boolean): Promise<void> {
"--format=%(refname:short)",
"refs/remotes/origin/",
]);
// Per Codex 2026-05-06 review on PR #1702: surface git failures
// Per PR #1702 review 2026-05-06: surface git failures
// explicitly so the orphan-branch class isn't silently reported as
// empty when origin/main is missing or the local repo is bare.
if (refsResult.exitCode !== 0) {
Expand All @@ -163,7 +163,7 @@ async function classOrphanBranches(ghAvailable: boolean): Promise<void> {
console.log("");
return;
}
// Per Codex 2026-05-06 review: orphan-branch detection wants the
// Per PR #1702 review 2026-05-06: orphan-branch detection wants the
// OPEN-PR set ("which branches still have a live PR keeping them
// attached"), not all-states. Closed/merged PRs do not block a
// branch from being orphaned -- in fact, a closed-not-merged PR is
Expand Down Expand Up @@ -310,7 +310,7 @@ async function classDraftPRs(ghAvailable: boolean): Promise<void> {
"--json",
"number,title",
]);
// Per Codex 2026-05-06 review on PR #1702: never silently swallow
// Per PR #1702 review 2026-05-06: never silently swallow
// a non-zero exit. A failed gh call would otherwise print "Count: 0"
// -- identical to genuine cleanliness -- masking unreliable data.
if (r.exitCode !== 0) {
Expand Down
2 changes: 1 addition & 1 deletion tools/hygiene/audit-promotion-ledger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ async function main(): Promise<number> {
console.log(` - line ${pf.lineNo}: ${pf.reason}`);
}
console.log("");
// Per Codex 2026-05-06 review on PR #1702: parse failures in
// Per PR #1702 review 2026-05-06: parse failures in
// an existing ledger MUST gate CI. The header documents exit
// code 2 for an unparseable ledger; previously this branch only
// returned 2 when the file was missing, so JSONL syntax corruption
Expand Down
8 changes: 4 additions & 4 deletions tools/hygiene/audit-trajectories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ async function axisCadenceWorkflows(ghAvailable: boolean): Promise<void> {
"--json",
"conclusion,createdAt,status",
]);
// Per Codex 2026-05-06 review on PR #1702: surface gh failures
// Per PR #1702 review 2026-05-06: surface gh failures
// explicitly so auth/network breakage doesn't masquerade as
// "no recent runs" cleanliness.
if (r.exitCode !== 0) {
Expand Down Expand Up @@ -268,7 +268,7 @@ async function axisLintWorkflows(ghAvailable: boolean): Promise<void> {
"--json",
"conclusion",
]);
// Per Codex 2026-05-06 review on PR #1702: surface gh failures
// Per PR #1702 review 2026-05-06: surface gh failures
// so a non-zero exit isn't reported as "0 failures" cleanliness.
if (r.exitCode !== 0) {
console.log(
Expand Down Expand Up @@ -360,13 +360,13 @@ async function axisRazorCadence(ghAvailable: boolean): Promise<void> {
"open",
// Default page size is 30; explicit --limit prevents truncation
// when the razor-cadence backlog grows past the default. Per
// Codex 2026-05-06 review on PR #1702.
// PR #1702 review 2026-05-06.
"--limit",
"200",
"--json",
"number,title,createdAt",
]);
// Per Codex 2026-05-06 review on PR #1702: never silently swallow
// Per PR #1702 review 2026-05-06: never silently swallow
// a non-zero exit. A failed gh call would otherwise print "Count: 0"
// -- identical to genuine cleanliness -- masking real cadence skips.
if (r.exitCode !== 0) {
Expand Down
Loading