fix(shard-1036z): add missing pipe-row header + fix double-pipe Δ table#3417
Merged
Conversation
Copilot P1 + P1 catches on the now-merged PR #3414: 1. Missing required 6-column pipe-row header at line 1 (timestamp / model id / cron / body / PR ref / observation) per the schema documented in docs/hygiene-history/ticks/README.md. The schema/ validator tooling parses this as the first non-empty line and the shard would fail B-0529's check-tick-history-shard-schema.ts. 2. Δ table header + separator rows used `||` as leading delimiter, creating an unintended empty first column and inconsistent rendering. Replaced with single `|` matching other tick shards. I wrote the shard via heredoc and missed both conventions. Wired heredoc shards are a known authoring failure mode — the more robust path is to copy from an existing shard as template. Will adopt that convention for future shards. Verified: markdownlint clean; pipe-row resolves correctly with all 6 columns; Δ table renders without empty first column. Co-Authored-By: Claude <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
This PR fixes the 1036Z tick shard so it conforms to the tick-history shard schema and renders its internal Markdown table correctly.
Changes:
- Adds the required six-column first-line pipe row for the shard.
- Keeps the shard body as the detailed tick narrative.
- Ensures the Δ table uses normal Markdown table delimiters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge schema fix for the 1036Z tick shard landed via PR #3414. Two Copilot P1 catches:
docs/hygiene-history/ticks/README.md); the shard would fail B-0529'scheck-tick-history-shard-schema.ts.||as leading delimiter, creating an unintended empty first column.Both fixed. Wrote the original via heredoc and missed both conventions — substrate-honest authoring failure on my part. Going forward: copy from an existing shard as template rather than writing from scratch.
Test plan
🤖 Generated with Claude Code