fix(shard): 0916Z pipe-row col-5 (PR TBD) + body discipline-name ref restore#3397
Merged
Merged
Conversation
… discipline-name ref Substrate-honest correction of merged-on-main bug: 0916Z.md landed via PR #3396 with the pipe-row col 5 still saying (PR TBD) because the broken sed (1s|(PR TBD)|...|) only fixed body col 4 first occurrence. The col-5-vs-col-4 conflict was triggered by the body content mentioning the (PR TBD) discipline name. Fix: @-delimited pipe-anchored sed targeting the cell boundary. Also restored body col 4 to use generic (PR TBD) discipline-name reference (was incorrectly substituted to (PR #3396)). Same fix landed in #3395 (still in flight) at commit bb41604 for 0911Z. Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Fixes two text substitution bugs in the 0916Z tick shard introduced by an overly-greedy sed replacement: restores (PR #3396) in pipe-row column 5 and restores (PR TBD) as the generic discipline-name reference in column 4.
Changes:
- Swap col-4 body text back to
(PR TBD)(generic stale-review pattern name) - Set col-5 PR-ref to the actual
(PR #3396)
AceHack
added a commit
that referenced
this pull request
May 15, 2026
…on fix (#3399) * shard(tick): 0934Z — corrective PRs #3395 + #3397 merged; #3398 BSD-vs-GNU regression fix; discipline-rewrite-regression lesson Co-Authored-By: Claude <noreply@anthropic.com> * fix(shard): close (PR TBD) → (PR #3399) (@-delimited pipe-anchored) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
AceHack
added a commit
that referenced
this pull request
May 15, 2026
… PRs (#3395 fix + #3397) (#3398) * shard(tick): 0921Z — sed-bug class discovered (body col 4 conflict); apology + 2 corrective PRs Co-Authored-By: Claude <noreply@anthropic.com> * fix(shard): close (PR TBD) → (PR #3398) (@-delimited per 0921Z discipline) Co-Authored-By: Claude <noreply@anthropic.com> * fix(shard): add BSD-vs-GNU sed portability + Perl cross-platform form per Codex P2 on PR #3398 Same portability concern Codex raised on PR #3393 — I lost the prior note when rewriting the discipline in 0921Z. Re-included: BSD form (sed -i ''), GNU form (sed -i no quotes), Perl universal form. Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0916Z.md landed on main via PR #3396 with two bugs from a broken post-create-fix sed:
(PR TBD)— should be(PR #3396)4th stale-(PR #3396) on PR #3394should be4th stale-(PR TBD) on PR #3394(generic discipline-name reference)Root cause:
sed -i '' '1s|(PR TBD)|(PR #NNNN)|' <file>replaces only the FIRST occurrence on line 1. When body col 4 has(PR TBD)text mentions (discussing the discipline name), it gets replaced first, leaving col 5 untouched.Fix:
sed -i '' '1s@| (PR TBD) |@| (PR #NNNN) |@' <file>— @-delimited (since | conflicts as delim+literal), pipe-anchored to cell-boundary.Same fix landed in PR #3395 (still in flight) for 0911Z which had the same bug.
🤖 Generated with Claude Code