Skip to content

fix: 4 Copilot threads on PRs #3156 + #3161 (post-merge follow-up)#3166

Merged
AceHack merged 1 commit into
mainfrom
fix/copilot-4-threads-on-pr3156-pr3161-followup-2026-05-14
May 14, 2026
Merged

fix: 4 Copilot threads on PRs #3156 + #3161 (post-merge follow-up)#3166
AceHack merged 1 commit into
mainfrom
fix/copilot-4-threads-on-pr3156-pr3161-followup-2026-05-14

Conversation

@AceHack
Copy link
Copy Markdown
Member

@AceHack AceHack commented May 14, 2026

Summary

Both #3156 (B-0506 row) and #3161 (1822Z shard) auto-merged before Copilot's review threads could be addressed — autoMerge is armed once CI passes, and Copilot's findings were advisory (not `required_conversation_resolution`). Fixing the 4 findings on main as a small follow-up.

Findings + fixes

PR #3156 (B-0506 `docs/backlog/P3/B-0506-stale-worktree-prune-cadence-mechanization-2026-05-14.md`):

  1. Frontmatter `type: feature` vs body "P3 friction-reducer" — changed `type: feature` → `type: chore` (matches the `chore(backlog)` commit prefix; resolves semantic mismatch)
  2. `Composes with` listed bare filenames (`claim-acquire-before-worktree-work.md`, `encoding-rules-without-mechanizing.md`) — added full `.claude/rules/` paths for unambiguous nav

PR #3161 (`docs/hygiene-history/ticks/2026/05/14/1822Z.md`):

  1. "~17/47" → "8/47 (~17%)" — internal-consistency fix (8 rules audited, not 17; aligns with lines 41 + 62)
  2. "per per-tick" → "per-tick" — grammar nit

Why this PR

The auto-merge happened ~3 minutes after the prior PRs' CI passed, before I could see Copilot's threads. Substrate-honest follow-up is to fix on main rather than leave the findings unaddressed.

The 4 threads on the merged PRs will be resolved via GraphQL `resolveReviewThread` after this lands.

Test plan

  • B-0506 frontmatter aligns with commit prefix
  • B-0506 Composes-with paths are full + navigable
  • 1822Z shard count is internally consistent
  • Grammar nit fixed

🤖 Generated with Claude Code

Both prior PRs auto-merged before Copilot threads could be addressed (advisory,
not required_conversation_resolution). Fixing the 4 findings on main:

PR #3156 (B-0506 row):
- Frontmatter type: feature → type: chore (matches "chore(backlog)" commit prefix
  and avoids the friction-reducer-vs-feature semantic mismatch Copilot flagged)
- Composes-with: bare filenames → full .claude/rules/ paths (unambiguous nav)

PR #3161 (1822Z shard):
- "~17/47" → "8/47 (~17%)" — internal consistency with lines 41 + 62 (8 rules audited)
- "per per-tick" → "per-tick" (grammar nit)

All 4 threads will be resolved via GraphQL resolveReviewThread mutation after this lands.

Co-Authored-By: Claude <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 14, 2026 18:33
@AceHack AceHack enabled auto-merge (squash) May 14, 2026 18:33
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Small follow-up that addresses 4 Copilot review findings on the already-merged PRs #3156 and #3161, applied directly on main.

Changes:

  • Fix B-0506 frontmatter type from feature to chore and expand bare rule filenames to full .claude/rules/ paths in the Composes-with list.
  • Correct "~17/47" to "8/47 (~17%)" for internal consistency and fix a "per per-tick" grammar nit in the 1822Z tick shard.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docs/backlog/P3/B-0506-stale-worktree-prune-cadence-mechanization-2026-05-14.md Frontmatter type semantic fix; full paths for Composes-with rule references.
docs/hygiene-history/ticks/2026/05/14/1822Z.md Numeric consistency fix (8/47, ~17%) and grammar fix ("per-tick").

@AceHack AceHack merged commit 6427061 into main May 14, 2026
25 of 26 checks passed
@AceHack AceHack deleted the fix/copilot-4-threads-on-pr3156-pr3161-followup-2026-05-14 branch May 14, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants