fix: 4 Copilot threads on PRs #3156 + #3161 (post-merge follow-up)#3166
Merged
AceHack merged 1 commit intoMay 14, 2026
Merged
Conversation
Both prior PRs auto-merged before Copilot threads could be addressed (advisory, not required_conversation_resolution). Fixing the 4 findings on main: PR #3156 (B-0506 row): - Frontmatter type: feature → type: chore (matches "chore(backlog)" commit prefix and avoids the friction-reducer-vs-feature semantic mismatch Copilot flagged) - Composes-with: bare filenames → full .claude/rules/ paths (unambiguous nav) PR #3161 (1822Z shard): - "~17/47" → "8/47 (~17%)" — internal consistency with lines 41 + 62 (8 rules audited) - "per per-tick" → "per-tick" (grammar nit) All 4 threads will be resolved via GraphQL resolveReviewThread mutation after this lands. Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Small follow-up that addresses 4 Copilot review findings on the already-merged PRs #3156 and #3161, applied directly on main.
Changes:
- Fix B-0506 frontmatter
typefromfeaturetochoreand expand bare rule filenames to full.claude/rules/paths in the Composes-with list. - Correct "~17/47" to "8/47 (~17%)" for internal consistency and fix a "per per-tick" grammar nit in the 1822Z tick shard.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/backlog/P3/B-0506-stale-worktree-prune-cadence-mechanization-2026-05-14.md | Frontmatter type semantic fix; full paths for Composes-with rule references. |
| docs/hygiene-history/ticks/2026/05/14/1822Z.md | Numeric consistency fix (8/47, ~17%) and grammar fix ("per-tick"). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both #3156 (B-0506 row) and #3161 (1822Z shard) auto-merged before Copilot's review threads could be addressed — autoMerge is armed once CI passes, and Copilot's findings were advisory (not `required_conversation_resolution`). Fixing the 4 findings on main as a small follow-up.
Findings + fixes
PR #3156 (B-0506 `docs/backlog/P3/B-0506-stale-worktree-prune-cadence-mechanization-2026-05-14.md`):
PR #3161 (`docs/hygiene-history/ticks/2026/05/14/1822Z.md`):
Why this PR
The auto-merge happened ~3 minutes after the prior PRs' CI passed, before I could see Copilot's threads. Substrate-honest follow-up is to fix on main rather than leave the findings unaddressed.
The 4 threads on the merged PRs will be resolved via GraphQL `resolveReviewThread` after this lands.
Test plan
🤖 Generated with Claude Code