fix(policy): add docs/pr-discussions/** to history-surface allowlist#3164
Merged
Conversation
docs/AGENT-BEST-PRACTICES.696-697 and tools/pr-preservation/archive-pr.tsmd both use docs/pr-discussions/ as the output directory for PR archives, but .github/copilot-instructions.md only listed docs/pr-preservation/** in its history-surfaces allowlist. This drift would cause Copilot reviews to incorrectly flag attribution in pr-discussions archives as policy violations. Add docs/pr-discussions/** in both occurrences (main list and surface-category quick-reference) to match the authoritative list in AGENT-BEST-PRACTICES.md. Closes thread PRRT_kwDOSF9kNM6CJxHZ on PR #3157. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates Copilot review policy guidance so docs/pr-discussions/** is treated as a history surface where attribution should be preserved.
Changes:
- Adds
docs/pr-discussions/**to the main history-surface allowlist. - Adds the same path to the surface-category quick reference.
Comments suppressed due to low confidence (1)
.github/copilot-instructions.md:396
- P1: The quick-reference list remains drifted from
docs/AGENT-BEST-PRACTICES.md: the authoritative history surfaces includedocs/lost-substrate/**,docs/active-trajectory.md, anddocs/launch/**in addition to the PR archive paths. Mirror those entries here too, otherwise this shortcut still gives reviewers incomplete policy guidance.
`docs/pr-preservation/**`, `docs/pr-discussions/**`,
`docs/hygiene-history/**`,
AceHack
commented
May 14, 2026
Member
Author
AceHack
left a comment
AceHack
left a comment
There was a problem hiding this comment.
Lior review: Atomic change. Parity established for policy list. Proceed.
…TICES Add missing history-surface entries to both allowlist sections in .github/copilot-instructions.md to match the authoritative list in docs/AGENT-BEST-PRACTICES.md lines 694-714: - docs/lost-substrate/** (recovery/redundancy artifacts) - docs/active-trajectory.md (load-state + who-said-what provenance) - docs/launch/** (named-team positioning + IP-respect attribution) Fixes both line 331 (full list) and line 395 (quick-reference) per Copilot P1 review thread on PR #3164. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the policy drift flagged in PR #3157 (thread PRRT_kwDOSF9kNM6CJxHZ).
docs/AGENT-BEST-PRACTICES.696-697 andtools/pr-preservation/archive-pr.tsboth usedocs/pr-discussions/as the PR archive output directory, but.github/copilot-instructions.mdonly listeddocs/pr-preservation/**in its history-surfaces allowlist. This drift would cause Copilot reviews to incorrectly flag attribution in pr-discussions archives as policy violations.mdChanges
docs/pr-discussions/**to the main history-surfaces list (alongsidedocs/pr-preservation/**)docs/pr-discussions/**to the surface-category quick-reference sectionBoth entries now match
docs/AGENT-BEST-PRACTICES.696-697 (the authoritative source).mdResolves: thread PRRT_kwDOSF9kNM6CJxHZ on #3157