Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core: TemporalCoordinationDetection.crossCorrelation — 2nd Amara graduation (11th ferry, Aaron-designed) #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
core: TemporalCoordinationDetection.crossCorrelation — 2nd Amara graduation (11th ferry, Aaron-designed) #297
Changes from all commits
5b3658cFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crossCorrelationProfilecallscrossCorrelation xs ys taufor every lag, andcrossCorrelationimmediately doesSeq.toArrayon both inputs each time. For lazy, side-effecting, or single-passseqsources (for example stream-backed generators), this can yield inconsistent/empty results across lags because each lag re-enumerates the source; even for replayable sequences it performs avoidable full rescans per lag. Materializingxs/ysonce insidecrossCorrelationProfile(or adding an array-based helper) avoids this correctness and performance pitfall.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.