fix(B-0191): tsc noUncheckedIndexedAccess + BACKLOG.md index drift#2253
Merged
fix(B-0191): tsc noUncheckedIndexedAccess + BACKLOG.md index drift#2253
Conversation
Follow-up to #2250 — the squash-merge window closed before these non-required CI fixes landed on the branch. - Replace entries[0]/[1]/[2] with entries[0]!/[1]!/[2]! and const [entry] destructuring with const entry = ...[0]! to satisfy noUncheckedIndexedAccess (TS2532 / TS18048) - Regenerate docs/BACKLOG.md so B-0076 (status: closed since commit 0a5af0c) renders as [x] rather than [ ] Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
This PR is a follow-up CI hygiene fix: it updates TypeScript unit tests to satisfy noUncheckedIndexedAccess and regenerates the auto-generated backlog index so closed items render correctly.
Changes:
- Adjusted
check-orchestrator-stateunit tests to use non-null assertions on indexed array access undernoUncheckedIndexedAccess. - Regenerated
docs/BACKLOG.mdso B-0076 renders as closed ([x]) based on its per-rowstatus: closed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tools/orchestrator-checks/check-orchestrator-state.test.ts | Updates test indexing/destructuring to satisfy noUncheckedIndexedAccess. |
| docs/BACKLOG.md | Regenerated backlog index; fixes checkbox rendering for a closed row. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2250 — the squash-merge window closed before these non-required CI fixes landed on the branch.
TS2532/TS18048incheck-orchestrator-state.test.ts: replaceentries[0]/[1]/[2]with[0]!/[1]!/[2]!andconst [entry] = ...destructuring withconst entry = ...[0]!to satisfynoUncheckedIndexedAccessdocs/BACKLOG.mdso B-0076 (status: closedsince commit0a5af0c3) renders as[x]rather than[ ]Test plan
bun --bun tsc --noEmit -p tsconfig.json→ 0 errorsbun test tools/orchestrator-checks/→ 12 pass / 0 failbun tools/backlog/generate-index.ts --check→ okoperative-authorization: aaron 2026-05-04: "it**, not just the output. Grinding through failures + recoveries"
🤖 Generated with Claude Code