Conversation
There was a problem hiding this comment.
Pull request overview
Updates the README quick-tour snippets to use the correct public namespace (Zeta.Core) so the shown F# and C# examples match the actual source declarations.
Changes:
- README F# snippet:
open Dbsp.Core→open Zeta.Core - README C# snippet:
using Dbsp.Core;→using Zeta.Core;
Amara 2026-04-23 Zeta-semantics report (PR #211) P2 finding: README quick-tour uses `open Dbsp.Core` + `using Dbsp.Core;` but actual source files declare `namespace Zeta.Core` (per `src/Core/Circuit.fs:86` and others). Code-as-shown won't compile for any reader copying the snippet. Fixed both F# and C# snippets (lines 93, 116) to use `Zeta.Core`. Verified: no other live `Dbsp.Core` references in tracked docs — the remaining mentions are (a) GOVERNANCE.md:648 historical lesson about the rename, (b) persona notebooks under `memory/persona/**` (historical), (c) `docs/ROUND-HISTORY.md:757` historical. All exempt per the history-file exemption landed in PR #210. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…ync snippet Address two review threads on PR #218: 1. PRRT_kwDOSF9kNM59QS9U: sweep stragglers. `openspec/README.md`, `openspec/specs/durability-modes/profiles/fsharp.md`, and `openspec/specs/retraction-safe-recursion/profiles/fsharp.md` still named the old `Dbsp.Core` namespace; rename to `Zeta.Core` to match the F# source (src/Core/*.fs `namespace Zeta.Core`). 2. PRRT_kwDOSF9kNM59QS9g: quick-tour F# snippet used `do!` at top level, which is only valid inside a computation expression. Wrap the `orders.Send` + `StepAsync` + print block in `async { ... }` with `circuit.StepAsync () |> Async.AwaitTask` (StepAsync returns Task) and terminate with `|> Async.RunSynchronously`, so the snippet reads as valid F# and is copy-pasteable for onboarding. docs/copilot-wins.md, docs/aurora/2026-04-23-amara-zset-semantics-operator-algebra.md, docs/ROUND-HISTORY.md, and memory/ notebooks retain `Dbsp.Core` as historical references (history-exempt per docs-as-current-state rule). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
AceHack
force-pushed
the
fix/readme-namespace-dbsp-to-zeta-amara-p2
branch
from
4f14e73 to
9209677
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Comment on lines
92
to
+113
| @@ -103,17 +103,20 @@ let totals = | |||
|
|
|||
| let view = circuit.Output(circuit.IntegrateZSet totals) | |||
|
|
|||
| orders.Send(ZSet.ofKeys [ "alice", 100L ; "bob", 50L ]) | |||
| do! circuit.StepAsync () | |||
| async { | |||
| orders.Send(ZSet.ofKeys [ "alice", 100L ; "bob", 50L ]) | |||
| do! circuit.StepAsync () |> Async.AwaitTask | |||
|
|
|||
| for e in view.Current do | |||
| printfn "%A -> weight %d" e.Key e.Weight | |||
| for e in view.Current do | |||
| printfn "%A -> weight %d" e.Key e.Weight | |||
| } | |||
| |> Async.RunSynchronously | |||
There was a problem hiding this comment.
P1: The PR title/description claims the change is just 2 snippet lines in README.md, but this hunk also restructures the F# snippet to wrap it in an async { ... } block and the PR also edits multiple openspec/** files. Please update the PR title/description (and/or verification section) to reflect the full set of touched docs so reviewers don’t miss scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Amara's 2026-04-23 Zeta-semantics report (PR #211) flagged a P2 finding: README quick-tour snippets use
Dbsp.Corebut actual source files declarenamespace Zeta.Core. Code-as-shown won't compile.What landed
README.md— 2 snippet lines (F#open+ C#using).Verification
No other live
Dbsp.Corereferences in tracked docs. Remaining mentions all in history-exempt surfaces (GOVERNANCE.md rename-history lesson, persona notebooks, ROUND-HISTORY).Test plan
dotnet fsion the F# snippet would now succeed (snippet-level verification; not part of CI)🤖 Generated with Claude Code