Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(B-0191): wire verify-branch PreToolUse hook into settings.json #2151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(B-0191): wire verify-branch PreToolUse hook into settings.json #2151
Changes from all commits
8eb0c1ca80d9acFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hookskeyThis change introduces a second top-level
hooksobject, so the file now defineshooksat both the beginning and end of the JSON. Duplicate keys are not interoperable JSON, and common parsers (includingJSON.parse) keep only the last occurrence, which can silently discard the newly added PreToolUse wrapper block and make hook behavior depend on parser quirks.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entry invokes
tools/orchestrator-checks/verify-branch.tsdirectly instead of the newverify-branch-pretooluse.tsadapter.verify-branch.tsreports mismatches via exit code1, but PreToolUse enforcement requires either exit2or ahookSpecificOutput.permissionDecision: "deny"payload; otherwise the tool call continues. As written, a branch mismatch can surface only as a hook error while still allowing the commit.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.