fix: remove unused imports in filter-gate log tests#2111
Merged
Conversation
The squash merge of PR #2110 landed the original commit before the tsc fix commit, leaving 6 unused imports that fail the lint (tsc tools) CI check (noUnusedLocals). Removes afterEach, existsSync, mkdirSync, join, Decision, and recordEntry. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Removes now-unused imports from tools/alignment/filter_gate_log.test.ts so the file passes the repo’s TypeScript compile-time unused checks (noUnusedLocals/noUnusedParameters) and unblocks the CI tsc gate for tools.
Changes:
- Drop unused
bun:testimport (afterEach) from the test file. - Drop unused Node imports (
existsSync,mkdirSync,join) from the test file. - Drop unused type/value imports (
Decision,recordEntry) from./filter_gate_log.tsin the test file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/alignment/filter_gate_log.test.tsthat fail thelint (tsc tools)CI check (noUnusedLocals/noUnusedParameters).Test plan
bun x tsc --noEmit— 0 errorsbun test tools/alignment/filter_gate_log.test.ts— 33 pass, 0 faildotnet build -c Release— 0 warnings, 0 errors🤖 Generated with Claude Code