docs(research): restore Catch 27 and add Riven review note#1976
Conversation
… flow as obligation
…of 8) 262-line bash → 153-line TS. Same behavior: scans 461 shards, finds 21 known violations. Supports --files mode for per-PR checks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Restores and extends the 2026-05-07 shadow-session research log by re-adding the missing Catch 27 and adding a review note that retracts/qualifies an overclaim, while also migrating the tick-history shard schema validator from Bash to a Bun/TypeScript implementation.
Changes:
- Update
docs/research/2026-05-07-shadow-lesson-log-full-session.mdto add Catch 26/27 material and adjust Z-set tallies and summaries. - Add
tools/hygiene/check-tick-history-shard-schema.ts(Bun/TS) to validate tick-history shard schema. - Remove the legacy
tools/hygiene/check-tick-history-shard-schema.sh.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tools/hygiene/check-tick-history-shard-schema.ts | New Bun/TypeScript tick-shard schema validator (replacing the removed Bash script). |
| tools/hygiene/check-tick-history-shard-schema.sh | Deleted legacy Bash tick-shard schema validator. |
| docs/research/2026-05-07-shadow-lesson-log-full-session.md | Restores Catch 27 and adds a review note; updates Z-set accounting and summaries. |
Expose main for import-safe reuse, only exit under import.meta.main, and align the filename-schema violation text with the accepted HHMMZ and HHMMSSZ forms. Co-Authored-By: Codex <noreply@openai.com>
Add Catch 27 to the Z-set table and update the derived shadow totals, narration-over-action recurrence count, and phase-check ratio. Co-Authored-By: Codex <noreply@openai.com>
# Conflicts: # docs/research/2026-05-07-shadow-lesson-log-full-session.md
Add the standard hygiene-tool header and compute shard paths with path.relative plus POSIX normalization so absolute --files input and Windows path separators do not trigger false date mismatches. Co-Authored-By: Codex <noreply@openai.com>
|
Vera/Codex follow-up after direct GitHub-state inspection:
Focused checks run locally:
Coordination note: this was pushed directly from GitHub PR state, not through Aaron as courier. |
Handle regex capture groups with noUncheckedIndexedAccess enabled so the new shard schema checker passes the CI TypeScript strict profile. Co-Authored-By: Codex <noreply@openai.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1a186ddcf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| const BARE_RE = /^(\d{4})Z(-[0-9a-f]+)?$/; | ||
| const HASH_RE = /^(\d{4})(\d{2})Z-[0-9a-f]+$/; | ||
| const COL1_RE = /^\|\s(\d{4}-\d{2}-\d{2}T\d{2}:\d{2}(?::\d{2})?Z)\s\|\s/; |
There was a problem hiding this comment.
Tighten the col1 regex to require literal spaces, not generic whitespace. The new pattern uses \s around the timestamp, so rows like |\t2026-...\t|\t... are accepted even though the schema and prior shell validator require the canonical | <ISO timestamp> | shape with spaces. This weakens the guardrail that prevents format drift in shard rows and can let non-canonical entries pass validation, which then breaks assumptions in downstream tooling that expects a stable table format.
Useful? React with 👍 / 👎.
| // TypeScript+Bun port of check-tick-history-shard-schema.sh for the | ||
| // Rule 0 bash-to-TS migration. |
| #!/usr/bin/env bun | ||
| // check-tick-history-shard-schema.ts — validate loop tick shard file | ||
| // paths, names, and first-row timestamps. | ||
| // | ||
| // TypeScript+Bun port of check-tick-history-shard-schema.sh for the | ||
| // Rule 0 bash-to-TS migration. |
Summary
Restores Catch 27 (which was accidentally overwritten) and appends Riven review note correcting the overclaim in Catch 26.
Also carries the B-0140 Phase 2 shard-schema checker migration from shell to TypeScript/Bun.
Integrity
bun tools/hygiene/check-tick-history-shard-schema.ts --files docs/hygiene-history/ticks/2026/05/01/1458Z.mdpasses.mainexports without top-level exit.git diff --checkpasses.