-
Notifications
You must be signed in to change notification settings - Fork 1
archive: preserve PR 1764 review output #1765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
docs/history/pr-reviews/PR-1764-archive-preserve-pr-1763-review-output.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| # PR #1764 -- archive: preserve PR 1763 review output | ||
|
|
||
| > Git-native PR-review archive. Generated by | ||
| > `tools/archive/archive-pr-reviews.ts`. Schema version: 1. | ||
|
AceHack marked this conversation as resolved.
|
||
| > | ||
| > Wall-clock generation timestamp deliberately omitted from the | ||
| > rendered file so deterministic re-runs against unchanged | ||
| > upstream substrate produce byte-identical content (manifest | ||
| > `fetched_at` carries the audit timestamp instead). | ||
|
|
||
| ## Metadata | ||
|
|
||
| | Field | Value | | ||
| |---|---| | ||
| | Number | 1764 | | ||
| | Title | archive: preserve PR 1763 review output | | ||
| | Author | `AceHack` (human) | | ||
| | State | MERGED | | ||
| | Created at | 2026-05-07T02:16:00Z | | ||
| | Merged at | 2026-05-07T02:17:24Z | | ||
| | Merge commit SHA | `38461ab137fdcfd5c4a4c26c9205d65f40664488` | | ||
| | Branch | `claim/archive-pr-1763-review-substrate` | | ||
| | Base branch | `main` | | ||
| | URL | https://github.com/Lucent-Financial-Group/Zeta/pull/1764 | | ||
| | Changed files | 2 | | ||
| | Additions / deletions | +61 / -0 | | ||
|
|
||
| ## Description | ||
|
|
||
| ## Summary | ||
| - Preserves the deterministic PR #1763 review archive generated by the post-merge archive workflow. | ||
| - Adds the PR #1763 manifest entry with merge commit SHA `3889d419db749a1d25cfdd34644a46f7640d7aee`. | ||
| - Releases the temporary git-native claim in this branch. | ||
|
|
||
| ## Checks | ||
| - `npx markdownlint-cli2 docs/history/pr-reviews/PR-1763-archive-preserve-pr-1762-review-output.md` | ||
| - `git diff --check origin/main...HEAD` | ||
|
|
||
| ## Notes | ||
| PR #1763 had no review threads; this routes the workflow-generated archive through PR review because direct pushes to `main` are guarded by repository rules. | ||
|
|
||
| ## Outcome | ||
|
|
||
| | Field | Value | | ||
| |---|---| | ||
| | Merged | true | | ||
| | Re-reviewed post-fix | false | | ||
| | Total threads | 0 | | ||
| | Resolved threads | 0 | | ||
| | Unresolved threads | 0 | | ||
| | Total review comments | 0 | | ||
| | Total fix commits (touching thread paths) | 0 | | ||
|
|
||
| ## Review threads | ||
|
|
||
| (no review threads on this PR) | ||
|
|
||
| ## Fix commits (touching thread paths) | ||
|
|
||
| (no commits in this PR touched files anchored by review threads) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.