docs: address launchd checklist review comments#1761
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Tier 1 launchd hot-swap operations checklist to be more portable and role-referenced, with a focus on safer/clearer launchctl inspection and reload steps for the com.zeta.riven-loop agent.
Changes:
- Rewrites current-state prose to role-refs and removes hard-coded user/home paths in favor of
$HOMEandZETA_RIVEN_LOOP_*variables. - Switches live job inspection from
launchctl listtolaunchctl printand updates restart/reload guidance to domain-scopedbootout/bootstrap/kickstart. - Standardizes log and backup paths via exported shell variables.
Comment on lines
+25
to
39
| Do not edit the plist if the script path is unchanged. All snippets below assume | ||
| these shell variables: | ||
|
|
||
| ```bash | ||
| export ZETA_RIVEN_LOOP_HOME="${ZETA_RIVEN_LOOP_HOME:-$HOME/.local/share/zeta-riven-loop}" | ||
| export ZETA_RIVEN_LOOP_REPO="$ZETA_RIVEN_LOOP_HOME/Zeta" | ||
| export ZETA_RIVEN_LOOP_PLIST="$HOME/Library/LaunchAgents/com.zeta.riven-loop.plist" | ||
| export ZETA_RIVEN_LOOP_LOG_DIR="$HOME/Library/Logs/zeta-riven-loop" | ||
| ``` | ||
|
|
||
| The plist should already point at: | ||
|
|
||
| ```text | ||
| /Users/acehack/.local/share/zeta-riven-loop/Zeta/.cursor/bin/riven-loop-tick.ts | ||
| $ZETA_RIVEN_LOOP_REPO/.cursor/bin/riven-loop-tick.ts | ||
| ``` |
| ```bash | ||
| launchctl stop com.zeta.riven-loop | ||
| launchctl start com.zeta.riven-loop | ||
| launchctl bootout gui/$(id -u) "$ZETA_RIVEN_LOOP_PLIST" 2>/dev/null || true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$HOME/ZETA_RIVEN_LOOP_*variables, useslaunchctl printfor live argument inspection, and swaps stop/start fallback for domain-scopedbootout/bootstrap/kickstart.Checks
npx markdownlint-cli2 docs/operations/riven-tier1-launchd-hot-swap-checklist.md docs/claims/launchd-checklist-review-followup.mdnpx markdownlint-cli2 docs/operations/riven-tier1-launchd-hot-swap-checklist.mdgit diff --check origin/main...HEADrg -n "Riven|Aaron|/Users/acehack|ProgramArguments|launchctl list|launchctl stop|launchctl start" docs/operations/riven-tier1-launchd-hot-swap-checklist.md(no matches)