Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs(research): registry rows for the 5 in-CI TLA+ specs (closes A4 external-citation-fidelity gap) #1393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
docs(research): registry rows for the 5 in-CI TLA+ specs (closes A4 external-citation-fidelity gap) #1393
Changes from all commits
22625faFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The section asserts there are only 5 TLA+ specs running in CI, but
tests/Tests.FSharp/Formal/Tlc.Runner.Tests.fsin the same commit also runs TLC forInfoTheoreticSharder,RecursiveCountingLFP, andFeatureFlagsResolution(plusSmokeCheck). Because those CI-validated specs are omitted from this registry update, the stated closure of the external-fidelity gap is incomplete and drift audits will miss active CI specs.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This row links CI execution to
tests/Tests.FSharp/TlcRunnerTests.fs, but that file does not exist in this commit; the runner lives attests/Tests.FSharp/Formal/Tlc.Runner.Tests.fs. Keeping a non-existent path here breaks the audit trail this registry is supposed to provide, because reviewers cannot follow the documented evidence chain from spec rows to the actual CI gate.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This target names
TransactionZ1Op.fs, but no such file exists in this commit; theTransactionZ1Opimplementation is insrc/Core/Transaction.fs. Referencing a non-existent source file makes the spec-to-implementation mapping unverifiable, which undermines the purpose of this internal-correctness row.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.