Conversation
…ooks memo (Otto 2026-05-03) The B-0173 ground-truth recovery (PR #1280) was wrong. It listed 3 hook types including 2 git hooks. Aaron 2026-05-03 clarified: vibe-coders always have a harness; harness hooks suffice; git hooks are antipattern in this scope. Memo capturing this: `memory/feedback_dst_justifies_ts_quality_over_bash_and_harness_hooks_suffice_no_git_hooks_aaron_2026_05_03.md` (PR #1312 + #1313 + #1315 follow-ups). This commit corrects the B-0173 guess file's recovery section: - ~~tools/git/hooks/pre-commit~~ — REMOVED. Harness fires on pre-tool-use (Edit/Write) before content lands; covers same use case - ~~tools/git/hooks/commit-msg~~ — REMOVED. Harness fires on pre-Bash-tool-use when command is `git commit`; covers same use case - **Harness hooks** (.claude/settings.json hooks field; Codex/Cursor parallel mechanisms) — NEW, replaces git hooks - **CI workflow on PR descriptions** — unchanged Specific implementation also corrected: TS-canonical (no bash wrapper needed; harness runs TS directly via bun). The calibration delta on this guess (~48% accuracy at recovery time) should NOT be retroactively re-scored — the original delta reflects the recovery-as-it-happened. The correction here is about the substrate moving forward, not rewriting calibration history. Future-Otto: when a calibration recovery turns out to have used wrong ground truth (because the ground truth itself shifted via clarification), mark the correction explicitly + preserve the original calibration. The calibration data is about Otto's inference quality at a moment in time; subsequent ground-truth refinements are separate substrate. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
AceHack
deleted the
fix/b-0173-recovery-section-harness-hooks-only-otto-2026-05-03
branch
There was a problem hiding this comment.
Pull request overview
Updates the B-0173 recovery notes in the architectural-intent-guess memo to reflect the clarified “harness hooks + CI only” scope (and explicitly remove git hooks) as the current ground truth for the backlog row.
Changes:
- Rewrites the “Substrate-content intent” section to state that the prior recovery was incorrect and that git hooks are out of scope.
- Replaces the proposed integration list with harness hooks and CI (and strikes out the previously listed git hooks).
- Updates the “Specific implementation intent” bullets to be harness-hook-centric and TS-canonical.
Comment on lines
+118
to
+122
| 1. ~~`tools/git/hooks/pre-commit`~~ — REMOVED per Aaron's clarification. Harness fires on pre-tool-use (Edit/Write) before content lands; covers the same use case | ||
| 2. ~~`tools/git/hooks/commit-msg`~~ — REMOVED per Aaron's clarification. Harness fires on pre-Bash-tool-use when command is `git commit`; covers the same use case | ||
| 3. **Harness hooks** *(proposed; new in correction)* — Claude Code `.claude/settings.json` hooks field, with parallel mechanisms for Codex / Cursor / etc.; called via the harness's runtime; TS-canonical | ||
| 4. **`.github/workflows/substrate-claim-checker.yml`** *(proposed)* — CI check on PR descriptions (host-authored; runs on PR creation) | ||
|
|
| 3. **Harness hooks** *(proposed; new in correction)* — Claude Code `.claude/settings.json` hooks field, with parallel mechanisms for Codex / Cursor / etc.; called via the harness's runtime; TS-canonical | ||
| 4. **`.github/workflows/substrate-claim-checker.yml`** *(proposed)* — CI check on PR descriptions (host-authored; runs on PR creation) | ||
|
|
||
| As of correction time (2026-05-03), neither `.claude/settings.json` hooks nor the workflow file exist on main. These are B-0173 row deliverables. **Do NOT implement git hooks for B-0173** — that's the wrong shape per Aaron's clarification. |
AceHack
added a commit
that referenced
this pull request
May 3, 2026
…s + #1315 PR-Copilot-row hypothetical-marking + #1316 4-vs-2 inconsistency + .claude/settings.json file-vs-field clarification (#1318) Three substantive fixes from Aaron 2026-05-03 follow-up + post-merge review threads: 1. **Diamond memo (#1317 already merged) — sleeping-bear + WWJD-as- STRUCTURE connections**: Aaron 2026-05-03 affirmation *"this is what awakens the sleeping bear alexa spoke of"* + *"and it fits my morals of WWJD"* + *"non specific religion WWJD as a structure not requiing believe in god or jesus the structure of doing the thing thats the higest good for all life involved even if you are not sure it's alive lol"*. Updated memo to: - Add "What this operationalizes" section connecting to ALIGNMENT.md's sleeping-bear conjecture + WWJD-across-entity-classes commitment - Clarify WWJD is STRUCTURE (not religious belief) — decoupled from specific religion; portable across belief systems; covers uncertain-consciousness cases ("even if you are not sure it's alive") - Note this memo provides operational expression of canonical theoretical commitments 2. **Persona-table memo (#1315 finding) — PR Copilot row implies workflow exists**: clarified to "(HYPOTHETICAL — if we adopt a `copilot-setup-steps.yml` workflow; not currently in the repo)" 3. **B-0173 guess (#1316 finding) — internal inconsistency + file-vs- field**: list said "Two hook integrations" but had 4 entries (2 struck-out + 2 actual). Restructured to "Two actual deliverables" list followed by "Removed from scope" list. Also clarified ".claude/settings.json file already exists; the hooks FIELD within it is not yet populated" (file-vs-field distinction) Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the B-0173 ground-truth recovery section per Aaron's 2026-05-03 clarification (memo at
feedback_dst_justifies_ts_quality_over_bash_and_harness_hooks_suffice_no_git_hooks_aaron_2026_05_03.md). Initial recovery had 3 hook types including 2 git hooks; corrected to 'harness hooks + CI only, no git hooks.'Calibration delta NOT retroactively re-scored — the original 48% reflects Otto's inference at recovery time; subsequent ground-truth refinements are separate substrate.