hygiene(tick-history): 2026-05-01T20:47Z — closed task #355 fixtures-gap#1159
Merged
hygiene(tick-history): 2026-05-01T20:47Z — closed task #355 fixtures-gap#1159
Conversation
…gap (PR #1158) Speculative-work tick — session PRs all wait-ci, no actionable threads. Picked known-gap: task #355 promised "with fixtures" but the fixture set under tools/github/fixtures/ landed without a test runner. PR #1158: 28 tests / 162 expects / 51ms / zero gh spawns. Per-fixture assertions for the 7 canonical scenarios + cross- fixture invariants. Pure-additive export refactor; CLI surface unchanged. Both halves of task #355 deliverable now substrate: - "executable script" — landed in v1 (poll-pr-gate.ts) - "with fixtures" — closed by #1158 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
AceHack
added a commit
that referenced
this pull request
May 1, 2026
… misread as file content (Otto 2026-05-01, 2x-confirmed) Copilot has twice this session (PR #1159 shard 2047Z + PR #1165 shard 2120Z) flagged tick-history shards as failing the schema validator with text matching 'line starts with ` 1 || 2026-...`'. Both shards' actual file content starts with `| 2026-...` cleanly and pass `tools/hygiene/check-tick-history-shard-schema.sh` (verified zero violations both times). Hypothesized mechanism (not load-bearing): Copilot reads the diff's line-number prefix (rendered as ' N | <content>') as if it were file content, producing the false 'leading whitespace + 1 ||' claim. Per Osmani Ratchet Pattern (2x occurrence threshold), this is now substrate. Discipline: 1. When Copilot posts this exact false-positive shape, run the validator first. 2. If validator reports zero violations for the cited shard, resolve thread as outdated/false-positive without code changes. 3. Don't prophylactically edit shard content based on Copilot's claim alone — may mask real future violations by changing content unnecessarily. Two worked examples documented with verbatim Copilot text + verifier output. Composes with BLOCKED-with-green-CI investigation discipline + rebase-decision discipline (both about review-loop hygiene). Memory file + MEMORY.md row pair-edit per index-integrity rule. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
AceHack
added a commit
that referenced
this pull request
May 1, 2026
… misread (Otto 2026-05-01, 2x-confirmed) (#1168) * memory(copilot-false-positive): tick-history schema diff-line-numbers misread as file content (Otto 2026-05-01, 2x-confirmed) Copilot has twice this session (PR #1159 shard 2047Z + PR #1165 shard 2120Z) flagged tick-history shards as failing the schema validator with text matching 'line starts with ` 1 || 2026-...`'. Both shards' actual file content starts with `| 2026-...` cleanly and pass `tools/hygiene/check-tick-history-shard-schema.sh` (verified zero violations both times). Hypothesized mechanism (not load-bearing): Copilot reads the diff's line-number prefix (rendered as ' N | <content>') as if it were file content, producing the false 'leading whitespace + 1 ||' claim. Per Osmani Ratchet Pattern (2x occurrence threshold), this is now substrate. Discipline: 1. When Copilot posts this exact false-positive shape, run the validator first. 2. If validator reports zero violations for the cited shard, resolve thread as outdated/false-positive without code changes. 3. Don't prophylactically edit shard content based on Copilot's claim alone — may mask real future violations by changing content unnecessarily. Two worked examples documented with verbatim Copilot text + verifier output. Composes with BLOCKED-with-green-CI investigation discipline + rebase-decision discipline (both about review-loop hygiene). Memory file + MEMORY.md row pair-edit per index-integrity rule. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(copilot-false-positive memo): correct validator invocation (--files mode) + escape syntax + dangling pointer (3 review threads) Three review findings on PR #1168: (1) Codex P2 — meta-irony: I documented the WRONG validator invocation. The script's --files flag scopes the audit to specific shards (per its own usage docs lines 26-27); my documented 'bash check-tick-history-shard-schema.sh <shard>' runs full-tree audit and requires grep. Fixed: documented the correct '--files <shard>' invocation. Both worked examples updated with corrected expected output ('checked 1 shard files; 0 violations'). The discipline still works — both invocations produce the right answer if the cited shard isn't in violation. But documenting the canonical script API matters for future readers. (2) Copilot P1 — dangling pointer to feedback_harness_engineering_external_anchors_*.md. RESOLVED via rebase: that memo is now on main (PR #1167 merged). The composes_with reference resolves correctly post-rebase. (3) Copilot P1 — backslash escape syntax inconsistency. Wrote '\\|' (two backslashes + pipe) when describing GFM escape behavior. Should be '\|' (single backslash + pipe). Fixed by removing literal example and describing the discipline ('backslash-escapes per GFM-table escaping') rather than showing escape sequences that confuse Markdown rendering. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(MEMORY.md row): use --files for shard-only validator command (Codex P2) Codex P2 on PR #1168: I fixed the validator command in the memo body but FORGOT to apply the same fix to the MEMORY.md index row. The row still said 'bash tools/hygiene/check-tick-history-shard-schema.sh <shard>' (full-tree mode + grep) instead of '--files <shard>' (scoped mode). Same fix applied to the row. Adds inline note clarifying why --files matters (without it, full-tree audit returns unrelated violations). Lesson: when fixing a documented command in two places (memo body + index row), apply the fix to both in the same commit. The pair-edit discipline applies to commands too, not just file additions. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tick-history shard documenting PR #1158 (fixture-driven DST suite for poll-pr-gate.ts).
🤖 Generated with Claude Code