Skip to content

memory(taxonomy v2): consolidate 13 new resolution-classes from drain wave + Aaron meta-class#1081

Open
AceHack wants to merge 1 commit intomainfrom
memory/pr-thread-resolution-class-taxonomy-v2-drain-wave-2026-05-01
Open

memory(taxonomy v2): consolidate 13 new resolution-classes from drain wave + Aaron meta-class#1081
AceHack wants to merge 1 commit intomainfrom
memory/pr-thread-resolution-class-taxonomy-v2-drain-wave-2026-05-01

Conversation

@AceHack
Copy link
Copy Markdown
Member

@AceHack AceHack commented May 1, 2026

Per Deepseek peer-AI's explicit ask + Aaron's just-in-time meta-flag during consolidation. v2 extends v1's 7 classes with 13 new (3 phantom-blocker sub-classes + 11 real-fix sub-classes + 2 new modes), plus diagnostic flowchart and empirical evidence summary.

The peer-AI-structural class (#19) is the meta-class — how new classes get discovered. Aaron's flag during this very consolidation demonstrated the recursion: the consolidation surfaced its own bootstrapping class.

🤖 Generated with Claude Code

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea4714fb2a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

## Composes with

- v1 taxonomy at `~/.claude/projects/<slug>/memory/feedback_pr_thread_resolution_class_taxonomy_2026_04_28.md` (user-scope; promotion-to-in-repo is a separate follow-up).
- B-0129 (`docs/backlog/P3/B-0129-tick-history-schema-prediction-vs-receipt-column-aaron-2026-05-01.md`) — the named-policy that powers class #19 batch-resolution.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Map B-0129 policy to class #20, not #19

This line ties B-0129 to class #19, but class #19 is defined above as the peer-AI structural consolidation meta-class, while deferred policy-based cite-and-resolve is class #20. This misclassification makes the taxonomy internally inconsistent and can send later reviewers to the wrong resolution flow when they follow the “Composes with” guidance.

Useful? React with 👍 / 👎.


- v1 taxonomy at `~/.claude/projects/<slug>/memory/feedback_pr_thread_resolution_class_taxonomy_2026_04_28.md` (user-scope; promotion-to-in-repo is a separate follow-up).
- B-0129 (`docs/backlog/P3/B-0129-tick-history-schema-prediction-vs-receipt-column-aaron-2026-05-01.md`) — the named-policy that powers class #19 batch-resolution.
- B-0130 (`docs/backlog/P2/B-0130-verify-before-state-claim-mechanized-auditor-2026-05-01.md`) — when implemented, would mechanize classes #4 (wildcard-ref auditor), #10 (stale-filename / cross-reference-resolves-to-file auditor proposed for row #8), #15 (intra-file pair auditor), #18 (wake-window-cluster auditor).
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Fix class-number reference for wildcard auditor

The mechanization mapping cites “class #4 (wildcard-ref auditor),” but wildcard-not-navigable is class #11 in this taxonomy; class #4 belongs to the older v1 set with a different meaning. Leaving this mismatch will miswire any future B-0130 implementation work that consumes these class IDs as the lookup key.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new in-repo “PR-thread-resolution class taxonomy v2” memory entry consolidating drain-wave review-thread resolution patterns, and links it from the memory/MEMORY.md index so it’s discoverable for future PR triage.

Changes:

  • Adds memory/feedback_pr_thread_resolution_class_taxonomy_v2_drain_wave_2026_05_01.md documenting v2 taxonomy, diagnostic flowchart, and evidence summary.
  • Updates memory/MEMORY.md to include an index entry for the new taxonomy file.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
memory/feedback_pr_thread_resolution_class_taxonomy_v2_drain_wave_2026_05_01.md New taxonomy v2 write-up with verification/resolution recipes and cross-references.
memory/MEMORY.md Adds a top-level index bullet linking to the new taxonomy file.

Comment on lines +11 to +17
The v1 taxonomy (`memory/feedback_pr_thread_resolution_class_taxonomy_2026_04_28.md`, currently user-scope-only — never promoted in-repo per the 2026-04-24 natural-home directive) catalogued 7 classes from a 5-tick PR drain in 2026-04-28. The 2026-05-01 drain wave landed ~20 PR thread-fix ticks across ~16 ticks, encountering classes the v1 taxonomy didn't name. Deepseek (peer-AI) explicitly flagged the consolidation as overdue: *"The review-thread taxonomy is ready for consolidation. The loop has identified ~13 distinct classes of review findings."*

The cost of not consolidating: each class re-discovered from scratch on first encounter. Cost of consolidating: a single read-once, apply-many lookup. The leverage scales with the per-class repeat-rate (forward-reference fired 9+ times this drain wave alone).

## v1 reminder (the parent 7 classes)

Briefly, from `feedback_pr_thread_resolution_class_taxonomy_2026_04_28.md` (user-scope; promotion-to-in-repo is a separate followup row):
Copy link

Copilot AI May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: This references the v1 taxonomy as memory/feedback_pr_thread_resolution_class_taxonomy_2026_04_28.md, but that file is not present in-repo (and the sentence says it’s user-scope-only). Use the explicit user-scope path consistently (or clearly mark the in-repo path as a future/forward reference) to avoid a broken link.

Suggested change
The v1 taxonomy (`memory/feedback_pr_thread_resolution_class_taxonomy_2026_04_28.md`, currently user-scope-only — never promoted in-repo per the 2026-04-24 natural-home directive) catalogued 7 classes from a 5-tick PR drain in 2026-04-28. The 2026-05-01 drain wave landed ~20 PR thread-fix ticks across ~16 ticks, encountering classes the v1 taxonomy didn't name. Deepseek (peer-AI) explicitly flagged the consolidation as overdue: *"The review-thread taxonomy is ready for consolidation. The loop has identified ~13 distinct classes of review findings."*
The cost of not consolidating: each class re-discovered from scratch on first encounter. Cost of consolidating: a single read-once, apply-many lookup. The leverage scales with the per-class repeat-rate (forward-reference fired 9+ times this drain wave alone).
## v1 reminder (the parent 7 classes)
Briefly, from `feedback_pr_thread_resolution_class_taxonomy_2026_04_28.md` (user-scope; promotion-to-in-repo is a separate followup row):
The v1 taxonomy (the user-scope file `feedback_pr_thread_resolution_class_taxonomy_2026_04_28.md`, not present in this repo and never promoted in-repo per the 2026-04-24 natural-home directive) catalogued 7 classes from a 5-tick PR drain in 2026-04-28. The 2026-05-01 drain wave landed ~20 PR thread-fix ticks across ~16 ticks, encountering classes the v1 taxonomy didn't name. Deepseek (peer-AI) explicitly flagged the consolidation as overdue: *"The review-thread taxonomy is ready for consolidation. The loop has identified ~13 distinct classes of review findings."*
The cost of not consolidating: each class re-discovered from scratch on first encounter. Cost of consolidating: a single read-once, apply-many lookup. The leverage scales with the per-class repeat-rate (forward-reference fired 9+ times this drain wave alone).
## v1 reminder (the parent 7 classes)
Briefly, from the same user-scope file `feedback_pr_thread_resolution_class_taxonomy_2026_04_28.md` (not present in this repo; promotion-to-in-repo is a separate followup row):

Copilot uses AI. Check for mistakes.
Comment on lines +153 to +157
**Signal:** path/pattern is correct in 90% of contexts but wrong here because the project needs a different abstraction layer. E.g., `.git/hooks/pre-commit` (per-clone, untracked) vs `.githooks/` + `core.hooksPath` (versioned, indirected).

**Resolution:** **layer-of-abstraction discipline** — when describing a tooling integration, name the *versioned* layer (project artifact) rather than the *runtime* layer (per-clone instance). Same user-visible behavior; different durability.

**Example:** PR #1040 follow-up — `.git/hooks/pre-commit` rephrased to `.githooks/` + `core.hooksPath` integration.
Copy link

Copilot AI May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: The .githooks/ + core.hooksPath example implies a repo-local hooks setup, but this repo currently has no .githooks/ directory and hooks are plugin-shipped (per the hooks audit). Either update this example to the current mechanism (e.g., .claude/settings.json + plugin hooks), or explicitly label .githooks/ as a planned/future layer rather than an existing integration.

Suggested change
**Signal:** path/pattern is correct in 90% of contexts but wrong here because the project needs a different abstraction layer. E.g., `.git/hooks/pre-commit` (per-clone, untracked) vs `.githooks/` + `core.hooksPath` (versioned, indirected).
**Resolution:** **layer-of-abstraction discipline** — when describing a tooling integration, name the *versioned* layer (project artifact) rather than the *runtime* layer (per-clone instance). Same user-visible behavior; different durability.
**Example:** PR #1040 follow-up — `.git/hooks/pre-commit` rephrased to `.githooks/` + `core.hooksPath` integration.
**Signal:** path/pattern is correct in 90% of contexts but wrong here because the project needs a different abstraction layer. E.g., `.git/hooks/pre-commit` (per-clone, untracked) vs a versioned project-level hook surface such as `.claude/settings.json` + plugin-shipped hooks; `.githooks/` + `core.hooksPath` is the same pattern only if the repo actually adopts that layer.
**Resolution:** **layer-of-abstraction discipline** — when describing a tooling integration, name the *versioned* layer (project artifact) rather than the *runtime* layer (per-clone instance). Same user-visible behavior; different durability.
**Example:** PR #1040 follow-up — `.git/hooks/pre-commit` rephrased to the current versioned hook configuration surface (`.claude/settings.json` + plugin-shipped hooks), not to a non-existent `.githooks/` directory.

Copilot uses AI. Check for mistakes.
Comment on lines +254 to +255
- B-0129 (`docs/backlog/P3/B-0129-tick-history-schema-prediction-vs-receipt-column-aaron-2026-05-01.md`) — the named-policy that powers class #19 batch-resolution.
- B-0130 (`docs/backlog/P2/B-0130-verify-before-state-claim-mechanized-auditor-2026-05-01.md`) — when implemented, would mechanize classes #4 (wildcard-ref auditor), #10 (stale-filename / cross-reference-resolves-to-file auditor proposed for row #8), #15 (intra-file pair auditor), #18 (wake-window-cluster auditor).
Copy link

Copilot AI May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Several cross-references here don’t currently resolve: the referenced backlog-row files for B-0129 and B-0130 are not present under docs/backlog/. Also, B-0129 is described as powering class #19, but the deferred-per-policy class is #20, and the “wildcard” class referenced as #4 looks like it should be #11 (wildcard-not-navigable). Please fix the paths and the class-number references so the “Composes with” section stays navigable/verifiable.

Suggested change
- B-0129 (`docs/backlog/P3/B-0129-tick-history-schema-prediction-vs-receipt-column-aaron-2026-05-01.md`) — the named-policy that powers class #19 batch-resolution.
- B-0130 (`docs/backlog/P2/B-0130-verify-before-state-claim-mechanized-auditor-2026-05-01.md`) — when implemented, would mechanize classes #4 (wildcard-ref auditor), #10 (stale-filename / cross-reference-resolves-to-file auditor proposed for row #8), #15 (intra-file pair auditor), #18 (wake-window-cluster auditor).
- B-0129 (`docs/BACKLOG.md`, row `B-0129`) — the named-policy that powers class #20 batch-resolution.
- B-0130 (`docs/BACKLOG.md`, row `B-0130`) — when implemented, would mechanize classes #11 (wildcard-not-navigable auditor), #10 (stale-filename / cross-reference-resolves-to-file auditor proposed for row #8), #15 (intra-file pair auditor), #18 (wake-window-cluster auditor).

Copilot uses AI. Check for mistakes.
- B-0129 (`docs/backlog/P3/B-0129-tick-history-schema-prediction-vs-receipt-column-aaron-2026-05-01.md`) — the named-policy that powers class #19 batch-resolution.
- B-0130 (`docs/backlog/P2/B-0130-verify-before-state-claim-mechanized-auditor-2026-05-01.md`) — when implemented, would mechanize classes #4 (wildcard-ref auditor), #10 (stale-filename / cross-reference-resolves-to-file auditor proposed for row #8), #15 (intra-file pair auditor), #18 (wake-window-cluster auditor).
- `memory/feedback_pr_thread_resolution_class_taxonomy_2026_04_28.md` — v1 parent.
- The drain-wave tick-history shards `docs/hygiene-history/ticks/2026/05/01/0904Z.md` through `1007Z.md` — empirical evidence for each class-firing.
Copy link

Copilot AI May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: This cites tick-history shards through 1007Z.md, but there is no docs/hygiene-history/ticks/2026/05/01/1007Z.md in the tree (the latest on that date appears to be 1003Z.md). Update the range (or list) to only include existing shard filenames.

Copilot uses AI. Check for mistakes.
AceHack added a commit that referenced this pull request May 1, 2026
…class #19 meets class #1c

Gemini reviewed minutes after PR #1081 (taxonomy v2) landed, proposing two
cross-cutting actions: (a) port an "8-step cold-start checklist" from a
specific memory file into CLAUDE.md, (b) clean up the CLI task queue.

Action (a) cited `feedback_cold_start_big_picture_first_not_prompt_first_aaron_2026_04_30.md`
which does NOT exist — verified empirically via `find memory -name`,
user-scope-find, and grep. **Class #1c (hallucinated content) per v2 taxonomy.**

Aaron's filter forwarded simultaneously: *"You are smarter than gemini in
my opinion, it mostly praises you"* — register annotation, not dismissal.
Composes with the v2 verification cascade to produce confident empirical
refutation of (a) while preserving Gemini's substantive intent (CLAUDE.md
mechanical-enforcement leverage is real; current CLAUDE.md already
addresses it via "Read these, in this order" + "Fast-path on wake").

Action (b) is real-fix candidate, deferred to rested-attention session
(53 task-state mutations under autonomous loop is too-large blast radius).

Carved: *"Praise discount. Cited evidence verify. Substantive cross-PR
intent preserve."* — three-step parser for peer-AI structural reviews.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…05-01 drain wave + Aaron meta-class

Per Deepseek peer-AI's explicit ask 2026-05-01: *"The review-thread taxonomy
is ready for consolidation. The loop has identified ~13 distinct classes of
review findings."* Plus Aaron's just-in-time meta-flag during the
consolidation: *"that itself is a new class of review"* — observing that
peer-AI structural intervention is itself a distinct class (#19), making
this the consolidation that surfaced its own bootstrapping class.

Extends v1 (`feedback_pr_thread_resolution_class_taxonomy_2026_04_28.md`,
currently user-scope-only — promotion to in-repo is a separate follow-up):

- Phantom-blocker sub-classes 1a/1b/1c: line-prefix-display-artifact /
  rendered-form-misread / hallucinated-content (each requires different
  empirical-verification command).
- Real-fix sub-classes 8-18: forward-reference (9+ instances; canonical),
  contradicts-CLAUDE.md (dual corrective: remove-loophole + cite-principle-
  inline), stale-filename-cross-reference, wildcard-not-navigable,
  executable-prose, persona-name-role-ref, user-scope-only-reference,
  intra-file-drift, named-link, structural-pattern-mismatch,
  same-wake-author-error-cluster.
- New mode classes 19-20: peer-AI-structural / consolidation-prompt
  (the meta-class — how new classes get discovered) and
  deferred-per-explicit-policy / no-edit-resolve (highest-leverage class
  for batch-resolution; cite-and-resolve template scales linearly).

Includes diagnostic flowchart (14-step cascade for first-read classification)
and empirical evidence summary (45+ class-firings catalogued across ~16
ticks). Composes with B-0129 (named-policy that powers class #20),
B-0130 (mechanization path for classes #4/#10/#15/#18), and the
drain-wave tick-history shards 0904Z..1007Z.

Carved candidate: *"Filed-policy beats per-PR judgment. When a recurring
finding has an explicit policy, the cite-and-resolve template scales
linearly across PRs. The 13-PR batch is the worked example."*

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@AceHack AceHack enabled auto-merge (squash) May 1, 2026 12:19
@AceHack AceHack force-pushed the memory/pr-thread-resolution-class-taxonomy-v2-drain-wave-2026-05-01 branch from ea4714f to e55d18d Compare May 1, 2026 12:19
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

AceHack added a commit that referenced this pull request May 3, 2026
…no new findings; older PRs out of Otto's triage scope (#1327)

Brief reflective tick:
- No new threads on merged PRs
- Older open PRs (#655, #659, #1081, #1083, #1085) all Aaron-authored; out of Otto's scope
- Session arc reflection: calibration cluster + v0.5 substrate-claim-checker + first threshold-crossing + architectural framing memos + bear-leak event + ~25 bounded fixes via post-merge-thread-loop

Pattern: steady-state observation IS legitimate tick-content. Don't manufacture fixes when nothing genuine pending; the loop resumes 2-3 fixes/tick when findings arrive.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants