-
Notifications
You must be signed in to change notification settings - Fork 1
hygiene(tick-history): shard 0723Z — PR #1018 CI fix tick #1037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| | 2026-05-01T07:23:00Z | opus-4-7 / autonomous-loop tick | 98fc7424 | PR #1018 CI-fix tick — two CI failures root-caused and fixed. (1) **shellcheck SC2295** on `tools/backlog/generate-index.sh` line 142: parameter expansion `${file#${REPO_ROOT}/}` needs inner expansion quoted separately to prevent pattern matching. Changed to `${file#"${REPO_ROOT}"/}` per shellcheck's recommendation. (2) **BACKLOG.md generated-index drift**: B-0124, B-0125, B-0126 were filed without YAML frontmatter (only markdown headers). The new generator (which warns AND skips on missing frontmatter) emitted different output than committed BACKLOG.md (which had empty entries for those three files). Backfilled YAML frontmatter on all three with `id`/`priority`/`status`/`title`/`created`/`last_updated` fields per the schema other backlog rows use. Regenerated BACKLOG.md via `BACKLOG_WRITE_FORCE=1 tools/backlog/generate-index.sh`. Both CI checks pass locally; auto-merge armed. Merged PRs visible in this tick: #986 (CSAP-absorption Deepseek corrections + Aaron 'center of the storm') and #1036 (tick-shard 0710Z) landed on main. Cron 98fc7424 healthy. | [PR #1018: 2 CI failures → 0; auto-merge armed] / [#986 + #1036 merged to main] | Class-level lesson reinforced: **the verify-before-state-claim discipline applies at backlog-row authoring time too.** B-0124/0125/0126 were filed with markdown headers but no schema-conforming YAML frontmatter — the file claimed backlog-row status structurally without satisfying the schema. PR #1018's WARN behavior is exactly the mechanization Aaron asked for in task #350 (auditor extension to verify file-internal metadata claims at pre-commit), one specific surface at a time. The shellcheck SC2295 catch is interesting: the fix was a one-character change (adding quotes around `${REPO_ROOT}`), but the fix-to-find ratio is high — without shellcheck, the bug wouldn't manifest until a path contained pattern-special characters. Future-Otto: when adding bash code to substrate, run `shellcheck` locally before pushing — same compose-time verify-before-state-claim discipline applied to shell scripts. | | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.