Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,18 @@ Make `Analyze (csharp)` (and any other F#-only CI step) skip on PRs that touch o

1. **Path-filter implemented.** PRs touching only the listed non-code surfaces skip `Analyze (csharp)` and any F#-only CI steps. Implementation must use a deterministic path-list (not pattern guesswork) to avoid silent drift.
2. **TypeScript still runs.** Any PR touching `*.ts` / `*.tsx` / `package.json` / `bun.lock` / `tsconfig*.json` runs the full TypeScript pipeline. The "TypeScript is part of docs" carve-out from Aaron's chat framing is honored.
3. **`code_quality severity:all` does NOT fail** on LFG/main when the skip fires. Either via:
3. **`code_quality severity:all` does NOT fail** on LFG/main when the skip fires. Three paths in the design space:
- (a) Conditional skip-vs-run rather than always-run pattern (so the ruleset sees "not applicable" not "failed"), OR
- (b) Coordinated ruleset config change (with appropriate sign-off — host mutation per task #343 is an Aaron-decision class, NOT Otto's; Otto identifies the option but doesn't execute it without explicit Aaron sign-off because host-mutation has shown failure modes before per Amara/Aaron 2026-04-29).
- (b) Coordinated ruleset config change on the existing single ruleset, OR
- (c) **Multi-ruleset split** — separate docs-targeted ruleset (lower bar; F# Analyze not required) + code-targeted ruleset (severity:all on src/ paths). Aaron 2026-05-01 in chat: *"maybe multiple rulesets i just had one for convience, you can do it for whats best for your and making humans feel comfortable, all makes humans feel comfortable i don't know if that help if not no worries."* This reveals the single severity:all ruleset was set up for convenience, not as a technical requirement. The real constraint is **human-comfort signaling** — humans see "all required checks passing" and feel reassured; the literal severity:all configuration is one of several ways to produce that signal. A multi-ruleset design that surfaces "all required-for-this-surface checks pass" preserves the comfort property without requiring F# Analyze on docs PRs.

**Aaron's host-mutation authorization for this work specifically (2026-05-01):** *"you can do it for what's best."* Scoped explicitly to the ruleset-redesign work in this row. NOT a blanket grant on host mutations going forward — the §16 host-mutation-needs-sign-off rule remains in force; this is an explicit per-row carve-out for B-0125 implementation.
Copy link

Copilot AI May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reference to “§16 host-mutation-needs-sign-off rule” appears to be an incorrect/unclear cross-reference (repo-wide §16 is used for other meanings, and this file doesn’t define a §16). Please replace this with a verifiable pointer to the actual host-mutation constraint you mean (e.g., the host-mutation receipt memory file or another canonical doc section), so future implementers can trace the rule unambiguously.

Suggested change
**Aaron's host-mutation authorization for this work specifically (2026-05-01):** *"you can do it for what's best."* Scoped explicitly to the ruleset-redesign work in this row. NOT a blanket grant on host mutations going forward — the §16 host-mutation-needs-sign-off rule remains in force; this is an explicit per-row carve-out for B-0125 implementation.
**Aaron's host-mutation authorization for this work specifically (2026-05-01):** *"you can do it for what's best."* Scoped explicitly to the ruleset-redesign work in this row. NOT a blanket grant on host mutations going forward — the host-mutation sign-off constraint evidenced by the `memory/feedback_*` receipts for PRs #849/#857/#651 and the task #343 drift-debt receipt mentioned above remains in force; this is an explicit per-row carve-out for B-0125 implementation.

Copilot uses AI. Check for mistakes.
4. **Verification across PR shapes:** docs-only PR, TypeScript-only PR, src-only PR, mixed PR, workflow-only PR — all behave correctly.
5. **No reduction in security coverage** for actual code surfaces. Skip is for non-code only.

## Out of scope

- **Changing what `code_quality severity:all` requires** beyond the minimum needed to support the path-filter (host-mutation needs Aaron sign-off, not Otto-authority).
- **Changing what `code_quality severity:all` requires** for code surfaces (src/) — that protection stays at the same severity level. Multi-ruleset split adds a docs-targeted ruleset alongside; it does NOT lower the bar on the code-targeted ruleset.
- **Skipping CodeQL on other languages** (only F#/csharp is named in Aaron's chat carve-out).
- **Skipping TypeScript checks ever** — TypeScript IS docs surface per CURRENT-aaron §30.
Copy link

Copilot AI May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bullet says “TypeScript IS docs surface per CURRENT-aaron §30”, but §30 in memory/CURRENT-aaron.md is specifically “TypeScript/Bun is the factory tooling default” (i.e., treat it as code/tooling). Since this row also earlier says “TypeScript is factory tooling … treat as code”, this wording is internally inconsistent and could mislead someone into thinking TS checks are skippable on docs PRs. Suggest rephrase to consistently state that TS is factory tooling and must never be skipped, even on docs-only PRs.

Suggested change
- **Skipping TypeScript checks ever** — TypeScript IS docs surface per CURRENT-aaron §30.
- **Skipping TypeScript checks ever** — TypeScript is factory tooling per CURRENT-aaron §30, so treat it as code/tooling and never skip it, including on docs-only PRs.

Copilot uses AI. Check for mistakes.
- **Cross-cutting CI overhaul** — narrow scope; broader CI work can be its own row.
Expand Down
Loading