Repository navigation
chore(process): add feature-removal sweep checklist (#908) - #913
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Failed to generate code suggestions for PR |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughPR template expanded to include checklist sections for testing, changelog updates, TypeScript builds, and a new "Feature-removal sweep" section. Dangerfile enhanced to detect removal-related commits and warn authors when the checklist is absent from the PR body. ChangesFeature-removal enforcement
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@dangerfile.ts`:
- Line 144: The current check using hasSweepChecklistInBody =
prBody.includes('Feature-removal sweep') is case-sensitive and will miss
variations; update the detection to be case-insensitive by normalizing prBody
(e.g., prBody.toLowerCase()) or using a case-insensitive regex (e.g.,
/feature-removal sweep/i) when checking for the string so
hasSweepChecklistInBody reliably matches any capitalization variations.
- Line 154: The markdown link in dangerfile.ts uses `${pr.html_url}` (the PR
URL) but the link text refers to the ADR file; update the template so the URL
points to the actual ADR document (e.g., the repository blob URL or relative
path to docs/decisions/2026-05-19-retire-per-guild-feature-toggles.md) instead
of `${pr.html_url}`; locate the string template containing `[See
docs/decisions/2026-05-19-retire-per-guild-feature-toggles.md](${pr.html_url})`
and replace the `${pr.html_url}` portion with the correct ADR file URL (or a
repo/blob path using repo/pr/base ref variables if needed).
- Around line 142-147: The removalPattern is too restrictive because it requires
the removal keyword at the start of the commit message; update the detection
used by hasRemovalCommit so it matches removal keywords anywhere in the message
(e.g., remove the leading ^ and ensure word boundaries and case-insensitivity)
or implement a two-step check that looks for any removal verb and any target
noun separately in each danger.git.commits message (refer to removalPattern and
hasRemovalCommit to locate the logic); ensure prBody/hasSweepChecklistInBody
logic remains unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 97707b0d-6fb4-4218-b8ae-184471dc0174
📒 Files selected for processing (2)
.github/PULL_REQUEST_TEMPLATE.mddangerfile.ts
Three findings from CodeRabbit on the original PR:
1. removalPattern was anchored to `^` — would miss removal-verbs anywhere
except commit-message start. Split into two case-insensitive word-boundary
regexes (removalVerb + removalTarget) and require both to match the same
commit message.
2. hasSweepChecklistInBody used case-sensitive includes() — would miss the
"feature-removal sweep" or "Feature-removal Sweep" capitalisation variants.
Switched to case-insensitive regex.
3. ADR link in the warn() interpolated pr.html_url (the PR URL) but labelled
it as the ADR file. Now builds the correct repo blob URL from pr.base
{repo.full_name, ref} + relative ADR path.
Also: add the CHANGELOG [Unreleased] entry for the sweep checklist PR (#908).
a465fd2 to
c0a6634
Compare
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
## Release v2.13.0 Promotes \`release/v2.13.0\` to \`main\` for the v2.13.0 cut. **$AHEAD commits across all merged PRs since v2.11.0 ship.** (Skipping v2.12.0 — the branch existed but its work was rolled forward into v2.13.0 alongside this session's Zod migration + CVE patches + standards adoption.) ## Headline changes **Added** — Guild Automation Module Executor pilot (#901), Sentry frontend (#876), Prometheus metrics on bot+backend (#873, #875), guild membership history (#872), Trivy image-scan Phase A (#883), landing redesign (#868). **Changed** — Backend migrated to Zod 4 API (#919), 3 bot circular-deps clusters broken (#885/#886/#888). **Fixed** — brace-expansion + ws moderate CVEs (#921), nginx-alpine CVEs (#881), CI postinstall rate limit (#878), madge actionlint (#905). **Internal** — shared coverageThreshold gate (#909/#914), Feature-removal sweep checklist + dangerfile guard (#908/#913), monitoring network, AI-doc policy, 4 new ADRs. Full list in [CHANGELOG.md](./CHANGELOG.md). ## Merge method This PR should land via **merge commit** (NOT squash) to preserve the individual PR SHAs in main's history. After merge: 1. Tag \`v2.13.0\` on the merge commit 2. Create GitHub release with notes from CHANGELOG.md 3. Fast-forward \`release/v2.13.0\` to match the new main HEAD ## Test plan - [ ] All 30 checks green except infra (snyk plan cap) - [ ] Verify \`gh pr view 922 --json mergeCommit\` shows the chore-bump commit on release tip - [ ] After merge: confirm \`origin/main\` contains the full $AHEAD commits
This branch was successfully deployed
1 participant
Goal
Prevent orphan code (Prisma models, broken test files, dead types) from being left behind after feature/route removal PRs. PR #903 had to clean up 2-week-old orphans from PR #801.
Changes
PR Template: Added
.github/PULL_REQUEST_TEMPLATE.mdwith a new "Feature-removal sweep" checklist section (skip-friendly) covering:Dangerfile Guard: Added rule Bump npm-check-updates from 16.14.20 to 18.0.1 #9 to
dangerfile.tsthat detects commit messages matching removal patterns (remove|delete|retire|drop|deprecate+route|handler|endpoint|model|toggle|feature) and warns if the PR body doesn't contain the sweep checklist text.Acceptance
See docs/decisions/2026-05-19-retire-per-guild-feature-toggles.md for context.
Summary by CodeRabbit