Repository navigation
chore(docker): join bot+backend to shared lucky-monitoring network - #877
Conversation
Lets the homelab Prometheus container scrape /metrics on lucky-bot:9091 and lucky-backend:5000 without publishing those ports to the host. Lucky owns the network (declared here); homelab joins it as `external: true` in compose/monitoring.yml. See homelab PR #135. Pairs with #873 (bot metrics) and #875 (backend metrics).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LucasSantana-Dev has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Failed to generate code suggestions for PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughDocker Compose configuration adds a ChangesMonitoring Network Integration
🎯 2 (Simple) | ⏱️ ~5 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
) ## Summary Fixes #874 by: 1. **Bumping the pinned ref of the org reusable \`quality.yml\`** to the merge commit of [LucasSantana-Dev/.github#2](LucasSantana-Dev/.github#2). That PR adds \`GITHUB_TOKEN\` + \`YOUTUBE_DL_SKIP_DOWNLOAD=true\` to the install step in the \`lint\` and \`deadcode\` jobs, eliminating the 60 req/hr unauthenticated cap that's been failing PRs since the observability rollout started. 2. **Applying the same env vars to local \`release.yml\`** for parity. Release builds don't strictly need the yt-dlp binary, so skipping the fetch is harmless. ## Why this scope | Workflow | npm ci flags | Status | |---|---|---| | \`ci.yml\` | \`--legacy-peer-deps --ignore-scripts\` | already safe | | \`sonarcloud.yml\` | \`--legacy-peer-deps --ignore-scripts\` | already safe | | \`bundle-size.yml\` | runs postinstall | already sets both env vars | | \`release.yml\` | bare \`npm ci\` | **fixed here** | | reusable \`quality.yml\` | runs postinstall | **fixed via SHA bump** | ## Closes - #874 ## Unblocks - PR #873 (bot observability metrics) - PR #875 (backend observability) - PR #876 (frontend Sentry) - PR #877 (paired Lucky-side network for homelab #135) ## Test plan - [ ] \`quality / Lint\` passes on this PR's first run - [ ] After merge: re-run failed \`quality / Lint\` on #873 / #875 / #876 — they should pass without retry
There was a problem hiding this comment.
LucasSantana-Dev has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
This branch was successfully deployed
1 participant
Summary
Adds the
lucky-monitoringDocker network and joins bothbotandbackendservices to it, so the homelab Prometheus container can scrape:lucky-bot:9091/metrics(added in feat(bot): Prometheus /metrics endpoint + guild count gauge #873)lucky-backend:5000/metrics(added in feat(backend): Prometheus /metrics endpoint + request middleware #875)…without exposing those ports to the host.
Lucky owns/creates the network; homelab joins it as
external: trueincompose/monitoring.yml(homelab PR #135).Why this PR exists separately
PR #135 in the homelab repo declares
lucky-monitoringas an external network. Without this Lucky-side change, the homelab stack would fail to start (network does not exist) and the newLuckyBotDown/LuckyBackendDownalerts would fire immediately on deploy because the scrape targets would not be DNS-resolvable.Deploy order
docker network lsshowslucky-monitoringup{job=~"lucky-.*"} == 1Test plan
docker network inspect lucky-monitoringshows bothlucky-botandlucky-backendattachedUPSummary by CodeRabbit