Repository navigation
ci(bot): pin coverage threshold floor before phase-2 cleanup - #835
Merged
Merged
Conversation
Lock the bot package's coverage gate at the round-down of the post-#821 baseline so subsequent test-cleanup work has a tripwire. Numbers are chosen to be binding without forcing emergency repair on day 1; tighten 2-3 % per phase as the suite shrinks toward proportional size. Current vs floor: Statements 67.03 % (>= 65) Branches 63.47 % (>= 60) Functions 63.89 % (>= 60) Lines 68.15 % (>= 65) Refs .agents/plans/test-cleanup-phase2.md
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LucasSantana-Dev has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (1)
📝 WalkthroughWalkthroughThis PR updates the Jest configuration for the bot package to enforce minimum code coverage thresholds. A ChangesJest Coverage Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Failed to generate code suggestions for PR |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
LucasSantana-Dev
enabled auto-merge (squash)
May 9, 2026 13:33
|
LucasSantana-Dev
added a commit
that referenced
this pull request
May 10, 2026
…e/v2.10.0 merge Merge from release/v2.10.0 brought in PR #835 (test phase-2) which included new tests using the legacy 'reason: string' shape. Update to the new {source, signals} basis API: - autoplayAudit.spec.ts: createScoredTrack helper uses basis; setFinalSelected + emit tests pass basis instead of reason; expected reason becomes serializeBasis output ('spotify rec • preferred artist', 'last.fm similar'). - pipeline.integration.spec.ts: upsertScoredCandidate calls use {source, signals}. - lastFmSeeder.spec.ts / candidateFallback.spec.ts: calculateRecommendationScore mock returns {score, signals} (no reason). - queueManipulation.spec.ts: ScoredTrack literals use basis. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
LucasSantana-Dev
added a commit
that referenced
this pull request
May 10, 2026
…ionBasis (#830) * refactor(autoplay): introduce RecommendationBasis type and serializeBasis * refactor(autoplay): fix RecommendationSignal to match candidateScorer signal strings * refactor(autoplay): candidateScorer returns signals array instead of reason string * refactor(autoplay): collectors assign RecommendationSource to upsertScoredCandidate * fix(tsconfig): update ignoreDeprecations from 6.0 to 5.0 for TypeScript 5.9 compatibility * refactor(autoplay): serialize basis at display/persistence boundaries - diversitySelector.ts: change markAsAutoplayTrack to use serializeBasis(candidate.basis) - replenisher.ts: change debug log to use serializeBasis(s.basis) for display - candidateFallback.ts: remove reason mutation in enrichWithAudioFeatures (signal already captured by scoreCalculation) - candidateCollector.spec.ts: update tests to use new { score, source, signals } signature for upsertScoredCandidate All TypeScript errors resolved for modified files. No behavior changes, only API boundary updates. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * refactor(autoplay): complete recommendation basis migration - tests + cleanup * refactor(autoplay): fix stale comment in serializeBasis Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(tsconfig): revert ignoreDeprecations back to 6.0 The project requires TypeScript ^6.0.3 per packages/shared/package.json. The per-package tsc (6.0.3) requires "ignoreDeprecations": "6.0" to silence the node10/baseUrl deprecation warnings. The earlier change to "5.0" was based on running root-level tsc (5.9.3) which is not the build tool for these packages. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(tsconfig): bump ignoreDeprecations to 6.0 for frontend and backend baseUrl is deprecated in TypeScript 7.0 and requires ignoreDeprecations: "6.0" to silence the TS5101 error that was breaking the type check CI step. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(test): update 3 specs for RecommendationBasis refactor - candidateFallback.spec.ts: createScoredTrack uses basis instead of reason; remove stale reason assertion (genre penalty only changes score) - lastFmSeeder.spec.ts: mock ./candidateCollector for shouldInclude/ upsertScored (moved from queueManipulation in this PR) - replenisher.spec.ts: mockScoredTracks and candidateMap use basis to prevent serializeBasis(undefined) swallowing the telemetry log Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(autoplay): restore genre family drift signal tracking in enrichWithAudioFeatures The penalty was applied to score but the signal was not pushed to basis.signals after the RecommendationBasis refactor. Matches the threshold used in candidateScorer.ts (familyPenalty <= -0.3). Also restores the spec assertion to verify the signal is tracked. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(test): update lastFmSeeder spec assertions for RecommendationBasis refactor Replace stale reason string checks with source field assertions after upsertScoredCandidate signature changed from {score, reason} to {score, source, signals}. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(test): update remaining lastFmSeeder reason assertions to source checks Two more stale `reason` references (skips-disliked and vc-member tests) updated to use source === 'lastfm-genre-fallback'. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(autoplay): address code review feedback on PR #830 - diversitySelector.ts: Use 'import type' for RecommendationBasis to follow project convention and avoid issues with strict module settings - candidateCollector.ts: Add explanatory note to hard-reject debug logs about why signals are empty, improving debuggability Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: revert ignoreDeprecations to 5.0 and clean up spotifyRecommender - Revert tsconfig ignoreDeprecations from 6.0 to 5.0 across all packages Root TypeScript is 5.9.3 and does not understand 6.0, causing TS5103 errors Per-package TypeScript 6.0.3 installation would be needed for 6.0 to work - Clean up duplicate and stale code fragments in spotifyRecommender.ts from previous incomplete merge conflict resolution Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(tsconfig): restore ignoreDeprecations 6.0 for per-package TS 6.0.3 CI build failed with TS5107/TS5101 because previous revert dropped ignoreDeprecations back to '5.0', but the per-package TypeScript is 6.0.3 and rejects '5.0'. Root tsconfig stays on '5.0' (root TS is 5.9.3). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(autoplay): replace stale t.reason with serializeBasis(t.basis) in autoplayAudit setFinalSelected still referenced ScoredTrack.reason after the RecommendationBasis refactor removed it. Wire serializeBasis the same way diversitySelector.markAsAutoplayTrack does. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * test(autoplay): align specs with RecommendationBasis API after release/v2.10.0 merge Merge from release/v2.10.0 brought in PR #835 (test phase-2) which included new tests using the legacy 'reason: string' shape. Update to the new {source, signals} basis API: - autoplayAudit.spec.ts: createScoredTrack helper uses basis; setFinalSelected + emit tests pass basis instead of reason; expected reason becomes serializeBasis output ('spotify rec • preferred artist', 'last.fm similar'). - pipeline.integration.spec.ts: upsertScoredCandidate calls use {source, signals}. - lastFmSeeder.spec.ts / candidateFallback.spec.ts: calculateRecommendationScore mock returns {score, signals} (no reason). - queueManipulation.spec.ts: ScoredTrack literals use basis. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(autoplay): dedupe 'genre family drift' signal push in enrichWithAudioFeatures Address CodeRabbit feedback on PR #830. Although serializeBasis dedupes via Array.from(new Set), the in-memory ScoredTrack.basis.signals[] could accumulate duplicates if the same track flows through enrichment twice. Guard with .includes() before push. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Merged
LucasSantana-Dev
added a commit
that referenced
this pull request
May 13, 2026
Lock the bot package's coverage gate at the round-down of the post-#821 baseline so subsequent test-cleanup work has a tripwire. Numbers are chosen to be binding without forcing emergency repair on day 1; tighten 2-3 % per phase as the suite shrinks toward proportional size. Current vs floor: Statements 67.03 % (>= 65) Branches 63.47 % (>= 60) Functions 63.89 % (>= 60) Lines 68.15 % (>= 65) Refs .agents/plans/test-cleanup-phase2.md
LucasSantana-Dev
added a commit
that referenced
this pull request
May 13, 2026
…ionBasis (#830) * refactor(autoplay): introduce RecommendationBasis type and serializeBasis * refactor(autoplay): fix RecommendationSignal to match candidateScorer signal strings * refactor(autoplay): candidateScorer returns signals array instead of reason string * refactor(autoplay): collectors assign RecommendationSource to upsertScoredCandidate * fix(tsconfig): update ignoreDeprecations from 6.0 to 5.0 for TypeScript 5.9 compatibility * refactor(autoplay): serialize basis at display/persistence boundaries - diversitySelector.ts: change markAsAutoplayTrack to use serializeBasis(candidate.basis) - replenisher.ts: change debug log to use serializeBasis(s.basis) for display - candidateFallback.ts: remove reason mutation in enrichWithAudioFeatures (signal already captured by scoreCalculation) - candidateCollector.spec.ts: update tests to use new { score, source, signals } signature for upsertScoredCandidate All TypeScript errors resolved for modified files. No behavior changes, only API boundary updates. * refactor(autoplay): complete recommendation basis migration - tests + cleanup * refactor(autoplay): fix stale comment in serializeBasis * fix(tsconfig): revert ignoreDeprecations back to 6.0 The project requires TypeScript ^6.0.3 per packages/shared/package.json. The per-package tsc (6.0.3) requires "ignoreDeprecations": "6.0" to silence the node10/baseUrl deprecation warnings. The earlier change to "5.0" was based on running root-level tsc (5.9.3) which is not the build tool for these packages. * fix(tsconfig): bump ignoreDeprecations to 6.0 for frontend and backend baseUrl is deprecated in TypeScript 7.0 and requires ignoreDeprecations: "6.0" to silence the TS5101 error that was breaking the type check CI step. * fix(test): update 3 specs for RecommendationBasis refactor - candidateFallback.spec.ts: createScoredTrack uses basis instead of reason; remove stale reason assertion (genre penalty only changes score) - lastFmSeeder.spec.ts: mock ./candidateCollector for shouldInclude/ upsertScored (moved from queueManipulation in this PR) - replenisher.spec.ts: mockScoredTracks and candidateMap use basis to prevent serializeBasis(undefined) swallowing the telemetry log * fix(autoplay): restore genre family drift signal tracking in enrichWithAudioFeatures The penalty was applied to score but the signal was not pushed to basis.signals after the RecommendationBasis refactor. Matches the threshold used in candidateScorer.ts (familyPenalty <= -0.3). Also restores the spec assertion to verify the signal is tracked. * fix(test): update lastFmSeeder spec assertions for RecommendationBasis refactor Replace stale reason string checks with source field assertions after upsertScoredCandidate signature changed from {score, reason} to {score, source, signals}. * fix(test): update remaining lastFmSeeder reason assertions to source checks Two more stale `reason` references (skips-disliked and vc-member tests) updated to use source === 'lastfm-genre-fallback'. * fix(autoplay): address code review feedback on PR #830 - diversitySelector.ts: Use 'import type' for RecommendationBasis to follow project convention and avoid issues with strict module settings - candidateCollector.ts: Add explanatory note to hard-reject debug logs about why signals are empty, improving debuggability * fix: revert ignoreDeprecations to 5.0 and clean up spotifyRecommender - Revert tsconfig ignoreDeprecations from 6.0 to 5.0 across all packages Root TypeScript is 5.9.3 and does not understand 6.0, causing TS5103 errors Per-package TypeScript 6.0.3 installation would be needed for 6.0 to work - Clean up duplicate and stale code fragments in spotifyRecommender.ts from previous incomplete merge conflict resolution * fix(tsconfig): restore ignoreDeprecations 6.0 for per-package TS 6.0.3 CI build failed with TS5107/TS5101 because previous revert dropped ignoreDeprecations back to '5.0', but the per-package TypeScript is 6.0.3 and rejects '5.0'. Root tsconfig stays on '5.0' (root TS is 5.9.3). * fix(autoplay): replace stale t.reason with serializeBasis(t.basis) in autoplayAudit setFinalSelected still referenced ScoredTrack.reason after the RecommendationBasis refactor removed it. Wire serializeBasis the same way diversitySelector.markAsAutoplayTrack does. * test(autoplay): align specs with RecommendationBasis API after release/v2.10.0 merge Merge from release/v2.10.0 brought in PR #835 (test phase-2) which included new tests using the legacy 'reason: string' shape. Update to the new {source, signals} basis API: - autoplayAudit.spec.ts: createScoredTrack helper uses basis; setFinalSelected + emit tests pass basis instead of reason; expected reason becomes serializeBasis output ('spotify rec • preferred artist', 'last.fm similar'). - pipeline.integration.spec.ts: upsertScoredCandidate calls use {source, signals}. - lastFmSeeder.spec.ts / candidateFallback.spec.ts: calculateRecommendationScore mock returns {score, signals} (no reason). - queueManipulation.spec.ts: ScoredTrack literals use basis. * fix(autoplay): dedupe 'genre family drift' signal push in enrichWithAudioFeatures Address CodeRabbit feedback on PR #830. Although serializeBasis dedupes via Array.from(new Set), the in-memory ScoredTrack.basis.signals[] could accumulate duplicates if the same track flows through enrichment twice. Guard with .includes() before push. --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
LucasSantana-Dev
added a commit
that referenced
this pull request
May 13, 2026
Promote [Unreleased] entries into the v2.10.0 section, bump root + workspace versions from 2.9.0 to 2.10.0, and update the lockfile. Release highlights: - Spotify 429 retry hardening (#808) - Last.fm canonical metadata + multi-artist scrobble fix (#821) - Autoplay Spanish-gospel-block + sertanejo prioritization series (#817-#820, #827, #829, #830) - Review-tools revamp: Claude review + Danger + chilled CodeRabbit via org-level reusable workflows (#838) - Coverage threshold pinned for phase-2 test cleanup (#835) - CI extended to release/** branches (#816)
This was referenced May 24, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
coverageThresholdtopackages/bot/jest.config.cjsso the botsuite's coverage gate becomes binding before phase-2 test cleanup
begins.
Why
After PR #821 landed, the bot suite has 2,848 tests / 39k LOC and
no coverage threshold configured. Per the canonical
/test-cleanupskill, deletions must run against a configured floor — otherwise pruning
is blind to coverage and a regression slips silently into CI.
This PR is intentionally tiny so the gate exists in CI before the
larger phase-2 deletion PR is opened.
Numbers
The floor is the round-down of post-#821 baseline. The plan is to
tighten 2-3 % per cleanup phase as the suite shrinks toward proportional
size (target ~1,500 tests for a 39k LOC full-stack-tier bot).
Test posture
release/v2.10.0post-merge.Related
.agents/plans/test-cleanup-phase2.mdtest/suite-redesign-phase2will start the actual cleanuppass after this lands.
🤖 Generated with Claude Code
Summary by CodeRabbit