Repository navigation
fix(lastfm): resolve canonical metadata for album art and multi-artist scrobbles #821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
bde4969
test: remove 52 pure-delegation spec files (Phase 1)
LucasSantana-Dev 76cc76e
test: trim delegation-only it() blocks from mixed spec files (Phase 2)
LucasSantana-Dev 1100ec8
test: trim delegation-only it() blocks from command spec files (Phase 3)
LucasSantana-Dev 36d5b1c
test: remove pure-delegation it() blocks from play/index.spec.ts (Pha…
LucasSantana-Dev 9e05300
test: add autoplay pipeline integration test, trim coordinator specs
LucasSantana-Dev f916f63
fix(lastfm): resolve canonical metadata to fix scrobble album art and…
LucasSantana-Dev 0637f57
fix(lastfm): fix cache race, empty artist guard, and log level in met…
LucasSantana-Dev da00e95
test: trim log-assertion and coordinator-call tests from 5 spec files
LucasSantana-Dev 61706a6
test(lastfm): add TTL expiry, empty string, and unicode edge-case tests
LucasSantana-Dev 69196c2
test(lastfm): fix timer cleanup and assertion style in edge-case tests
LucasSantana-Dev 1b28da4
test: remove coordinator/log-only tests from eventHandler
LucasSantana-Dev d6e308f
test: remove coordinator/log-only tests from errorHandlers
LucasSantana-Dev e4ba468
feat(lastfm): log when track metadata is unavailable in now-playing h…
LucasSantana-Dev 1b8b679
test: remove coordinator/log-only tests from interactionReply and mem…
LucasSantana-Dev 8d85247
test: remove coordinator/log-only tests from playerFactory bridge and…
LucasSantana-Dev b2f81eb
test: remove coordinator/log-only tests from interactionHandler and q…
LucasSantana-Dev a2502e9
test: remove coordinator/log-only tests from initializer and automod
LucasSantana-Dev dd518d4
test(lastfm): cover metadata parameter in updateNowPlaying and scrobble
LucasSantana-Dev 0bdf3a4
chore: merge release/v2.10.0 into test/suite-redesign-phase1
LucasSantana-Dev 3709682
ci: trigger test suite after merge from release/v2.10.0
LucasSantana-Dev e08aef2
test(autoplay): add AutoplayAuditCollector unit tests
LucasSantana-Dev 0b00570
Merge remote-tracking branch 'origin/release/v2.10.0' into test/suite…
LucasSantana-Dev a975fd6
fix(test): remove unclosed it() block left by merge conflict resolution
LucasSantana-Dev 9796eef
fix(tests): complete 3 incomplete test blocks in queueManipulation.spec
LucasSantana-Dev 6dab02a
test(externalScrobbler): restore spec with getTrackMetadata mock and …
LucasSantana-Dev 84622ea
fix(autoplay): log swallowed errors in candidateFallback
LucasSantana-Dev 77d0ba0
test(lastfm): assert IN_FLIGHT dedup prevents concurrent duplicate fe…
LucasSantana-Dev a3c1abf
refactor(lastfm): tighten LastFmTrackMetadata return type to non-part…
LucasSantana-Dev e699861
fix(lastfm): log HTTP status on non-ok response + test
LucasSantana-Dev 12f4e72
fix(lastfm): add NOSONAR to artist.gettoptags URL to suppress securit…
LucasSantana-Dev 80b411d
test(lastfm): add updateNowPlaying blank-input guard tests
LucasSantana-Dev f1fdca4
Merge remote-tracking branch 'origin/release/v2.10.0' into test/suite…
LucasSantana-Dev 3cc6d50
fix(lastfm): NOSONAR S5852 on FEAT_ARTIST_SEPARATORS split regex
LucasSantana-Dev d404171
fix(lastfm): address Sonar ReDoS + Greptile P1 review findings
LucasSantana-Dev b4d4b84
fix(lastfm): address CodeRabbit review on PR #821
LucasSantana-Dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # Lucky Discord Bot: $10/Month Ads Math | ||
|
|
||
| ## Google Search: $0.33/day ($10/mo) | ||
|
|
||
| | Metric | Value | | ||
| |--------|-------| | ||
| | Monthly budget | $10 | | ||
| | Est. daily budget | $0.33 | | ||
| | Avg CPC (niche) | $0.50 | | ||
| | Clicks/month | ~20 | | ||
| | Landing page CVR (11.5%) | ~2.3 invites | | ||
| | GitHub stars (5% of visitors) | ~1 star | | ||
| | **Cost per invite** | **$4.35** | | ||
|
|
||
| --- | ||
|
|
||
| ## Platform Viability Check | ||
|
|
||
| | Platform | Min Budget | Status | | ||
| |----------|-----------|--------| | ||
| | Google Ads | $0.33/day | ✅ Viable | | ||
| | Reddit Ads | $5/day ($150/mo) | ❌ Non-viable | | ||
| | top.gg CPM | Unknown | ⚠️ Likely non-viable | | ||
| | Discord Bot Lists | Free organic | ✅ Free option exists | | ||
|
|
||
| --- | ||
|
|
||
| ## Organic Benchmark: Reddit Posts | ||
|
|
||
| To match ~2.3 monthly invites from paid ads: | ||
| - 1 well-placed r/discordservers post = ~3–5 invites (free) | ||
| - **Recommendation: Skip paid entirely; do 1 organic post instead** | ||
|
|
||
| --- | ||
|
|
||
| ## Recommendation | ||
|
|
||
| **Go $0 paid, invest in organic:** | ||
| 1. **Google Search**: $10/mo yields only 2 invites at $4.35 each — below cost-of-customer viability for a free product. | ||
| 2. **Reddit organic**: 1 monthly post in r/discordservers costs $0, lands 3–5 invites. | ||
| 3. **Best use of $10**: Save it for later when budget ≥$50–100/mo (then Google becomes 5–10 invites/mo at $1.50–2.00 per invite). | ||
|
|
||
| **Current focus:** organic + Discord Bot List free listings. | ||
52 changes: 0 additions & 52 deletions
52
packages/backend/tests/unit/middleware/asyncHandler.test.ts
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.