Skip to content

refactor(bot): split queueManipulation.ts into focused modules - #807

Merged
LucasSantana-Dev merged 8 commits into
mainfrom
refactor/queue-manipulation-split
May 5, 2026
Merged

LucasSantana-Dev merged 8 commits into
mainfrom
refactor/queue-manipulation-split

fix: address CodeRabbit review — genre error isolation, queue identit…

ad04343
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded May 5, 2026 in 55s

Annotations

Check warning on line 164 in packages/bot/src/utils/music/queueEditOps.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the "RegExp.exec()" method instead.

See more on https://sonarcloud.io/project/issues?id=LucasSantana-Dev_Lucky&issues=AZ35RR-SzlB38YErQxiV&open=AZ35RR-SzlB38YErQxiV&pullRequest=807

Check warning on line 192 in packages/bot/src/utils/music/candidateFallback.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the "RegExp.exec()" method instead.

See more on https://sonarcloud.io/project/issues?id=LucasSantana-Dev_Lucky&issues=AZ35RSEizlB38YErQxib&open=AZ35RSEizlB38YErQxib&pullRequest=807

Check warning on line 165 in packages/bot/src/utils/music/queueEditOps.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the "RegExp.exec()" method instead.

See more on https://sonarcloud.io/project/issues?id=LucasSantana-Dev_Lucky&issues=AZ35RR-SzlB38YErQxiW&open=AZ35RR-SzlB38YErQxiW&pullRequest=807

Check failure on line 144 in packages/bot/src/utils/music/candidateFallback.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=LucasSantana-Dev_Lucky&issues=AZ35pulYTLanpHURzuTd&open=AZ35pulYTLanpHURzuTd&pullRequest=807

Check warning on line 264 in packages/bot/src/utils/music/candidateFallback.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression.

See more on https://sonarcloud.io/project/issues?id=LucasSantana-Dev_Lucky&issues=AZ35RSEizlB38YErQxic&open=AZ35RSEizlB38YErQxic&pullRequest=807

Check warning on line 71 in packages/bot/src/utils/music/candidateFallback.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Async function 'collectBroadFallbackCandidates' has too many parameters (16). Maximum allowed is 7.

See more on https://sonarcloud.io/project/issues?id=LucasSantana-Dev_Lucky&issues=AZ35RSEizlB38YErQxiY&open=AZ35RSEizlB38YErQxiY&pullRequest=807

Check warning on line 92 in packages/bot/src/utils/music/trackNormalization.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`strongGenres` should be a `Set`, and use `strongGenres.has()` to check existence or non-existence.

See more on https://sonarcloud.io/project/issues?id=LucasSantana-Dev_Lucky&issues=AZ35RSEbzlB38YErQxiX&open=AZ35RSEbzlB38YErQxiX&pullRequest=807

Check failure on line 174 in packages/bot/src/utils/music/candidateFallback.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 27 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=LucasSantana-Dev_Lucky&issues=AZ35RSEizlB38YErQxia&open=AZ35RSEizlB38YErQxia&pullRequest=807

Check warning on line 234 in packages/bot/src/utils/music/queueEditOps.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression.

See more on https://sonarcloud.io/project/issues?id=LucasSantana-Dev_Lucky&issues=AZ35pufDTLanpHURzuTc&open=AZ35pufDTLanpHURzuTc&pullRequest=807