Repository navigation
feat(shared): migrate feature toggles from Unleash to Vercel Flags - #796
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
dependencies
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Rebase regenerated package-lock.json with discord.js nested under packages/bot/node_modules/, breaking the shared workspace tsc build (services and utils import discord.js types). Restored hoisting by resetting to main's lockfile and re-resolving with new top-level deps.
0a5568a to
0e1f74b
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
…olution Using main's lockfile since it already includes @vercel/flags-core and preserves the discord.js dependency hoisting needed for TypeScript type inference in GuildService.
|
) * feat: use vercel feature flags * chore: regenerate lockfile to restore discord.js hoisting Rebase regenerated package-lock.json with discord.js nested under packages/bot/node_modules/, breaking the shared workspace tsc build (services and utils import discord.js types). Restored hoisting by resetting to main's lockfile and re-resolving with new top-level deps. * chore: restore lockfile hoisting from main to fix discord.js type resolution Using main's lockfile since it already includes @vercel/flags-core and preserves the discord.js dependency hoisting needed for TypeScript type inference in GuildService.
This branch was successfully deployed
1 participant
Summary
@vercel/flags-corefor global feature flag evaluationpackages/shared/src/config/unleash.ts; addspackages/shared/src/config/vercelFlags.tswith a lazy-cachedFlagsClientdriven by aFLAGSenv varFeatureToggleServicenow resolves flags via Vercel Flags → DB guild override → config default, in that priority orderfeaturesStore,FeatureCard, andGlobalTogglesSectionupdated to consume the new toggle shapeuseFeatureshook; updates integration tests and addsFeatureToggleService.spec.tscoveragepackage-lock.jsonto restore discord.js hoisting that was broken by the new dep treeTest plan
FeatureToggleService.spec.tscovers Vercel path, DB-override path, and fallback pathtoggles.tsroute passFLAGSenv var absent → service falls back to DB/config defaults silently🤖 Generated with Claude Code