Repository navigation
docs(frontend): align DESIGN_SYSTEM.md with the dual-accent ADR - #788
Merged
Merged
Conversation
`packages/frontend/branding/BRANDING_GUIDE.md` was updated for the 2026-04-21 redesign port-target decision (#763) but the parallel `DESIGN_SYSTEM.md` was missed: - "Single accent — Discord Blurple" + "single accent" principle still read as Inter-only, blurple-only. - Typography section still listed Inter as the only font. `packages/frontend/src/index.css` already loads Sora + Manrope + JetBrains Mono at line 1 and ships both `--color-brand-discord` (`#5865f2`) and `--color-brand-accent` (`#ec4899`); the doc now matches what's actually live. Adds a brief note that the short-form `--color-*` aliases coexist with the long-form `--lucky-*` tokens during the page-port migration, with a cleanup PR queued for after the ports land — same scope as the ADR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 44 minutes and 31 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
LucasSantana-Dev
enabled auto-merge (squash)
April 25, 2026 22:49
|
Size Change: +69 B (+0.02%) Total Size: 363 kB 📦 View Changed
ℹ️ View Unchanged
|
|
LucasSantana-Dev
added a commit
that referenced
this pull request
May 13, 2026
`packages/frontend/branding/BRANDING_GUIDE.md` was updated for the 2026-04-21 redesign port-target decision (#763) but the parallel `DESIGN_SYSTEM.md` was missed: - "Single accent — Discord Blurple" + "single accent" principle still read as Inter-only, blurple-only. - Typography section still listed Inter as the only font. `packages/frontend/src/index.css` already loads Sora + Manrope + JetBrains Mono at line 1 and ships both `--color-brand-discord` (`#5865f2`) and `--color-brand-accent` (`#ec4899`); the doc now matches what's actually live. Adds a brief note that the short-form `--color-*` aliases coexist with the long-form `--lucky-*` tokens during the page-port migration, with a cleanup PR queued for after the ports land — same scope as the ADR. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/frontend/branding/DESIGN_SYSTEM.mdstill claimed "single accent — Discord Blurple" and "Inter only", contradicting the accepted ADRdocs/decisions/2026-04-21-redesign-port-target.mdand the livepackages/frontend/src/index.css(which already loads Sora/Manrope/JetBrains Mono and ships both--color-brand-discordand--color-brand-accent).BRANDING_GUIDE.mdwas updated for this in #763; this PR does the same alignment for the sibling design-system doc.Changes (single file:
packages/frontend/branding/DESIGN_SYSTEM.md)--lucky-brandrow with--color-brand-discord,--lucky-brand-strong(hover),--color-brand-accent,--color-lucky-neon-pink(alias). Adds a one-paragraph note that the short-form--color-*aliases coexist with--lucky-*during the port migration.index.cssimport list as a transitional fallback.Component rules (Button primary stays blurple, focus ring stays blurple) are unchanged — the secondary accent is reserved for highlights/gradients per the ADR.
Test plan
🤖 Generated with Claude Code