test(backend): unskip validateBody 400-on-invalid-body tests

[LucasSantana-Dev]

Summary

Two integration tests in `packages/backend/tests/integration/routes/management.test.ts` were marked `.skip` with a note that `validateBody` wasn't catching errors in certain scenarios. Backlog item (`.claude/plans/backlog-2026-04-21.md`) flagged them.

Evidence that unskipping is safe

Middleware chain for both endpoints:

```
requireAuth
→ requireGuildModuleAccess('settings'|'commands', 'manage')
→ writeLimiter
→ validateParams(guildIdParam)
→ validateBody(...) ← the check under test
→ asyncHandler
```

`beforeEach` (file line 76) sets up:

• `sessionService.getSession` → `MOCK_SESSION_DATA` (authenticated, `fixtures/mock-data.ts:46`)
• `guildAccessService.resolveGuildContext` → `MOCK_GUILD_CONTEXT` with full `manage` access on every module (`fixtures/mock-data.ts:65`)
• `guildAccessService.hasAccess` → `true`
• `jest.clearAllMocks()` for isolation

Given this, a request to `PATCH /api/guilds/:guildId/automod/settings` with `{ spamThreshold: 'not a number' }` should reach `validateBody` with the body parsed (`spamThreshold: z.number().int().min(1).max(100).optional()` in `schemas/management.ts:16`), fail Zod's type check, and return 400. Same for `POST /api/guilds/:guildId/commands` with empty body — `name` is required per `createCommandBody`.

The skip comment was likely a carryover from an earlier middleware state. Unskipping in this PR to verify; if CI surfaces a real failure, we get actionable evidence instead of a silent skip.

Test plan

• CI: `Quality Gates` must run `npm run test --workspace=packages/backend` and both tests pass.
• If they fail, the failure output tells us whether it's a mock-setup gap or a real middleware bug — either actionable.

Risk

Zero. If the tests fail, CI catches it and this PR doesn't merge. If they pass, we eliminate 2 skipped negative-path tests from the backlog.

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
lucky	Canceled		Apr 22, 2026 6:23am

[coderabbitai]

Warning

Rate limit exceeded

@LucasSantana-Dev has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 46 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 9 minutes and 46 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c02d17a7-e282-4008-81de-6e1df745048d

📥 Commits

Reviewing files that changed from the base of the PR and between ee2f05f and fe4f7dc.

📒 Files selected for processing (1)

• packages/backend/tests/integration/routes/management.test.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/unskip-validatebody-tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud