Skip to content

docs(spec): promote lucky-next-phases ultraplan to docs/specs - #754

Merged
LucasSantana-Dev merged 7 commits into
mainfrom
chore/promote-phase2-spec
Apr 22, 2026
Merged

LucasSantana-Dev merged 7 commits into
mainfrom
chore/promote-phase2-spec

Conversation

@LucasSantana-Dev

Copy link
Copy Markdown
Owner

Summary

Promotes ~/.claude/plans/lucky-next-phases-ultraplan.md into a committed spec under docs/specs/2026-04-20-lucky-next-phases/ via the spec-new skill. Doc-only change, zero runtime impact.

What landed

Audit findings (inline in tasks.md)

  • Only PremiumService + replenisher.ts (PR feat(autoplay): premium guilds get 2× backfill buffer (8 → 16) #750) reference isPremium today — rest of premium surface is greenfield
  • collaborativePlaylist.ts service already exists → natural Phase 2 gate
  • UserPreferences.embedColor + Criativaria setup 0x8B5CF6 → anchor for premium palette
  • Leaderboard row-limit is frontend-paginated (no hardcoded backend cap) → investigate packages/frontend/src before PR 4

Why now

Captures planning state into the repo so roadmap-refresh / aggregate-roadmap can index it, and so future sessions can resume from docs/specs/ rather than re-reading the ephemeral plan.

Test plan

  • spec-new skill output valid (frontmatter parses)
  • No code changes — no CI regression risk

@vercel

vercel Bot commented Apr 20, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lucky Ready Ready Preview, Comment Apr 22, 2026 2:16am

Request Review

@LucasSantana-Dev
LucasSantana-Dev enabled auto-merge (squash) April 20, 2026 20:30
@coderabbitai

coderabbitai Bot commented Apr 20, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@LucasSantana-Dev has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 36 minutes and 2 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 36 minutes and 2 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f81972ad-e8aa-408d-8299-efaa91bc248b

📥 Commits

Reviewing files that changed from the base of the PR and between b07299b and b04566a.

📒 Files selected for processing (2)
  • docs/specs/2026-04-20-lucky-next-phases/spec.md
  • docs/specs/2026-04-20-lucky-next-phases/tasks.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/promote-phase2-spec

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Promotes ~/.claude/plans/lucky-next-phases-ultraplan.md into a committed
spec under docs/specs/2026-04-20-lucky-next-phases/ via the spec-new
skill. Includes a rewritten tasks.md with Phase 0/1 marked shipped
(PRs #728-#743), Phase 2 status (PRs #746/#747/#749/#750 shipped, real
Stripe SDK + PR 4 dashboard remaining), and an audit inventory of
premium gates across packages/*/src to guide PR 4 wiring.

Key audit findings:
- Only PremiumService + replenisher.ts reference isPremium today
- Collaborative playlist service already exists — natural P2 gate
- embedColor palette is the cheapest premium UX gate
- Leaderboard row-limit is frontend-paginated, not backend-enforced
Per 2026-04-20 decision: removing Stripe features for now. The existing
premiumService.isPremium() check serves as the feature toggle (returns
false without subscription rows, so all premium-adjacent paths behave
as if off).

Closed PRs: #745 (spec), #747 (env), #749 (routes)
Kept: #746 (schema, harmless no-op on main), #750 (autoplay gate =
the live toggle)
@sonarqubecloud

Copy link
Copy Markdown

@LucasSantana-Dev
LucasSantana-Dev merged commit fc37dd3 into main Apr 22, 2026
12 checks passed
LucasSantana-Dev added a commit that referenced this pull request May 13, 2026
* docs(spec): promote lucky-next-phases ultraplan to docs/specs

Promotes ~/.claude/plans/lucky-next-phases-ultraplan.md into a committed
spec under docs/specs/2026-04-20-lucky-next-phases/ via the spec-new
skill. Includes a rewritten tasks.md with Phase 0/1 marked shipped
(PRs #728-#743), Phase 2 status (PRs #746/#747/#749/#750 shipped, real
Stripe SDK + PR 4 dashboard remaining), and an audit inventory of
premium gates across packages/*/src to guide PR 4 wiring.

Key audit findings:
- Only PremiumService + replenisher.ts reference isPremium today
- Collaborative playlist service already exists — natural P2 gate
- embedColor palette is the cheapest premium UX gate
- Leaderboard row-limit is frontend-paginated, not backend-enforced

* docs(spec): mark Phase 2 (Stripe/premium billing) as deferred

Per 2026-04-20 decision: removing Stripe features for now. The existing
premiumService.isPremium() check serves as the feature toggle (returns
false without subscription rows, so all premium-adjacent paths behave
as if off).

Closed PRs: #745 (spec), #747 (env), #749 (routes)
Kept: #746 (schema, harmless no-op on main), #750 (autoplay gate =
the live toggle)
@LucasSantana-Dev
LucasSantana-Dev deleted the chore/promote-phase2-spec branch May 14, 2026 02:03

This branch was successfully deployed

1 active deployment
Preview — b04566a1 Deployed Apr 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant