Repository navigation
fix(autoplay): replenish queue on exhaustion + suppress recovery on stale snapshot - #691
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 11 minutes and 25 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
dependencies
…tale snapshot Root causes of autoplay regression: 1. Queue exhaustion during autoplay: emptyQueue event marked as intentional stop but didn't attempt replenishment. Now attempts replenish when autoplay is enabled and currentTrack exists. 2. Skip on last track → disconnect → watchdog rejoin: When queue emptied after skip/finish, no protection prevented watchdog orphan recovery from immediately rejecting. Added setReplenishSuppressed(35s) to prevent recovery until idle timeout fires. 3. Watchdog restores stale snapshot: restoreSnapshot had skipCurrentTrack but upcomingTracks[0] could still be the just-played song. Added clearSnapshotIfStale() to delete snapshot when only currentTrack exists (queue was drained). Changes: - lifecycleHandlers.ts: emptyQueue now calls replenishQueue instead of markIntentionalStop when autoplay is enabled - trackHandlers.ts: added setReplenishSuppressed(35s) + clearSnapshotIfStale() when queue becomes empty after skip/finish - sessionSnapshots.ts: added clearSnapshotIfStale() helper to clean stale snapshots - replenisher.ts: improved debug logging for exhausted candidate pool - lifecycleHandlers.spec.ts: added tests for emptyQueue autoplay replenishment - trackHandlers.spec.ts: added mocks for replenishSuppressionStore and clearSnapshotIfStale Integration: No behavior changes outside the 3 symptoms. All existing tests green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
LucasSantana-Dev
force-pushed
the
fix/autoplay-repeat-regression
branch
from
April 17, 2026 17:43
e6f2a41 to
4609f9b
Compare
LucasSantana-Dev
enabled auto-merge (squash)
April 17, 2026 17:43
github-actions
Bot
added
size/m
and removed
dependencies
- Create queueExhaustion.ts with shared handleQueueExhaustion function - Refactor handlePlayerFinish and handlePlayerSkip to use shared handler - Add unit tests for queueExhaustion module - Reduces code duplication between finish and skip event handlers - Maintains all existing behavior with 2735 tests passing
Adds 8 tests for redis error swallowing, missing key, clearStaleIfStale no-ops, restoreSnapshot guards. Coverage 78.20% → 91.02% lines / 70.49% → 83.60% branches.
|
LucasSantana-Dev
added a commit
that referenced
this pull request
May 13, 2026
…tale snapshot (#691) * fix(autoplay): replenish queue on exhaustion + suppress recovery on stale snapshot Root causes of autoplay regression: 1. Queue exhaustion during autoplay: emptyQueue event marked as intentional stop but didn't attempt replenishment. Now attempts replenish when autoplay is enabled and currentTrack exists. 2. Skip on last track → disconnect → watchdog rejoin: When queue emptied after skip/finish, no protection prevented watchdog orphan recovery from immediately rejecting. Added setReplenishSuppressed(35s) to prevent recovery until idle timeout fires. 3. Watchdog restores stale snapshot: restoreSnapshot had skipCurrentTrack but upcomingTracks[0] could still be the just-played song. Added clearSnapshotIfStale() to delete snapshot when only currentTrack exists (queue was drained). Changes: - lifecycleHandlers.ts: emptyQueue now calls replenishQueue instead of markIntentionalStop when autoplay is enabled - trackHandlers.ts: added setReplenishSuppressed(35s) + clearSnapshotIfStale() when queue becomes empty after skip/finish - sessionSnapshots.ts: added clearSnapshotIfStale() helper to clean stale snapshots - replenisher.ts: improved debug logging for exhausted candidate pool - lifecycleHandlers.spec.ts: added tests for emptyQueue autoplay replenishment - trackHandlers.spec.ts: added mocks for replenishSuppressionStore and clearSnapshotIfStale Integration: No behavior changes outside the 3 symptoms. All existing tests green. * refactor: extract duplicate queue exhaustion logic into shared handler - Create queueExhaustion.ts with shared handleQueueExhaustion function - Refactor handlePlayerFinish and handlePlayerSkip to use shared handler - Add unit tests for queueExhaustion module - Reduces code duplication between finish and skip event handlers - Maintains all existing behavior with 2735 tests passing * test(autoplay): cover sessionSnapshots error paths and edge cases Adds 8 tests for redis error swallowing, missing key, clearStaleIfStale no-ops, restoreSnapshot guards. Coverage 78.20% → 91.02% lines / 70.49% → 83.60% branches. --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed critical autoplay regression affecting three symptoms:
Root Causes
emptyQueueevent marked stop but didn't replenish during autoplayskipCurrentTrackbut upcomingTracks[0] could still be the just-played songChanges
emptyQueuenow callsreplenishQueuewhen autoplay enabled + currentTrack existssetReplenishSuppressed(35s)+clearSnapshotIfStale()when queue becomes emptyclearSnapshotIfStale()helper to delete stale snapshots (drained queue)Test Plan
Fixes: Queue stall, unexpected disconnect, unwanted rejoin with stale track
🤖 Generated with Claude Code