Skip to content

feat(bot): autoplay artist prefer/block preferences #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LucasSantana-Dev merged 7 commits into from
Apr 12, 2026
Merged

feat(bot): autoplay artist prefer/block preferences #572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ecd23dd
feat(bot): add artist-level feedback methods to feedbackService
LucasSantana-Dev Apr 12, 2026
1aef6fb
feat(bot): wire artist preferences into autoplay scoring
LucasSantana-Dev Apr 12, 2026
80b51fd
feat: add /autoplay artist subcommand for managing artist preferences
LucasSantana-Dev Apr 12, 2026
5b81a6b
test(bot): add artist preference tests for feedback and autoplay
LucasSantana-Dev Apr 12, 2026
38e02f6
test(bot): add artist key mocks and fix conflict resolution
LucasSantana-Dev Apr 12, 2026
efbfa00
fix(bot): add missing artist feedback methods and test coverage
LucasSantana-Dev Apr 12, 2026
304bf59
test(bot): cover artist handler error paths and default case
LucasSantana-Dev Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 9 additions & 20 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

153 changes: 152 additions & 1 deletion packages/bot/src/functions/music/commands/autoplay.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ const debugLogMock = jest.fn()
const errorLogMock = jest.fn()
const resolveGuildQueueMock = jest.fn()
const trackHistoryServiceMock = jest.fn()
const setArtistFeedbackMock = jest.fn()
const removeArtistFeedbackMock = jest.fn()
const getArtistFeedbackSummaryMock = jest.fn()

jest.mock('../../../utils/general/interactionReply', () => ({
interactionReply: (...args: unknown[]) => interactionReplyMock(...args),
Expand Down Expand Up @@ -59,6 +62,17 @@ jest.mock('@lucky/shared/services', () => ({
},
}))

jest.mock('../../../services/musicRecommendation/feedbackService', () => ({
recommendationFeedbackService: {
setArtistFeedback: (...args: unknown[]) =>
setArtistFeedbackMock(...args),
removeArtistFeedback: (...args: unknown[]) =>
removeArtistFeedbackMock(...args),
getArtistFeedbackSummary: (...args: unknown[]) =>
getArtistFeedbackSummaryMock(...args),
},
}))

function createInteraction(
subcommand = 'skip',
subcommandGroup: string | null = null,
Expand Down Expand Up @@ -595,6 +609,143 @@ describe('autoplay command', () => {
})
})

describe('artist subcommand group', () => {
beforeEach(() => {
setArtistFeedbackMock.mockResolvedValue(undefined)
removeArtistFeedbackMock.mockResolvedValue(undefined)
getArtistFeedbackSummaryMock.mockResolvedValue({
preferred: [],
blocked: [],
})
})

function createArtistInteraction(subcommand: string, artist?: string) {
const interaction = {
guildId: 'guild-1',
deferred: false,
replied: false,
user: { id: 'user-1' },
deferReply: jest.fn(async () => {
interaction.deferred = true
}),
options: {
getSubcommand: jest.fn(() => subcommand),
getSubcommandGroup: jest.fn(() => 'artist'),
getString: jest.fn(() => artist ?? null),
},
}
return interaction as any
}

it('artist prefer — marks artist as preferred', async () => {
const interaction = createArtistInteraction('prefer', 'The Beatles')
const client = createClient()
resolveGuildQueueMock.mockReturnValue({ queue: null })
await autoplayCommand.execute({ client, interaction } as any)
expect(setArtistFeedbackMock).toHaveBeenCalledWith(
'guild-1',
'user-1',
'The Beatles',
'prefer',
)
expect(createEmbedMock).toHaveBeenCalledWith(
expect.objectContaining({
title: expect.stringContaining('Preferred'),
}),
)
})

it('artist block — blocks artist from autoplay', async () => {
const interaction = createArtistInteraction('block', 'Artist X')
const client = createClient()
resolveGuildQueueMock.mockReturnValue({ queue: null })
await autoplayCommand.execute({ client, interaction } as any)
expect(setArtistFeedbackMock).toHaveBeenCalledWith(
'guild-1',
'user-1',
'Artist X',
'block',
)
})

it('artist remove — removes preference', async () => {
const interaction = createArtistInteraction('remove', 'The Beatles')
const client = createClient()
resolveGuildQueueMock.mockReturnValue({ queue: null })
await autoplayCommand.execute({ client, interaction } as any)
expect(removeArtistFeedbackMock).toHaveBeenCalledWith(
'guild-1',
'user-1',
'The Beatles',
)
})

it('artist list — shows preferences', async () => {
const interaction = createArtistInteraction('list')
const client = createClient()
resolveGuildQueueMock.mockReturnValue({ queue: null })
await autoplayCommand.execute({ client, interaction } as any)
expect(createEmbedMock).toHaveBeenCalledWith(
expect.objectContaining({
title: expect.stringContaining('Preferences'),
}),
)
})

it('artist prefer — shows error when no artist name', async () => {
const interaction = createArtistInteraction('prefer', undefined)
const client = createClient()
resolveGuildQueueMock.mockReturnValue({ queue: null })
await autoplayCommand.execute({ client, interaction } as any)
expect(createErrorEmbedMock).toHaveBeenCalledWith(
'Missing Input',
expect.any(String),
)
})

it('artist block — shows error when no artist name', async () => {
const interaction = createArtistInteraction('block', undefined)
const client = createClient()
resolveGuildQueueMock.mockReturnValue({ queue: null })
await autoplayCommand.execute({ client, interaction } as any)
expect(createErrorEmbedMock).toHaveBeenCalledWith(
'Missing Input',
expect.any(String),
)
})

it('artist remove — shows error when no artist name', async () => {
const interaction = createArtistInteraction('remove', undefined)
const client = createClient()
resolveGuildQueueMock.mockReturnValue({ queue: null })
await autoplayCommand.execute({ client, interaction } as any)
expect(createErrorEmbedMock).toHaveBeenCalledWith(
'Missing Input',
expect.any(String),
)
})

it('artist prefer — handles service error gracefully', async () => {
setArtistFeedbackMock.mockRejectedValue(new Error('Redis down'))
const interaction = createArtistInteraction('prefer', 'The Beatles')
const client = createClient()
resolveGuildQueueMock.mockReturnValue({ queue: null })
await autoplayCommand.execute({ client, interaction } as any)
expect(createErrorEmbedMock).toHaveBeenCalledWith(
'Error',
expect.any(String),
)
})

it('artist unknown subcommand — shows error', async () => {
const interaction = createArtistInteraction('unknown')
const client = createClient()
resolveGuildQueueMock.mockReturnValue({ queue: null })
await autoplayCommand.execute({ client, interaction } as any)
expect(interactionReplyMock).toHaveBeenCalled()
})
})

describe('execute function edge cases', () => {
it('should return early when guildId is null', async () => {
const interaction = createInteraction('skip')
Expand Down Expand Up @@ -623,7 +774,7 @@ describe('autoplay command', () => {

expect(createErrorEmbedMock).toHaveBeenCalledWith(
'Unknown Subcommand',
'Please use skip, clear, status, analytics, mode, or genre.',
'Please use skip, clear, status, analytics, or mode.',
)
expect(interactionReplyMock).toHaveBeenCalled()
})
Expand Down
Loading