Skip to content

test(bot): add interactionReply assertions to session command error paths - #528

Merged
LucasSantana-Dev merged 2 commits into
mainfrom
fix/false-positive-tests
Apr 10, 2026
Merged

LucasSantana-Dev merged 2 commits into
mainfrom
fix/false-positive-tests

Conversation

@LucasSantana-Dev

@LucasSantana-Dev LucasSantana-Dev commented Apr 10, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Adds interactionReplyMock assertions to 4 error-path tests in session.spec.ts that were passing without verifying the user actually received a response
  • Covers: delete success, delete not found, restore not found, and voice connection failure paths

Test plan

  • All 1804 bot tests pass
  • CI green

Summary by CodeRabbit

Release v2.6.71

  • New Features

    • Added queue controls: /playtop, /playskip, /skipto, /seek, /replay, /leavecleanup, /nowplaying
    • Introduced audio effects: /effects bassboost, /effects nightcore, /effects reset
    • Added moderation commands: /purge, /lockdown, /slowmode, /autorole management
    • Added giveaway management: /giveaway start, end, and reroll options
  • Updates

    • /pause now toggles play/pause (/resume removed)
    • /volume range extended to 1–200
    • /play accepts optional provider parameter (spotify, youtube, soundcloud)
    • Autoplay defaults to ON for new servers with cross-session deduplication

Bump versions, update CHANGELOG and IMPLEMENTATION_STATUS to reflect
all features shipped in PRs #520–#526: music commands (playtop, playskip,
skipto, seek, replay, leavecleanup, nowplaying alias, effects, volume 1-200,
pause toggle, provider param), moderation (purge, lockdown, slowmode),
and management (autorole, giveaway, autoplay default-on + dedup).
…aths

- Add missing assertions for delete, restore, and connection error paths
- Verify ephemeral flag is set on error responses
- Catch false positives in session error handling
@vercel

vercel Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lucky Ready Ready Preview, Comment Apr 10, 2026 5:59pm

Request Review

@github-actions github-actions Bot added dependencies Pull requests that update a dependency file bot backend frontend shared labels Apr 10, 2026
@coderabbitai

coderabbitai Bot commented Apr 10, 2026 •

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This is a patch version release (2.6.70 → 2.6.71) that updates all package.json files and documentation. CHANGELOG.md and IMPLEMENTATION_STATUS.md are updated to reflect new Discord slash commands including music controls, audio effects, moderation tools, and giveaway features. Test assertions are enhanced for ephemeral reply validation.

Changes

Cohort / File(s) Summary
Version Bump
package.json, packages/backend/package.json, packages/bot/package.json, packages/frontend/package.json, packages/shared/package.json
Version updated from 2.6.70 to 2.6.71 across all package manifests.
Documentation Updates
CHANGELOG.md, docs/IMPLEMENTATION_STATUS.md
Added version 2.6.71 changelog entry documenting new commands (music queue controls, audio effects via FFmpeg, moderation, giveaways), behavior changes (autoplay default ON, /resume removed), and extended /volume and /play parameters. Updated implementation status with new command listings and future work areas (DJ roles, auto-disconnect, vote skip, queue history).
Test Improvements
packages/bot/src/functions/music/commands/session.spec.ts
Enhanced assertions to validate ephemeral reply structure in session command scenarios (delete, restore, and error cases).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested labels

bot, size/s

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately reflects the main change: adding interactionReply assertions to session command error paths, which is the primary focus of the meaningful code change in the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/false-positive-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 324 kB

ℹ️ View Unchanged
Filename Size
packages/frontend/dist/assets/ActionPanel-DNyixsRN.js 400 B
packages/frontend/dist/assets/api-DsLAIu-l.js 2.9 kB
packages/frontend/dist/assets/authStore-Bo_PbbZd.js 557 B
packages/frontend/dist/assets/AutoMessages-CMx6p29r.js 2.69 kB
packages/frontend/dist/assets/AutoMod-H-4xwkmt.js 4.09 kB
packages/frontend/dist/assets/avatar-BYVlC9R1.js 1.79 kB
packages/frontend/dist/assets/badge-kekZ5uai.js 498 B
packages/frontend/dist/assets/Button-Chq_jJX6.js 766 B
packages/frontend/dist/assets/Card-DY7pU8Q5.js 457 B
packages/frontend/dist/assets/chunk-QFMPRPBF-ySVqcpZB.js 14.8 kB
packages/frontend/dist/assets/CommandsConfig-D5HhVE8J.js 1.49 kB
packages/frontend/dist/assets/Config-D0yyrS5J.js 1.74 kB
packages/frontend/dist/assets/CustomCommands-D6roNyDQ.js 2.15 kB
packages/frontend/dist/assets/DashboardOverview-B7ZvaNvW.js 3.42 kB
packages/frontend/dist/assets/dialog-DCGuWOQz.js 949 B
packages/frontend/dist/assets/dist-Bzdj1j8i.js 416 B
packages/frontend/dist/assets/EmbedBuilder-Rq0Aksdt.js 3.35 kB
packages/frontend/dist/assets/EmptyState-D-FW84dc.js 432 B
packages/frontend/dist/assets/Features-CWZ4j0-1.js 2.85 kB
packages/frontend/dist/assets/GuildAutomation-K29WisHS.js 2.94 kB
packages/frontend/dist/assets/guildStore-D5pntH7c.js 791 B
packages/frontend/dist/assets/index-BvzPtzfc.js 11.7 kB
packages/frontend/dist/assets/index-DoLe_VYd.css 14.4 kB
packages/frontend/dist/assets/input-B8xLKRen.js 465 B
packages/frontend/dist/assets/label-9gyU3CvE.js 485 B
packages/frontend/dist/assets/LastFm-rG5GrbYY.js 1.74 kB
packages/frontend/dist/assets/Levels-DLo4t0Rt.js 2.65 kB
packages/frontend/dist/assets/Login-C5vaBplo.js 2.54 kB
packages/frontend/dist/assets/Lyrics-C6bZmDoy.js 1.33 kB
packages/frontend/dist/assets/Moderation-Ceej5Axm.js 3.87 kB
packages/frontend/dist/assets/Music-DwHM3KDy.js 6.17 kB
packages/frontend/dist/assets/MusicConfig-BkgUtXsR.js 1.62 kB
packages/frontend/dist/assets/PrivacyPolicy-BMYU-0jY.js 1.38 kB
packages/frontend/dist/assets/rbac-BN1DzQHh.js 152 B
packages/frontend/dist/assets/ReactionRoles-D-ubvLwR.js 1.9 kB
packages/frontend/dist/assets/rolldown-runtime-COnpUsM8.js 467 B
packages/frontend/dist/assets/scroll-area-C8T6RLOh.js 522 B
packages/frontend/dist/assets/SectionHeader-C0yb_DFu.js 385 B
packages/frontend/dist/assets/select-CHLbPSDw.js 1.23 kB
packages/frontend/dist/assets/ServerLogs-BtUuCMku.js 2.9 kB
packages/frontend/dist/assets/ServerSettings-4VsKJdYy.js 4.22 kB
packages/frontend/dist/assets/ServersPage-CLyZtYdk.js 2.95 kB
packages/frontend/dist/assets/Skeleton-Z9dBUKZD.js 236 B
packages/frontend/dist/assets/Starboard-xddi8bqd.js 2.09 kB
packages/frontend/dist/assets/StatTile-DI0Q4bgV.js 606 B
packages/frontend/dist/assets/switch-nhTZOPm5.js 543 B
packages/frontend/dist/assets/TermsOfService-SB9iOf3u.js 1.37 kB
packages/frontend/dist/assets/TrackHistory-Brg7jkn6.js 1.91 kB
packages/frontend/dist/assets/TwitchNotifications-BrtUbdEd.js 2.29 kB
packages/frontend/dist/assets/useGuildSelection-CNWhdqGT.js 488 B
packages/frontend/dist/assets/usePageMetadata-C6uKjjUo.js 325 B
packages/frontend/dist/assets/utils-ayWzbeKE.js 148 B
packages/frontend/dist/assets/vendor-forms-DmZCnE0r.js 25.4 kB
packages/frontend/dist/assets/vendor-radix-DyTfqI7p.js 33.5 kB
packages/frontend/dist/assets/vendor-react-DlFk5rSD.js 55.6 kB
packages/frontend/dist/assets/vendor-state-1dKZOhDf.js 22.2 kB
packages/frontend/dist/assets/vendor-ui-B32-89km.js 64.2 kB

compressed-size-action

@sonarqubecloud

Copy link
Copy Markdown

@LucasSantana-Dev
LucasSantana-Dev merged commit 21bc8f7 into main Apr 10, 2026
12 of 13 checks passed
LucasSantana-Dev added a commit that referenced this pull request May 13, 2026
…aths (#528)

* chore(release): v2.6.71

Bump versions, update CHANGELOG and IMPLEMENTATION_STATUS to reflect
all features shipped in PRs #520–#526: music commands (playtop, playskip,
skipto, seek, replay, leavecleanup, nowplaying alias, effects, volume 1-200,
pause toggle, provider param), moderation (purge, lockdown, slowmode),
and management (autorole, giveaway, autoplay default-on + dedup).

* test(bot): add interactionReply assertions to session command error paths

- Add missing assertions for delete, restore, and connection error paths
- Verify ephemeral flag is set on error responses
- Catch false positives in session error handling

This branch was successfully deployed

1 active deployment
Preview — 174e828a Deployed Apr 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant