Skip to content

feat(bot): implement role create and delete audit log handlers #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LucasSantana-Dev merged 3 commits into from
Mar 30, 2026
Merged

feat(bot): implement role create and delete audit log handlers #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a74249
feat(bot): implement role create and delete audit log handlers
LucasSantana-Dev Mar 30, 2026
342a83d
refactor(bot): extract shared role event handler to reduce duplication
LucasSantana-Dev Mar 30, 2026
266d0e5
Merge remote-tracking branch 'origin/main' into feat/role-audit-events
LucasSantana-Dev Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
294 changes: 294 additions & 0 deletions packages/bot/src/handlers/auditHandler.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,14 @@
Events.ChannelDelete,
expect.any(Function),
)
expect(client.on).toHaveBeenCalledWith(
Events.GuildRoleCreate,
expect.any(Function),
)
expect(client.on).toHaveBeenCalledWith(
Events.GuildRoleDelete,
expect.any(Function),
)
})
})

Expand Down Expand Up @@ -697,5 +705,291 @@
error: expect.any(Error),
})
})

it('should catch and log errors from GuildRoleCreate handler', async () => {
const role = {
id: 'role-1',
guild: { id: 'guild-1' },
} as any

;(featureToggleService.isEnabled as jest.Mock).mockRejectedValue(
new Error('Service error'),
)

handleAuditEvents(client as any)
await triggerEvent(client, Events.GuildRoleCreate, role)

expect(errorLog).toHaveBeenCalledWith({
message: 'Error in role create handler:',
error: expect.any(Error),
})
})

it('should catch and log errors from GuildRoleDelete handler', async () => {
const role = {
id: 'role-1',
guild: { id: 'guild-1' },
} as any

;(featureToggleService.isEnabled as jest.Mock).mockRejectedValue(
new Error('Service error'),
)

handleAuditEvents(client as any)
await triggerEvent(client, Events.GuildRoleDelete, role)

expect(errorLog).toHaveBeenCalledWith({
message: 'Error in role delete handler:',
error: expect.any(Error),
})
})
})

describe('GuildRoleCreate event', () => {
it('should log role creation with audit log data', async () => {
const firstEntry = {
executor: { id: 'mod-1' },
} as unknown as GuildAuditLogsEntry

const mockAuditLog = {
entries: {
first: jest.fn().mockReturnValue(firstEntry),
},
}

const role = {
id: 'role-1',
name: 'Moderator',
color: 0x00ff00,
permissions: { bitfield: BigInt(8) },
guild: {
id: 'guild-1',
name: 'Test Guild',
fetchAuditLogs: jest.fn().mockResolvedValue(mockAuditLog),
},
} as unknown as Role

handleAuditEvents(client as any)
await triggerEvent(client, Events.GuildRoleCreate, role)

expect(serverLogService.createLog).toHaveBeenCalledWith(
'guild-1',
'role_update',
'Role created',
{
roleId: 'role-1',
roleName: 'Moderator',
color: 0x00ff00,
permissions: '8',
},
{
moderatorId: 'mod-1',
},
)
expect(debugLog).toHaveBeenCalledWith({
message: 'Logged role created in Test Guild',
})
})

it('should not log when feature is disabled', async () => {
;(featureToggleService.isEnabled as jest.Mock).mockResolvedValue(
false,
)

const role = {
id: 'role-1',
name: 'Test Role',
guild: {
id: 'guild-1',
},
} as unknown as Role

handleAuditEvents(client as any)
await triggerEvent(client, Events.GuildRoleCreate, role)

expect(serverLogService.createLog).not.toHaveBeenCalled()
})

it('should handle missing audit log gracefully', async () => {
const role = {
id: 'role-1',
name: 'Test Role',
color: 0xff0000,
permissions: { bitfield: BigInt(0) },
guild: {
id: 'guild-1',
name: 'Test Guild',
fetchAuditLogs: jest.fn().mockRejectedValue(new Error()),

Check warning on line 822 in packages/bot/src/handlers/auditHandler.spec.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Pass a message to the `Error` constructor. 


See more on https://sonarcloud.io/project/issues?id=LucasSantana-Dev_Nexus&issues=AZ1AYDlXgLsdgtcohW96&open=AZ1AYDlXgLsdgtcohW96&pullRequest=388
},
} as unknown as Role

handleAuditEvents(client as any)
await triggerEvent(client, Events.GuildRoleCreate, role)

expect(serverLogService.createLog).toHaveBeenCalledWith(
'guild-1',
'role_update',
'Role created',
expect.objectContaining({
roleId: 'role-1',
roleName: 'Test Role',
}),
expect.objectContaining({
moderatorId: undefined,
}),
)
})

it('should handle errors during logging', async () => {
;(serverLogService.createLog as jest.Mock).mockRejectedValue(
new Error('DB error'),
)

const role = {
id: 'role-1',
name: 'Test Role',
color: 0,
permissions: { bitfield: BigInt(0) },
guild: {
id: 'guild-1',
name: 'Test Guild',
fetchAuditLogs: jest.fn().mockResolvedValue({
entries: { first: jest.fn().mockReturnValue(null) },
}),
},
} as unknown as Role

handleAuditEvents(client as any)
await triggerEvent(client, Events.GuildRoleCreate, role)

expect(errorLog).toHaveBeenCalledWith({
message: 'Error logging role created:',
error: expect.any(Error),
})
})
})

describe('GuildRoleDelete event', () => {
it('should log role deletion with audit log data', async () => {
const firstEntry = {
executor: { id: 'mod-1' },
} as unknown as GuildAuditLogsEntry

const mockAuditLog = {
entries: {
first: jest.fn().mockReturnValue(firstEntry),
},
}

const role = {
id: 'role-1',
name: 'Spammer',
color: 0xff0000,
permissions: { bitfield: BigInt(0) },
guild: {
id: 'guild-1',
name: 'Test Guild',
fetchAuditLogs: jest.fn().mockResolvedValue(mockAuditLog),
},
} as unknown as Role

handleAuditEvents(client as any)
await triggerEvent(client, Events.GuildRoleDelete, role)

expect(serverLogService.createLog).toHaveBeenCalledWith(
'guild-1',
'role_update',
'Role deleted',
{
roleId: 'role-1',
roleName: 'Spammer',
color: 0xff0000,
permissions: '0',
},
{
moderatorId: 'mod-1',
},
)
expect(debugLog).toHaveBeenCalledWith({
message: 'Logged role deleted in Test Guild',
})
})

it('should not log when feature is disabled', async () => {
;(featureToggleService.isEnabled as jest.Mock).mockResolvedValue(
false,
)

const role = {
id: 'role-1',
name: 'Test Role',
guild: {
id: 'guild-1',
},
} as unknown as Role

handleAuditEvents(client as any)
await triggerEvent(client, Events.GuildRoleDelete, role)

expect(serverLogService.createLog).not.toHaveBeenCalled()
})

it('should handle missing audit log gracefully', async () => {
const role = {
id: 'role-1',
name: 'Old Role',
color: 0x0000ff,
permissions: { bitfield: BigInt(16) },
guild: {
id: 'guild-1',
name: 'Test Guild',
fetchAuditLogs: jest.fn().mockRejectedValue(new Error()),

Check warning on line 946 in packages/bot/src/handlers/auditHandler.spec.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Pass a message to the `Error` constructor. 


See more on https://sonarcloud.io/project/issues?id=LucasSantana-Dev_Nexus&issues=AZ1AYDlXgLsdgtcohW97&open=AZ1AYDlXgLsdgtcohW97&pullRequest=388
},
} as unknown as Role

handleAuditEvents(client as any)
await triggerEvent(client, Events.GuildRoleDelete, role)

expect(serverLogService.createLog).toHaveBeenCalledWith(
'guild-1',
'role_update',
'Role deleted',
expect.objectContaining({
roleId: 'role-1',
roleName: 'Old Role',
}),
expect.objectContaining({
moderatorId: undefined,
}),
)
})

it('should handle errors during logging', async () => {
;(serverLogService.createLog as jest.Mock).mockRejectedValue(
new Error('DB error'),
)

const role = {
id: 'role-1',
name: 'Test Role',
color: 0,
permissions: { bitfield: BigInt(0) },
guild: {
id: 'guild-1',
name: 'Test Guild',
fetchAuditLogs: jest.fn().mockResolvedValue({
entries: { first: jest.fn().mockReturnValue(null) },
}),
},
} as unknown as Role

handleAuditEvents(client as any)
await triggerEvent(client, Events.GuildRoleDelete, role)

expect(errorLog).toHaveBeenCalledWith({
message: 'Error logging role deleted:',
error: expect.any(Error),
})
})
})
})
Loading
Loading