Repository navigation
test(frontend): cover guild automation route access - #366
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughAdded and adjusted frontend tests: a new authenticated-route test for Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: +2 B (0%) Total Size: 317 kB
ℹ️ View Unchanged
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
packages/frontend/src/components/Layout/Sidebar.test.tsx (1)
415-417: UseString.rawto avoid escaping the backslash.The escaped
\\:in the selector can be simplified using a tagged template literal.✨ Suggested refactor
const mobileSidebar = document.querySelector( - 'aside.fixed.inset-y-0.left-0.z-50.w-64.bg-lucky-bg-secondary.lg\\:hidden', + String.raw`aside.fixed.inset-y-0.left-0.z-50.w-64.bg-lucky-bg-secondary.lg\:hidden`, )🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/frontend/src/components/Layout/Sidebar.test.tsx` around lines 415 - 417, The selector string passed to document.querySelector in the mobileSidebar assignment currently escapes the colon with `\\:`, which is unnecessary; replace the plain string with a raw template using String.raw to avoid backslash escaping (e.g., use String.raw`...` for the selector) so the `lg\:` segment is written as `lg\:` without double-escaping; update the expression where mobileSidebar is assigned (the document.querySelector call) accordingly.packages/frontend/src/components/Dashboard/ServerCard.test.tsx (1)
76-92: Remove Tailwind class assertions from status badge tests.Lines 82 and 91 assert CSS utility classes (
bg-lucky-success/10,bg-lucky-error/10), making tests brittle to styling-only refactors. The tests already verify behavior through accessible labels and text content—keep those; remove the class checks.♻️ Suggested test hardening
test('shows active badge when bot is in server', () => { renderCard(mockGuild) const badge = screen.getByLabelText('Bot installed') expect(badge).toBeInTheDocument() expect(screen.getByText(/bot active/i)).toBeInTheDocument() - expect(badge).toHaveClass('bg-lucky-success/10') }) test('shows no bot badge when bot is not in server', () => { renderCard(mockGuildWithoutBot) const badge = screen.getByLabelText('Bot not installed') expect(badge).toBeInTheDocument() expect(screen.getByText(/no bot/i)).toBeInTheDocument() - expect(badge).toHaveClass('bg-lucky-error/10') })🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/frontend/src/components/Dashboard/ServerCard.test.tsx` around lines 76 - 92, The tests "shows active badge when bot is in server" and "shows no bot badge when bot is not in server" in ServerCard.test.tsx are asserting Tailwind CSS classes on the status badge (the expect(badge).toHaveClass('bg-lucky-success/10') and expect(badge).toHaveClass('bg-lucky-error/10') checks), which is brittle; remove those two class assertions and keep the existing accessibility and text assertions (the badge variable obtained via screen.getByLabelText and the screen.getByText checks) so renderCard, mockGuild, and mockGuildWithoutBot remain validated by label/text only.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/frontend/src/components/Dashboard/ServerCard.test.tsx`:
- Around line 76-92: The tests "shows active badge when bot is in server" and
"shows no bot badge when bot is not in server" in ServerCard.test.tsx are
asserting Tailwind CSS classes on the status badge (the
expect(badge).toHaveClass('bg-lucky-success/10') and
expect(badge).toHaveClass('bg-lucky-error/10') checks), which is brittle; remove
those two class assertions and keep the existing accessibility and text
assertions (the badge variable obtained via screen.getByLabelText and the
screen.getByText checks) so renderCard, mockGuild, and mockGuildWithoutBot
remain validated by label/text only.
In `@packages/frontend/src/components/Layout/Sidebar.test.tsx`:
- Around line 415-417: The selector string passed to document.querySelector in
the mobileSidebar assignment currently escapes the colon with `\\:`, which is
unnecessary; replace the plain string with a raw template using String.raw to
avoid backslash escaping (e.g., use String.raw`...` for the selector) so the
`lg\:` segment is written as `lg\:` without double-escaping; update the
expression where mobileSidebar is assigned (the document.querySelector call)
accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4259e5d1-1a32-47a5-a3d3-69da00341594
📒 Files selected for processing (3)
packages/frontend/src/components/Dashboard/ServerCard.test.tsxpackages/frontend/src/components/Layout/Layout.test.tsxpackages/frontend/src/components/Layout/Sidebar.test.tsx
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: SonarCloud Scan
- GitHub Check: Quality Gates
- GitHub Check: compressed-size
🧰 Additional context used
📓 Path-based instructions (16)
**/*.{js,jsx,ts,tsx,vue,html}
📄 CodeRabbit inference engine (.cursor/rules/accessibility-openness.mdc)
Provide accessible UI components using semantic HTML and ARIA attributes where necessary
Files:
packages/frontend/src/components/Layout/Layout.test.tsxpackages/frontend/src/components/Layout/Sidebar.test.tsxpackages/frontend/src/components/Dashboard/ServerCard.test.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/dependency-injection.mdc)
**/*.{ts,tsx,js,jsx}: Prefer constructor injection for classes that require dependencies
Avoid global mutable singletons unless necessary
Use explicit interfaces for external dependencies to make testing easier
**/*.{ts,tsx,js,jsx}: Include required references in PRs/code for non-trivial logic: TypeScript (official docs), MDN (JavaScript reference), and official docs for any runtime/framework/libraries used (e.g., Node.js, React) as applicable.
Before assuming behavior of an API, include the doc link and a ≤25-word quote when the change relies on it.
**/*.{ts,tsx,js,jsx}: Prefer named exports for clear usage and easier refactors in TypeScript/JavaScript
Keep import order consistent: external first, then internal modules
Remove dead code and unused imports
**/*.{ts,tsx,js,jsx}: Use PascalCase naming convention for React/UI components
Use camelCase naming convention for variables and functions
Use UPPER_SNAKE_CASE naming convention for constants
Maintain consistent import grouping and ordering within the project, keeping third-party imports separate from local imports
For external data sources (HTTP, database), always validate and sanitize input using type guards or schema validators
**/*.{ts,tsx,js,jsx}: Use Prettier with no semicolons, single quotes, 4-space indent, 80 character width
Files must not exceed 250 lines and this is enforcedImplement TypeScript typecheck and linter in CI quality checks
**/*.{ts,tsx,js,jsx}: Use TypeScript for enhanced type safety
Implement error handling and error logging
Avoid commenting code unless extremely necessary - code should explain itself with descriptive names
Leave NO todos, placeholders or missing pieces in the code
Variables and functions must use camelCase
Constants must use UPPER_SNAKE_CASE
Use arrow functions for methods and computed properties
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements
Maintain consistent import grouping/order: external imports first, then...
Files:
packages/frontend/src/components/Layout/Layout.test.tsxpackages/frontend/src/components/Layout/Sidebar.test.tsxpackages/frontend/src/components/Dashboard/ServerCard.test.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/error-handling.mdc)
**/*.{js,jsx,ts,tsx}: Never throw strings. ThrowError(or typed subclasses) with descriptive messages
Include causal error ascausewhen available for better debugging
Define clear, stable error codes (e.g.,ERR_AUTH_EXPIRED,ERR_NETWORK_TIMEOUT)
Provide optional metadata (e.g.,details,retryable,status,correlationId) in error objects
Use domain error classes per area (e.g.,AuthenticationError,ValidationError,NetworkError)
Log errors with structure (message, code, stack, cause, correlationId, user context where appropriate)
MarkretryablevsnonRetryableerrors where helpful for operations
Set timeouts and handle aborts/cancellations; avoid dangling requests in API/network code
Implement backoff for transient failures; avoid infinite retries
Map HTTP status → domain errors; 4xx vs 5xx behave differently (e.g., retry for 5xx/network)
**/*.{js,jsx,ts,tsx}: Use functional components with hooks in React/React Native. Avoid class components.
Keep components focused on a single responsibility; extract complex logic into custom hooks.
Keep state local when possible. Use Context/Zustand/Redux only when necessary for state management.
If props or state traverse more than 3 levels, consider using context or a feature-scoped store instead of prop drilling.
Use performance optimization techniques:React.memo,useMemo,useCallback,Suspense(web), and virtualization for long lists; avoid unnecessary re-renders.
Web accessibility: use semantic HTML, labels, focus management, keyboard navigation, andaria-*attributes as needed.
React Native accessibility: use accessibility props (accessible,accessibilityLabel), proper roles and labels.
Identify and extract repetitive UI components proactively tocomponents/with clear props and minimal coupling.
Web styles: prefer co-located styles or design system tokens; avoid global style leakage.
React Native styles: preferStyleSheet.create, design tokens, and theme providers; avoid in...
Files:
packages/frontend/src/components/Layout/Layout.test.tsxpackages/frontend/src/components/Layout/Sidebar.test.tsxpackages/frontend/src/components/Dashboard/ServerCard.test.tsx
**/*.{jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/error-handling.mdc)
**/*.{jsx,tsx}: Use toasts/snackbars for transient errors; avoid blocking modals for non-critical issues in React/React Native UI
Debounce/suppress duplicate toasts to prevent spam
Provide retry/refresh actions when meaningful (e.g., network failure) in error UI
Use error boundaries for render-time exceptions; show fallback UI in React
Respect accessibility: toasts should be announced (aria-live on web; accessibility hints on React Native)
Files:
packages/frontend/src/components/Layout/Layout.test.tsxpackages/frontend/src/components/Layout/Sidebar.test.tsxpackages/frontend/src/components/Dashboard/ServerCard.test.tsx
**/*.{test,spec}.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/frontend.mdc)
**/*.{test,spec}.{js,jsx,ts,tsx}: Test behavior, not implementation. Prefer Testing Library utilities for testing React/React Native components.
For React Native tests: mock native modules and test component interactions and accessibility labels.
Files:
packages/frontend/src/components/Layout/Layout.test.tsxpackages/frontend/src/components/Layout/Sidebar.test.tsxpackages/frontend/src/components/Dashboard/ServerCard.test.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/pattern.mdc)
Introduce interfaces at module boundaries to enable testing and substitutions
**/*.{ts,tsx}: Avoid usinganytype in TypeScript. If unavoidable, useunknownwith type guards and justify with a code comment
Preferinterfacefor defining public object shapes in TypeScript, usetypefor unions and utility types
Use TypeScript utility types such asPartial,Pick,Omit,Readonly, andRecordwhen appropriate
UseI{Name}naming convention for interfaces in TypeScript
UseT{Name}naming convention for type aliases and utility types in TypeScript
**/*.{ts,tsx}: Functions must be less than 50 lines with cyclomatic complexity less than 10
Do not useanytypes - ESLint enforces this at error level
**/*.{ts,tsx}: Prefer types over interfaces for most cases
Don't ever useany- type safety always
Avoid enums; use const objects instead
For complex types, create a separate file to declare them and import them
Avoid usinganytype; if unavoidable, useunknownwith type guards and justify with code comment
Preferinterfacefor public API shapes; usetypefor unions and utility types
Use TypeScript utility types (Partial, Pick, Omit, Readonly, Record)
Files:
packages/frontend/src/components/Layout/Layout.test.tsxpackages/frontend/src/components/Layout/Sidebar.test.tsxpackages/frontend/src/components/Dashboard/ServerCard.test.tsx
**/*.{test,spec}.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/pattern.mdc)
**/*.{test,spec}.{ts,tsx,js,jsx}: Test behavior, not implementation details
Prefer unit tests for core logic; add integration tests at meaningful boundaries
Files:
packages/frontend/src/components/Layout/Layout.test.tsxpackages/frontend/src/components/Layout/Sidebar.test.tsxpackages/frontend/src/components/Dashboard/ServerCard.test.tsx
**/*.{test,spec}.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/testing-quality.mdc)
**/*.{test,spec}.{js,ts,jsx,tsx}: Use Jest + a React testing library for unit and component tests as applicable
Test behavior, not implementation details
Files:
packages/frontend/src/components/Layout/Layout.test.tsxpackages/frontend/src/components/Layout/Sidebar.test.tsxpackages/frontend/src/components/Dashboard/ServerCard.test.tsx
packages/frontend/src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
packages/frontend/src/**/*.{ts,tsx}: Frontend errors are created by Axios interceptor and should be of typeApiErrorwith status and details from backend
Frontend uses path alias@/mapped tosrc/- use this alias for all imports from the src directoryDo not depend on
@lucky/sharedpackage in frontend code; make API calls to backend via configured base URL (env)
Files:
packages/frontend/src/components/Layout/Layout.test.tsxpackages/frontend/src/components/Layout/Sidebar.test.tsxpackages/frontend/src/components/Dashboard/ServerCard.test.tsx
**/*.{js,ts,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/documentation.mdc)
**/*.{js,ts,tsx,jsx}: Minimize comments in code; explain the 'why' when non-obvious, let code express the 'what' through clear naming
Document trade-offs briefly when deviating from ideal patterns
**/*.{js,ts,tsx,jsx}: Store secrets, ports, and hosts in environment variables (.env,.env.example) and never hardcode them
Avoid redundant or decorative AI comments; code should be self-explanatory and only commented when logic is non-obvious; prefer refactoring over lengthy commentsNever hardcode secrets, IPs, or ports; use
.envanddocs/for required configuration variables
Files:
packages/frontend/src/components/Layout/Layout.test.tsxpackages/frontend/src/components/Layout/Sidebar.test.tsxpackages/frontend/src/components/Dashboard/ServerCard.test.tsx
packages/frontend/src/components/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/lucky-frontend.mdc)
Organize UI components in
packages/frontend/src/components/directory
Files:
packages/frontend/src/components/Layout/Layout.test.tsxpackages/frontend/src/components/Layout/Sidebar.test.tsxpackages/frontend/src/components/Dashboard/ServerCard.test.tsx
packages/frontend/src/{components,pages}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/lucky-frontend.mdc)
Use React functional components and hooks; keep components small and focused
Files:
packages/frontend/src/components/Layout/Layout.test.tsxpackages/frontend/src/components/Layout/Sidebar.test.tsxpackages/frontend/src/components/Dashboard/ServerCard.test.tsx
packages/frontend/src/{components,pages}/**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/lucky-frontend.mdc)
Follow existing styling approach (e.g., Tailwind if present); avoid inline styles for layout and theming
Files:
packages/frontend/src/components/Layout/Layout.test.tsxpackages/frontend/src/components/Layout/Sidebar.test.tsxpackages/frontend/src/components/Dashboard/ServerCard.test.tsx
packages/frontend/**
📄 CodeRabbit inference engine (.cursor/rules/lucky-project.mdc)
The
frontendpackage uses React with Vite and must not depend on the shared package
Files:
packages/frontend/src/components/Layout/Layout.test.tsxpackages/frontend/src/components/Layout/Sidebar.test.tsxpackages/frontend/src/components/Dashboard/ServerCard.test.tsx
**/*.{spec,test}.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/quality.mdc)
**/*.{spec,test}.{ts,tsx,js,jsx}: Use Jest for unit and integration tests
Test behavior, not implementation details
Run unit, integration tests, and coverage report in CI quality checks
Files:
packages/frontend/src/components/Layout/Layout.test.tsxpackages/frontend/src/components/Layout/Sidebar.test.tsxpackages/frontend/src/components/Dashboard/ServerCard.test.tsx
**/[A-Z]*.{ts,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)
Components must use PascalCase naming
Files:
packages/frontend/src/components/Layout/Layout.test.tsxpackages/frontend/src/components/Layout/Sidebar.test.tsxpackages/frontend/src/components/Dashboard/ServerCard.test.tsx
🧠 Learnings (8)
📓 Common learnings
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-frontend.mdc:0-0
Timestamp: 2026-03-09T20:21:58.991Z
Learning: Write unit and integration tests in `packages/frontend/tests`; use Playwright for E2E tests when changing user flows
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-project.mdc:0-0
Timestamp: 2026-03-09T20:21:08.612Z
Learning: Applies to {packages/*/tests/**/*.test.{js,ts},tests/**/*.test.{js,ts}} : Add or adjust unit and integration tests when changing behavior; follow existing patterns in `packages/*/tests` and root `tests/` directories
📚 Learning: 2026-03-09T20:21:08.612Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-project.mdc:0-0
Timestamp: 2026-03-09T20:21:08.612Z
Learning: Applies to {packages/*/tests/**/*.test.{js,ts},tests/**/*.test.{js,ts}} : Add or adjust unit and integration tests when changing behavior; follow existing patterns in `packages/*/tests` and root `tests/` directories
Applied to files:
packages/frontend/src/components/Layout/Layout.test.tsxpackages/frontend/src/components/Layout/Sidebar.test.tsxpackages/frontend/src/components/Dashboard/ServerCard.test.tsx
📚 Learning: 2026-03-09T20:21:31.459Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/quality.mdc:0-0
Timestamp: 2026-03-09T20:21:31.459Z
Learning: Applies to **/*.{spec,test}.{ts,tsx,js,jsx} : Test behavior, not implementation details
Applied to files:
packages/frontend/src/components/Layout/Layout.test.tsxpackages/frontend/src/components/Layout/Sidebar.test.tsxpackages/frontend/src/components/Dashboard/ServerCard.test.tsx
📚 Learning: 2026-03-09T20:20:56.356Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-frontend.mdc:0-0
Timestamp: 2026-03-09T20:20:56.356Z
Learning: Applies to packages/frontend/tests/**/*.{ts,tsx,js} : Write tests in `packages/frontend/tests/` using existing test patterns (e.g., Playwright for e2e if configured)
Applied to files:
packages/frontend/src/components/Layout/Layout.test.tsx
📚 Learning: 2026-03-09T20:21:31.459Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/quality.mdc:0-0
Timestamp: 2026-03-09T20:21:31.459Z
Learning: Applies to tests/**/*.test.{ts,tsx,js,jsx} : Add integration tests where appropriate
Applied to files:
packages/frontend/src/components/Layout/Sidebar.test.tsxpackages/frontend/src/components/Dashboard/ServerCard.test.tsx
📚 Learning: 2026-03-09T20:20:38.694Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-backend-api.mdc:0-0
Timestamp: 2026-03-09T20:20:38.694Z
Learning: Applies to packages/backend/tests/**/*.{ts,tsx} : Organize tests in `packages/backend/tests/` with unit tests under `unit/` and integration tests under `integration/`, following existing patterns with fixtures and setup
Applied to files:
packages/frontend/src/components/Dashboard/ServerCard.test.tsx
📚 Learning: 2026-03-09T20:21:38.098Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-backend.mdc:0-0
Timestamp: 2026-03-09T20:21:38.098Z
Learning: Applies to packages/backend/tests/**/*.ts : Follow existing patterns for unit and integration tests in `packages/backend/tests/`
Applied to files:
packages/frontend/src/components/Dashboard/ServerCard.test.tsx
📚 Learning: 2026-03-09T20:21:58.991Z
Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/subagent-frontend.mdc:0-0
Timestamp: 2026-03-09T20:21:58.991Z
Learning: Write unit and integration tests in `packages/frontend/tests`; use Playwright for E2E tests when changing user flows
Applied to files:
packages/frontend/src/components/Dashboard/ServerCard.test.tsx
🪛 GitHub Check: SonarCloud Code Analysis
packages/frontend/src/components/Layout/Sidebar.test.tsx
[warning] 416-416: String.raw should be used to avoid escaping \.
🔇 Additional comments (11)
packages/frontend/src/components/Layout/Layout.test.tsx (2)
52-56: Nice upgrade to an accessibility-first assertion.Using role + accessible name on Line 53 makes this test behavior-focused and aligned with the actual interactive control.
Based on learnings: "Applies to **/*.{spec,test}.{ts,tsx,js,jsx} : Test behavior, not implementation details".
95-97: Good negative-path coverage for no selected guild.The Line 96 role-based absence check is a solid regression guard for the fallback route behavior.
Based on learnings: "Applies to **/*.{spec,test}.{ts,tsx,js,jsx} : Test behavior, not implementation details".
packages/frontend/src/components/Layout/Sidebar.test.tsx (4)
117-118: LGTM! Good shift to accessibility-based assertions.Using
aria-current="page"aligns with the WAI-ARIA standard for indicating the current page in navigation, and the test now correctly reflects the component's implementation.
165-165: LGTM!The selector correctly matches the component's
aria-label='Log out'(two words) as confirmed in the Sidebar implementation.
404-406: LGTM!The accessible name now correctly matches the component's
aria-label='Open navigation menu'.
351-394: LGTM! Good coverage for guild automation route access.The two tests correctly verify:
- Guild Automation nav item is hidden when user only has
settings: 'view'(even withautomation: 'manage')- Guild Automation nav item is shown when user has
settings: 'manage'This aligns with the PR objective and maintains regression coverage for the settings-based access guard.
packages/frontend/src/components/Dashboard/ServerCard.test.tsx (5)
20-47: Mocking setup foruseGuildStoreis well-aligned with component behavior.This setup cleanly supports asserting
selectGuildside effects in interaction tests.
62-66: Icon accessibility and CDN URL assertions look good.These assertions correctly reflect rendered behavior (
alttext and?size=128URL variant).
94-98: Nice addition for member-count rendering coverage.This strengthens visible-state coverage with a direct user-facing assertion.
107-116: Great interaction test for Manage action side effects.Asserting both guild selection and navigation improves regression safety for this flow.
122-141: Updated accessibility-focused button/indicator assertions are solid.The role/label-based checks improve resilience and user-centric coverage for bot-installed vs not-installed states.
|
|
* test(frontend): cover guild automation route access * test(frontend): update mobile sidebar label assertion * test(frontend): align layout and sidebar assertions * test(frontend): align layout and sidebar assertions * test(frontend): align server card assertions * ci(vercel): skip yt-dlp download during install * test(frontend): align music and server page assertions * test(frontend): align login and moderation assertions * test(frontend): align login assertions
This branch was successfully deployed
1 participant
Summary
/guild-automationwhen a member hassettings: 'manage'mainSummary by CodeRabbit