Repository navigation
fix: unblock ioredis/bullmq bumps by deduping stale lockfile - #2033
Conversation
Bumps [bullmq](https://github.com/taskforcesh/bullmq) from 5.81.3 to 6.0.9. - [Release notes](https://github.com/taskforcesh/bullmq/releases) - [Commits](taskforcesh/bullmq@v5.81.3...v6.0.9) --- updated-dependencies: - dependency-name: bullmq dependency-version: 6.0.9 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ioredis](https://github.com/redis/ioredis) from 5.11.1 to 6.0.0. - [Release notes](https://github.com/redis/ioredis/releases) - [Changelog](https://github.com/redis/ioredis/blob/main/CHANGELOG.md) - [Commits](redis/ioredis@v5.11.1...v6.0.0) --- updated-dependencies: - dependency-name: ioredis dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…6.0.0' into fix/2028-2026-ioredis-bullmq-batchqueue
….0.9' into fix/2028-2026-ioredis-bullmq-batchqueue
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe change updates BullMQ from version 5 to version 6 in the root, bot, and shared packages. The shared package also updates ioredis from version 5 to version 6. ChangesDependency updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The PR refreshes dependency resolutions to remove conflicting ioredis versions without changing source behavior, and the documented checks pass; no actionable merge-blocking risk remains beyond normal review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Failed to generate code suggestions for PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Re-trigger cubic
There was a problem hiding this comment.
Graphify reviewed this change.
Looks safe to merge — no coupling regressions and no blocking issues, checked against the code graph (not a self-assessment).
Graphify review — findings
This PR bumps a large number of dependency versions in package-lock.json, most notably upgrading the root bullmq dependency from ^5 to ^6, along with many transitive AWS SDK and Smithy package version updates. It also removes a nested source-map dependency entry and touches related package.json/lockfile metadata across the bot and shared packages. The changes are confined to dependency/lockfile updates and package configuration rather than application source logic.
No blocking issues surfaced.
Analysis details — impact, health, verification
Impact & health
Graphify review
Impact — 343 functions depend on the 343 functions this change touches.
Health — grade A; no new coupling hotspots.
Verification — 343 functions in the blast radius were not formally verified this run (proofs are advisory here).
Gate & verification
graphify gate
PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.
Advisory (not blocking):
- verification_scope: 343 function(s) in the blast radius were not formally verified this run
Bot used the ioredis Redis type directly (batchJobWorker.ts) but only got it via transitive hoisting from packages/shared. Pin it explicitly to the same version so it can't silently drift to a second copy again.
|
Fixed in 144155a — declared |
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Requires human review: Major version upgrade of queue/Redis libs (bullmq 5->6, ioredis 5->6) with large lockfile churn; operational impact and compatibility need human sign-off.
Re-trigger cubic
There was a problem hiding this comment.
Graphify reviewed this change.
Looks safe to merge — no coupling regressions and no blocking issues, checked against the code graph (not a self-assessment).
Graphify review — findings
This PR is primarily a dependency update to the package-lock.json lockfile in a monorepo containing bot and shared packages. It bumps bullmq from ^5 to ^6 and updates numerous transitive/optional dependencies (notably many @aws-sdk/@smithy packages) to newer patch/minor versions, and removes a nested source-map entry. Based on the changed symbol list, it also appears to touch various package.json files across the root, bot, and shared packages (dependencies, devDependencies, scripts, engines, exports, and overrides).
No blocking issues surfaced. 1 lower-confidence candidate did not survive cross-model review.
Analysis details — impact, health, verification
Impact & health
Graphify review
Impact — 345 functions depend on the 345 functions this change touches.
Health — grade A; no new coupling hotspots.
Verification — 345 functions in the blast radius were not formally verified this run (proofs are advisory here).
Gate & verification
graphify gate
PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.
Advisory (not blocking):
- verification_scope: 345 function(s) in the blast radius were not formally verified this run
|
🤖 I have created a release *beep* *boop* --- <details><summary>2.39.5</summary> ## [2.39.5](v2.39.4...v2.39.5) (2026-08-19) ### Bug Fixes * **bot:** support yt-dlp cookies file to dodge YouTube 403 ([#2036](#2036)) ([2ec1868](2ec1868)) * **deps:** override deepmerge-ts to 8.0.1 to close security gate ([#2038](#2038)) ([04a7f85](04a7f85)) * drop dead guild-guard entry for nonexistent features route ([#2030](#2030)) ([522139c](522139c)) * unblock ioredis/bullmq bumps by deduping stale lockfile ([#2033](#2033)) ([0c6cb0d](0c6cb0d)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).



Summary
Merges dependabot #2028 (ioredis 5.11.1 -> 6.0.0) and #2026 (bullmq 5.81.3 -> 6.0.9), which were both held on the same TS2322 break in
packages/bot/src/utils/batch/batchQueue.ts:30. The break was a stalepackage-lock.json, not a code incompatibility: each dependabot PR's lockfile diff was generated independently, and merging both left two conflictingiorediscopies in the tree (root5.11.1vspackages/shared/node_modules6.0.0), so TypeScript rejected passing oneRedisclient type into bullmq'sConnectionOptions.Fix:
rm -rf node_modules package-lock.json && npm installto force a full re-resolve, dedupes to a singleioredis@6.0.0. No source changes.Full root-cause writeup and repro steps: closes #2032.
Test plan
packages/bot:tsc --noEmitcleanpackages/backend:tsc --noEmitcleanSummary by cubic
Dedupes the lockfile and upgrades to
ioredis@6andbullmq@6so TypeScript no longer sees mixedioredisversions. Previously we resolved bothioredis@5and@6(TS2322); now we resolve a singleioredis@6.0.0and declare it explicitly where used.bullmqto^6in root,packages/bot, andpackages/shared; bumpsioredisto^6inpackages/sharedand addsioredis^6as a direct dependency inpackages/bot; regeneratespackage-lock.jsonto dedupe to oneioredis@6.0.0. No TypeScript code changes.node_modulesandpackage-lock.json, then runnpm installornpm ci).Written for commit 144155a. Summary will update on new commits.
Summary by CodeRabbit