Repository navigation
fix: canonicalize Last.fm connect URL host in production - #195
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for regal-bunny-0c8efe ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThis change adds validation to the Last.fm link origin-resolution logic, rejecting legacy nexus.lucassantana.tech and non-HTTP(S) URLs while falling back to WEBAPP_REDIRECT_URI when appropriate, alongside documentation clarifications and comprehensive test coverage. Changes
Sequence DiagramsequenceDiagram
participant Client
participant Bot as Bot Command Handler
participant Validator as getAbsoluteOrigin()
participant Backend as WEBAPP_BACKEND_URL
participant Redirect as WEBAPP_REDIRECT_URI
Client->>Bot: Request Last.fm connect link
Bot->>Validator: Validate WEBAPP_BACKEND_URL
Validator->>Backend: Parse and check protocol & hostname
alt Valid (http/https & not nexus)
Validator-->>Bot: Return backend origin
else Invalid
Validator-->>Bot: Return null
Bot->>Validator: Validate WEBAPP_REDIRECT_URI
Validator->>Redirect: Parse and check protocol & hostname
alt Valid (http/https & not nexus)
Validator-->>Bot: Return redirect origin
else Invalid
Validator-->>Bot: Return null (config error)
end
end
Bot-->>Client: Connect URL or error embed
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/lastfm linkURL origin validation to accept only HTTP(S)nexus.lucassantana.techorigins in link generationWEBAPP_BACKEND_URLandWEBAPP_REDIRECT_URIVerification
npm run test --workspace=packages/bot -- packages/bot/src/functions/general/commands/lastfm.spec.tsnpm run test --workspace=packages/bot -- lastfmnpm run type:check --workspace=packages/botSummary by CodeRabbit
Bug Fixes
Documentation