Repository navigation
fix(backend): artist suggestions 503 not 500 on upstream timeout - #1787
Conversation
…tions Fixes intermittent 500 errors in GET /api/artists/suggestions that occur when the suggestions service experiences upstream provider timeouts. Root cause: service handlers threw plain objects instead of AppError instances, causing the error middleware to treat them as unhandled errors and captureException them, resulting in 500 + alert noise instead of graceful 503. Changes: - Import AppError in artistSuggestion.ts - Replace all plain object throws with AppError instances - Wrap getSuggestions call in try-catch to convert unexpected errors to 503 - Log warnings (not exceptions) for expected unavailability per issue #1657 - Update tests to check for AppError instances and correct status codes Result: upstream timeouts now return 503 "Artist suggestions temporarily unavailable" consistently, without triggering captureException alert noise. Closes #1781
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 1 minute Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Failed to generate code suggestions for PR |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Requires human review: Refactors error handling in the artist suggestions backend across multiple endpoints, replacing throws with AppError and a try-catch. It's a logic change that could cause subtle breakages and needs human review.
Re-trigger cubic
|
🤖 I have created a release *beep* *boop* --- <details><summary>2.35.0</summary> ## [2.35.0](v2.34.0...v2.35.0) (2026-07-13) ### Features * **bot:** /bulk-kick — proof-of-pattern for the bulk-* command family ([#1802](#1802)) ([1c11f3e](1c11f3e)) * **bot:** add lucky_bot_gateway_connected zombie-detection gauge ([#1774](#1774)) ([6cc5287](6cc5287)) * **bot:** playback progress bar in nowplaying/songinfo embed ([#1797](#1797)) ([1138b59](1138b59)) * **bot:** post server-count stats to Top.gg for listing visibility ([#1789](#1789)) ([e8ca6b9](e8ca6b9)) * **bot:** temporary support ticket channels (/ticket) ([#1803](#1803)) ([49601a1](49601a1)) * **live-notif:** youtube polling, message ttl cleanup, api backoff ([#1762](#1762)) ([a99b85a](a99b85a)) * **remind:** channel and role broadcast reminders ([#1767](#1767)) ([#1807](#1807)) ([83ade79](83ade79)) ### Bug Fixes * **backend:** artist suggestions 503 not 500 on upstream timeout ([#1787](#1787)) ([eadc20e](eadc20e)) * **bot:** guard skipReason telemetry against null prisma client ([#1773](#1773)) ([d73421e](d73421e)) * **ci:** stop auto-update workflow racing on merge push ([#1811](#1811)) ([2ddd202](2ddd202)) * **csp:** allow Cloudflare Insights beacon in script-src/connect-src ([#1788](#1788)) ([f20c4cf](f20c4cf)) * **deps:** bump eslint in lock to satisfy npm@12 ci (unblock release) ([#1809](#1809)) ([68fd0be](68fd0be)) * paginate bulk-move message fetch to respect discord api limit ([#1776](#1776)) ([5b5d2fc](5b5d2fc)) * **weekly-digest:** trigger on Sunday and add new-guides RSS section ([#1761](#1761)) ([f429fc6](f429fc6)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
1 participant
Summary
Fixes intermittent 500 errors in GET /api/artists/suggestions that occur when the suggestions service experiences upstream provider timeouts (~5s latency → Spotify API slow/unavailable).
Root Cause
Service handlers threw plain objects
{ status, error }instead ofAppErrorinstances. When these reached the error middleware, they were treated as unhandled errors →captureException()+ 500, instead of graceful 503. Result: 12 false-positive alert instances in LUCKY-35 (Sentry), regressed at v2.34.0.Fix
AppErrorinstances inArtistSuggestionServicegetSuggestions()call in try-catch to convert unexpected errors to 503 (service unavailable)Testing
AppErrorinstances + correctstatusCodefieldsResult: upstream timeouts now consistently return 503 without triggering captureException.
Closes #1781
Summary by cubic
Return 503 Service Unavailable (not 500) from artist suggestions when Spotify times out, preventing false alerts and aligning with #1781. Uses AppError for consistent statuses and captures only unexpected errors before returning 503.
AppErroracross artist suggestion service handlers.getSuggestions()to convert unexpected failures to 503; callcaptureExceptiononly for unexpected errors; warn-log expected unavailability and empty results.AppErrorfor auth, validation, and param checks across search/related/preferences endpoints.AppErrorand status codes; added cases for the 503 catch-all to verify error capture, and for no-capture on expected empty-result 503s.Written for commit f247333. Summary will update on new commits.