Skip to content

fix(docker): bump npm to patch bundled undici/tar CVEs in base image #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LucasSantana-Dev merged 6 commits into from
Jul 9, 2026
Merged

fix(docker): bump npm to patch bundled undici/tar CVEs in base image #1709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1282900
fix(docker): bump npm to patch bundled undici/tar CVEs in base image
LucasSantana-Dev Jul 8, 2026
e2ad59f
Merge remote-tracking branch 'origin/main' into fix/docker-triage-4
LucasSantana-Dev Jul 9, 2026
04f4afa
fix(docker): clean npm cache after global npm upgrade in all 4 stages
LucasSantana-Dev Jul 9, 2026
c354054
Merge remote-tracking branch 'origin/main' into fix/docker-triage-4
LucasSantana-Dev Jul 9, 2026
1d9af67
fix(docker): pin npm to 12.0.0 instead of @latest for reproducible bu…
LucasSantana-Dev Jul 9, 2026
11d8257
Merge remote-tracking branch 'origin/main' into fix/docker-triage-4
LucasSantana-Dev Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@
&& python3 -m venv /opt/ytdlp \
&& /opt/ytdlp/bin/pip install --no-cache-dir --upgrade pip yt-dlp \
&& ln -s /opt/ytdlp/bin/yt-dlp /usr/local/bin/yt-dlp \
&& rm -rf /var/cache/apk/* /root/.cache
&& rm -rf /var/cache/apk/* /root/.cache \
&& npm install -g npm@12.0.0 \
&& npm cache clean --force
Comment thread
LucasSantana-Dev marked this conversation as resolved.

WORKDIR /app

Expand All @@ -52,9 +54,9 @@

# Build stage — installs all deps, generates prisma, builds shared + target
FROM node:${NODE_VERSION} AS build
ARG NPM_CACHE_KEY

Check warning on line 57 in Dockerfile

View workflow job for this annotation

GitHub Actions / Build — backend

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "NPM_CACHE_KEY")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

Check warning on line 57 in Dockerfile

View workflow job for this annotation

GitHub Actions / Build — frontend

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "NPM_CACHE_KEY")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

Check warning on line 57 in Dockerfile

View workflow job for this annotation

GitHub Actions / Build — bot

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "NPM_CACHE_KEY")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

RUN apk add --no-cache git build-base python3 python3-dev opus-dev && rm -rf /var/cache/apk/*
RUN apk add --no-cache git build-base python3 python3-dev opus-dev && rm -rf /var/cache/apk/* && npm install -g npm@12.0.0 && npm cache clean --force

WORKDIR /app

Expand Down Expand Up @@ -96,14 +98,14 @@

# Production deps — slim install (no dev deps)
FROM node:${NODE_VERSION} AS deps-production
ARG NPM_CACHE_KEY

Check warning on line 101 in Dockerfile

View workflow job for this annotation

GitHub Actions / Build — backend

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "NPM_CACHE_KEY")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

Check warning on line 101 in Dockerfile

View workflow job for this annotation

GitHub Actions / Build — bot

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "NPM_CACHE_KEY")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

# build-base + python3-dev + opus-dev: @discordjs/opus falls back to a source
# build whenever its musl prebuilt is missing for the current base image
# (alpine/musl bumps rename the prebuilt — 404'd 2026-06-12, #1309). Same
# toolchain the build stage carries (L50) and the same failure class the
# frontend stage comment below documents from PR #846.
RUN apk add --no-cache build-base python3 python3-dev opus-dev && rm -rf /var/cache/apk/*
RUN apk add --no-cache build-base python3 python3-dev opus-dev && rm -rf /var/cache/apk/* && npm install -g npm@12.0.0 && npm cache clean --force

WORKDIR /app

Expand Down
2 changes: 2 additions & 0 deletions packages/frontend/Dockerfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ FROM node:22-alpine

WORKDIR /app

RUN npm install -g npm@latest && npm cache clean --force

COPY package*.json ./

# Keep BuildKit's cache mount — DO NOT run `npm cache clean --force` here,
Expand Down
Loading