fix(reaction-roles): PUT panel edit deletes mappings by cuid not snowflake (#1675)

[LucasSantana-Dev]

Fixes #1675.

Problem

PUT /api/guilds/:guildId/reaction-roles/:messageId always 400s:

Unique constraint failed on the fields: (`messageId`)

updateReactionRoleMessage cleared old mappings with:

prisma.reactionRoleMapping.deleteMany({ where: { messageId } }) // messageId = Discord snowflake

But ReactionRoleMapping.messageId is a FK to ReactionRoleMessage.id (a cuid), with @@unique([messageId, roleId]). The snowflake matched zero rows, so the nested mappings.create re-inserted existing (messageId, roleId) pairs and violated the unique constraint. Every edit failed; only delete+recreate worked (which changes the Discord messageId and re-orders panels).

Fix

Delete old mappings by message.id (the cuid, already loaded) in both the update transaction and the rollback transaction. Add a regression test asserting deleteMany is called with the message cuid, not the snowflake.

Verified

• packages/shared tests: 98 passed (incl. new reaction-roles PUT (update panel) always 400s: deleteMany uses Discord snowflake instead of message cuid #1675 guard).
• Typecheck clean across all workspaces.
• The create path was already correct and untouched.

---

Summary by cubic

Fixes reaction‑role panel edits by deleting old mappings using the message cuid (DB id) instead of the Discord snowflake in both update and rollback paths. This prevents unique constraint errors, including when the Discord PATCH fails.

• Bug Fixes
  • Delete old mappings by message.id (cuid) in reactionRoleMapping.deleteMany for both update and rollback transactions.
  • Add regression tests for both paths to assert deletion by cuid (reaction-roles PUT (update panel) always 400s: deleteMany uses Discord snowflake instead of message cuid #1675).

^{Written for commit fe25794. Summary will update on new commits.}

Summary by CodeRabbit

• Bug Fixes
  • Fixed reaction-role cleanup so related mappings are deleted using the correct internal message identifier, preventing mismatched deletions when a message update fails.
• Tests
  • Expanded and adjusted regression coverage for reaction-role message updates, including rollback behavior and updated mocked responses for existing scenarios.

[github-actions]

Failed to generate code suggestions for PR

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds comments documenting cuid-based mapping deletion in updateReactionRoleMessage, adds regression coverage for the REST edit and rollback paths, and reformats several existing Jest mocks and role fixtures in the shared reaction roles spec.

Changes

Reaction role mapping deleteMany fix

Layer / File(s)	Summary
Clarify deleteMany FK reference and add regression test packages/shared/src/services/ReactionRolesService/index.ts, packages/shared/src/services/ReactionRolesService/index.spec.ts	Adds inline comments explaining that reactionRoleMapping.deleteMany targets ReactionRoleMessage.id (cuid), and adds tests covering the update and rollback paths with deleteMany asserted against that cuid.
Spec mock and fixture formatting packages/shared/src/services/ReactionRolesService/index.spec.ts	Reformats transaction, fetch, role fixture, and insert-path mocks into multiline forms without changing test behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• LucasSantana-Dev/Lucky#1544: Directly overlaps with updateReactionRoleMessage transaction cleanup and mapping deletion behavior.
• LucasSantana-Dev/Lucky#1587: Also touches the rollback/deleteMany-by-cuid path in reaction role updates.
• LucasSantana-Dev/Lucky#1588: Related Jest coverage changes around reaction-role update transaction mocks.

Suggested labels: shared

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR updates both the main and rollback deleteMany paths to use message.id and adds a regression test for the cuid lookup.
Out of Scope Changes check	✅ Passed	The changes stay focused on the reaction-role update bug fix, test coverage, and clarifying comments with no unrelated scope.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the core fix: reaction-role panel edits now delete mappings by cuid instead of the Discord snowflake.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/1675-rr-update-deletemany-cuid

---

_{Comment @coderabbitai help to get the list of available commands.}

[cubic-dev-ai]

1 issue found and verified against the latest diff

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

packages/shared/src/services/ReactionRolesService/index.ts (1)

572-606: 🗄️ Data Integrity & Integration | 🔴 Critical | ⚡ Quick win

Rollback branch still deletes by the Discord snowflake, not the message cuid — same bug reintroduced on rollback.

Line 577 filters reactionRoleMapping.deleteMany by messageId (the Discord snowflake), while ReactionRoleMapping.messageId is a FK to ReactionRoleMessage.id (the cuid), per the comment just added above at Line 532-534 and the PR's stated root cause. This mirrors the exact bug this PR fixes in the main transaction (Lines 530-535), but here it's left unfixed despite the PR description stating the correction was applied "in both the update transaction and rollback path."

Practical impact: if the Discord PATCH fails, this rollback deleteMany will match zero rows (leftover mappings from the just-committed update remain), and the subsequent create of originalMappings will collide with @@unique([messageId, roleId]), throwing from inside the rollback itself — masking the original discordError and leaving the DB in the wrong (unrolled-back) state.

🐛 Proposed fix

                     await prisma.$transaction([
                         prisma.reactionRoleMapping.deleteMany({
-                            where: { messageId },
+                            where: { messageId: message.id },
                         }),

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/shared/src/services/ReactionRolesService/index.ts` around lines 572
- 606, The rollback path in ReactionRolesService still uses the Discord
snowflake instead of the Prisma record id when clearing mappings, so the
rollback can miss rows and then fail on the unique constraint. Update the catch
block in the update flow to make reactionRoleMapping.deleteMany filter by the
same cuid-backed message identifier used elsewhere in the service, not the
Discord messageId, so the rollback truly restores originalMappings before the
reactionRoleMessage.update recreate step.

🧹 Nitpick comments (1)

packages/shared/src/services/ReactionRolesService/index.spec.ts (1)

1389-1417: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Consider adding a rollback-path regression test too.

This test only covers the success-path deleteMany call. Given the rollback branch (triggered when the Discord PATCH fails) has the identical deleteMany pattern and — per my comment on index.ts Lines 572-606 — currently still filters by the snowflake, a companion test simulating a failed Discord PATCH and asserting the rollback deleteMany call also uses message.id would have caught that gap and prevent regressions once fixed.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/shared/src/services/ReactionRolesService/index.spec.ts` around lines
1389 - 1417, Add a rollback-path regression test alongside
updateReactionRoleMessage in ReactionRolesService/index.spec.ts: simulate the
Discord PATCH failure branch and assert the compensating
reactionRoleMapping.deleteMany call uses the internal message.id (cuid) rather
than the Discord snowflake, mirroring the existing success-path test so the
rollback path is covered too.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@packages/shared/src/services/ReactionRolesService/index.ts`:
- Around line 572-606: The rollback path in ReactionRolesService still uses the
Discord snowflake instead of the Prisma record id when clearing mappings, so the
rollback can miss rows and then fail on the unique constraint. Update the catch
block in the update flow to make reactionRoleMapping.deleteMany filter by the
same cuid-backed message identifier used elsewhere in the service, not the
Discord messageId, so the rollback truly restores originalMappings before the
reactionRoleMessage.update recreate step.

---

Nitpick comments:
In `@packages/shared/src/services/ReactionRolesService/index.spec.ts`:
- Around line 1389-1417: Add a rollback-path regression test alongside
updateReactionRoleMessage in ReactionRolesService/index.spec.ts: simulate the
Discord PATCH failure branch and assert the compensating
reactionRoleMapping.deleteMany call uses the internal message.id (cuid) rather
than the Discord snowflake, mirroring the existing success-path test so the
rollback path is covered too.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 24d6abdd-9f4a-4ed6-8b68-027899ee5773

📥 Commits

Reviewing files that changed from the base of the PR and between 62f5333 and 444b312.

📒 Files selected for processing (2)

• packages/shared/src/services/ReactionRolesService/index.spec.ts
• packages/shared/src/services/ReactionRolesService/index.ts

[cubic-dev-ai]

0 issues found across 2 files (changes from recent commits).

<sub>Auto-approved: Fix reaction-role panel edit bug by using correct cuid for deleting old mappings. Adds regression tests.

Re-trigger cubic</sub>

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud