fix(bot): wire role exclusion enforcement + guildmembers intent

[LucasSantana-Dev]

Summary

Two structural gaps found while migrating Criativaria's Dyno registration gate (Registro→Membro):

1. RoleExclusion enforcement was dead code — RoleManagementService.handleGuildMemberUpdate implements the diff-added-roles→remove-excluded contract, but nothing ever listened to Events.GuildMemberUpdate. Now wired in memberHandler.handleMemberEvents with the same try/catch pattern as Add/Remove.
2. GuildMembers privileged intent was missing from the client — GuildMemberAdd/Remove/Update require it, so welcome/leave messages, autoroles, AND exclusions never fired (this is why Dyno still does Criativaria's join logging). Portal toggle verified ON before requesting it (GATEWAY_GUILD_MEMBERS_LIMITED flag set) — no login-failure risk.

Tests

memberHandler suite 17/17 (2 new: delegation + reject-path logging). Full bot typecheck via pre-commit.

Deploy note

After this ships, Criativaria cutover: flip auto_messages rows to enabled (staged disabled), verify exclusion removes Registro on rules-accept, then retire Dyno's modules.

Closes #1667. Refs decisions/2026-07-02-criativaria-server-config-automod-engagement.md.

---

Summary by cubic

Wired GuildMemberUpdate to role-exclusion enforcement and enabled the GuildMembers privileged intent so welcome/leave, autoroles, and exclusions run reliably. Closes #1667.

• Bug Fixes

  • Listen to GuildMemberUpdate and delegate to role exclusion handler; log and continue on errors. Add tests for delegation and errors; use fresh client per suite.
  • Add GatewayIntentBits.GuildMembers; portal toggle verified via GATEWAY_GUILD_MEMBERS_LIMITED to avoid login issues.

• Migration

  • Criativaria: enable auto_messages.
  • Verify Registro is removed on rules accept.
  • Retire Dyno modules.

^{Written for commit 9bca920. Summary will update on new commits.}

Summary by CodeRabbit

• New Features

  • Added support for handling guild member updates, improving member-related automation and event coverage.
  • Expanded client permissions to support member-related events needed for welcome/leave, autorole, and role enforcement behavior.

• Bug Fixes

  • Member update handling now logs errors safely instead of failing the event flow.
  • Added test coverage to confirm update events are routed correctly and error cases are handled without crashing.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds the GuildMembers privileged intent to the Discord client configuration and wires a new Events.GuildMemberUpdate listener in memberHandler.ts that delegates to roleManagementService.handleGuildMemberUpdate, wrapped in try/catch error logging. Corresponding test coverage is added in memberHandler.spec.ts.

Changes

GuildMemberUpdate Wiring

Layer / File(s)	Summary
GuildMembers intent configuration packages/bot/src/handlers/clientHandler/service.ts	Adds GatewayIntentBits.GuildMembers to the client intents with comments explaining its usage for member add/remove/update, welcome/leave, autorole, and role-exclusion enforcement.
GuildMemberUpdate handler wiring packages/bot/src/handlers/memberHandler.ts	Imports roleManagementService and registers a client.on(Events.GuildMemberUpdate, ...) handler that calls handleGuildMemberUpdate(oldMember, newMember) inside a try/catch that logs errors via errorLog.
Test coverage packages/bot/src/handlers/memberHandler.spec.ts	Mocks roleManagementService.handleGuildMemberUpdate, updates service destructuring, and adds a new GuildMemberUpdate test suite covering successful delegation and error-logging on rejection.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant DiscordClient
  participant memberHandler
  participant roleManagementService

  DiscordClient->>memberHandler: Events.GuildMemberUpdate(oldMember, newMember)
  memberHandler->>roleManagementService: handleGuildMemberUpdate(oldMember, newMember)
  alt success
    roleManagementService-->>memberHandler: resolved
  else failure
    roleManagementService-->>memberHandler: rejected
    memberHandler->>memberHandler: errorLog("Error in member update handler:")
  end

Loading

Possibly related PRs

• LucasSantana-Dev/Lucky#384: Both PRs extend memberHandler.spec.ts/memberHandler.ts test coverage for member event handling in the same handler surface.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main changes: role exclusion wiring and the GuildMembers intent.
Linked Issues check	✅ Passed	The PR implements #1667 by wiring GuildMemberUpdate to handleGuildMemberUpdate and enabling the required GuildMembers intent.
Out of Scope Changes check	✅ Passed	The changes stay focused on the event wiring, intent update, and matching test coverage with no unrelated additions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/wire-role-exclusion-1667

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Failed to generate code suggestions for PR

[coderabbitai]

🧹 Nitpick comments (1)

packages/bot/src/handlers/clientHandler/service.ts (1)

40-40: 🚀 Performance & Scalability | 🔵 Trivial

Consider configuring member cache limits/sweepers.

Enabling GuildMembers intent means the client will populate its guild member cache as GuildMemberAdd/Update events arrive. For bots in large guilds, this cache can grow significantly over time unless bounded via makeCache/sweepers in the client options. Not a blocker for this PR, but worth planning for as usage scales.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/bot/src/handlers/clientHandler/service.ts` at line 40, The Client in
clientHandler/service.ts enables GatewayIntentBits.GuildMembers, so the member
cache can grow without bounds as guild activity increases. Update the client
options near the Client construction to configure makeCache and/or sweepers,
using the existing client setup symbols to keep GuildMember caching bounded for
larger guilds.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@packages/bot/src/handlers/clientHandler/service.ts`:
- Line 40: The Client in clientHandler/service.ts enables
GatewayIntentBits.GuildMembers, so the member cache can grow without bounds as
guild activity increases. Update the client options near the Client construction
to configure makeCache and/or sweepers, using the existing client setup symbols
to keep GuildMember caching bounded for larger guilds.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b5482968-b791-4d86-b1b6-51fe05df7310

📥 Commits

Reviewing files that changed from the base of the PR and between 862426a and ac8a292.

📒 Files selected for processing (3)

• packages/bot/src/handlers/clientHandler/service.ts
• packages/bot/src/handlers/memberHandler.spec.ts
• packages/bot/src/handlers/memberHandler.ts

[cubic-dev-ai]

1 issue found across 3 files

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[github-actions]

	Warnings
⚠️	This PR appears to remove a feature or route (detected in commit message). Please fill in the Feature-removal sweep checklist in the PR template to ensure no orphan code (models, tests, types, imports) is left behind. See decisions/ for context.

Generated by 🚫 dangerJS against 9bca920

[cubic-dev-ai]

0 issues found across 1 file (changes from recent commits).

<sub>Auto-approved: Adds GuildMembers privileged intent (portal toggle verified) and wires GuildMemberUpdate event to existing role exclusion handler. Small, targeted bug fix with tests and error handling.

Re-trigger cubic</sub>

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud