fix(schema): add unique guild+thread constraint to guildforumthread

[LucasSantana-Dev]

Summary

Adds a unique index on (guildId, threadId) to prevent duplicate rows for the same thread in the GuildForumThread model.

The existing @@unique([guildId, slug]) constraint only enforced slug uniqueness within a guild, not thread uniqueness. This left the schema vulnerable to duplicate entries for the same thread.

Closes #1534

---

Summary by cubic

Add a unique (guildId, threadId) constraint to GuildForumThread to prevent duplicate threads, and fix reaction-role deletion to return proper errors and show a clear bot message on failures.

• Bug Fixes

  • DELETE /api/guilds/:guildId/reaction-roles/:messageId now returns 500 for DB errors and 404 only when not found.
  • Bot handleDelete wraps deletion in try/catch and replies with an ephemeral error embed on failures.

• Migration

  • Run prisma migrate deploy.
  • If it fails, remove duplicate (guildId, threadId) rows from guild_forum_threads and rerun.

^{Written for commit 8bb8542. Summary will update on new commits.}

Summary by CodeRabbit

• Bug Fixes

  • Improved error handling when deleting reaction-role messages, so unexpected failures now return a clear generic error instead of breaking the request.
  • Preserved the existing “not found” response when a reaction-role message doesn’t exist.
  • Updated bot responses to show a more helpful failure message when deletion can’t be completed.

• Tests

  • Added coverage for API and bot deletion failures to verify the new error behavior.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2830febd-d0bf-4b42-88bb-cd710b88ebfa

📥 Commits

Reviewing files that changed from the base of the PR and between ad4b7ed and 8bb8542.

📒 Files selected for processing (4)

• packages/backend/src/routes/roles.ts
• packages/backend/tests/integration/routes/roles.test.ts
• packages/bot/src/functions/general/handlers/reactionroleHandlers.spec.ts
• packages/bot/src/functions/general/handlers/reactionroleHandlers.ts

---

📝 Walkthrough

Walkthrough

The reaction-role delete flow now catches service failures in both the backend API route and the bot handler. New tests cover service rejection cases for each path.

Changes

Reaction-role delete error handling

Layer / File(s)	Summary
Backend delete route error mapping packages/backend/src/routes/roles.ts, packages/backend/tests/integration/routes/roles.test.ts	DELETE /api/guilds/:guildId/reaction-roles/:messageId now catches service errors, preserves AppError responses, maps other failures to HTTP 500, and the integration test covers the service-rejection case.
Bot delete handler fallback packages/bot/src/functions/general/handlers/reactionroleHandlers.ts, packages/bot/src/functions/general/handlers/reactionroleHandlers.spec.ts	handleDelete now catches delete-service exceptions and sends a generic ephemeral error embed, and the spec covers the rejection path.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

• fix(backend): deleteReactionRoleMessage returns false on DB error causing incorrect 404 response #1536: The reaction-role delete flow now treats service/database failures as exceptions in both the API route and bot handler, matching the issue’s error-handling objective.

Possibly related PRs

• LucasSantana-Dev/Lucky#1532: Both PRs touch reaction-role deletion behavior and the same deleteReactionRoleMessage service path.

Suggested labels

backend, database

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/deletereactionrolemessage-db-error

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Failed to generate code suggestions for PR

[LucasSantana-Dev]

Closing - this was an incorrect merge. Will create a new PR for the correct changes.

[sonarqubecloud]

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE