fix(deploy): verify + cache-correct the frontend so deploys actually reach users

[LucasSantana-Dev]

Two related frontend-deploy correctness fixes, surfaced while investigating why v2.23.0 looked deployed (bot v2.23.0, backend SHA validated, migration applied) but the UI appeared "not done".

1. Frontend was never verified (Gap-E recurrence)

scripts/deploy.sh started lucky-frontend but never checked it:

• require_running_containers() omitted lucky-frontend
• run_health_checks() probed only backend endpoints

So a down/broken frontend passed as a successful deploy. Fix: add lucky-frontend to the required set + an HTTP check that http://nginx:8080/ serves the SPA (id="root"). Same defect class as decisions/2026-05-24-deploy-lock-contention-signal.md (lucky-bot). ADR: decisions/2026-06-24-deploy-frontend-health-gate.md.

2. SPA index.html was cacheable → stale UI after deploy

nginx/frontend.conf set no cache headers. With content-hashed Vite assets, a cached index.html keeps pointing at the previous build's asset hashes — so users see the old dashboard after a deploy (the actual "UI not done" symptom). Fix:

• /assets/ → immutable, max-age=31536000 (hashed names are safe forever)
• / (index.html + SPA fallback) → no-cache, must-revalidate

Verification

bash -n + shellcheck -S error clean; type-check green.

Follow-ups

• ci(deploy): derive require_running_containers from compose to stop service-gate drift (Gap-E recurrence) #1575 — derive require_running_containers from compose; add a stale-build version marker.

Operator notes

• Both take effect once the frontend image rebuilds + redeploys (on merge).
• Immediate UI relief for the current stale state: hard-refresh (Cmd+Shift+R); if it's CDN-cached, purge the Cloudflare cache.

Summary by CodeRabbit

• New Features

  • Deployments now verify the frontend is actually running before reporting success.
  • Static app assets are cached longer, helping pages load faster after repeat visits.

• Bug Fixes

  • Prevents successful deploys when the web app is down or not rendering correctly.
  • Improves music search fallbacks so alternate sources are handled more reliably.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
lucky	Ready	Preview, Comment	Jun 24, 2026 4:55pm

[coderabbitai]

Warning

Review limit reached

@LucasSantana-Dev, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 33 minutes and 32 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0881536f-11a3-4818-aa5d-40a995dec090

📥 Commits

Reviewing files that changed from the base of the PR and between edf40e3 and 99ebffb.

📒 Files selected for processing (6)

• decisions/2026-06-24-deploy-frontend-health-gate.md
• nginx/frontend.conf
• packages/bot/src/functions/music/commands/play/handlers/resolveProvider.spec.ts
• packages/bot/src/functions/music/commands/play/handlers/resolveProvider.ts
• packages/bot/src/functions/music/commands/play/queryUtils.ts
• scripts/deploy.sh

📝 Walkthrough

Walkthrough

The PR adds a frontend deploy health gate that checks lucky-frontend is running and verifies the SPA response at http://nginx:8080/. It also updates music play fallback handling to block the Spotify extractor during YouTube and SoundCloud retries, with test coverage for both fallback paths.

Changes

Frontend Health Gate

Layer / File(s)	Summary
Container requirement and SPA readiness check scripts/deploy.sh	Adds lucky-frontend to require_running_containers() and adds an HTTP readiness check against http://nginx:8080/ that requires id="root" in the response body.
Decision record: root cause, fix, and prevention decisions/2026-06-24-deploy-frontend-health-gate.md	Records the missed frontend detection scenario, the deploy script changes, the remaining staleness gap, and the prevention rule for future long-running services.

Music Fallback Extractor Blocking

Layer / File(s)	Summary
Fallback blocking in query utils packages/bot/src/functions/music/commands/play/queryUtils.ts	Adds SPOTIFY_EXTRACTOR_ID, uses it in YouTube and SoundCloud fallback client.player.play() calls, and reformats the voice-channel assertion.
Provider fallback blocking and tests packages/bot/src/functions/music/commands/play/handlers/resolveProvider.ts, packages/bot/src/functions/music/commands/play/handlers/resolveProvider.spec.ts	Adds blockExtractors to YouTube and SoundCloud fallback playback in resolveQueryWithFallbacks() and extends tests to assert the Spotify extractor is blocked on both fallback paths.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• LucasSantana-Dev/Lucky#538: Also changes the bot’s /play fallback/search flow in packages/bot/src/functions/music/commands/play.
• LucasSantana-Dev/Lucky#557: Also touches Spotify/YouTube/SoundCloud provider resolution and fallback behavior.
• LucasSantana-Dev/Lucky#590: Also modifies packages/bot/src/functions/music/commands/play/queryUtils.ts around the play-at-top fallback flow.

Suggested labels

frontend

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly reflects the two main changes: stronger frontend deploy verification and corrected caching for user-visible updates.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/deploy-frontend-health-gate

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Failed to generate code suggestions for PR

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

scripts/deploy.sh (1)

110-113: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Update print_targeted_logs() to include lucky-frontend and lucky-bot.

The new frontend health check (line 406) calls print_targeted_logs() on failure, but this function only collects logs from backend nginx postgres redis. Since lucky-frontend and lucky-bot are now in the required containers list (line 149), their logs should be collected when health checks fail to aid debugging.

📋 Proposed fix to include all required containers

 print_targeted_logs() {
-    log "Collecting backend/nginx/postgres/redis logs..."
-    docker_compose logs --tail=80 --no-color backend nginx postgres redis || true
+    log "Collecting backend/frontend/nginx/postgres/redis/bot logs..."
+    docker_compose logs --tail=80 --no-color backend frontend nginx postgres redis bot || true
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scripts/deploy.sh` around lines 110 - 113, The print_targeted_logs() function
currently only collects logs from backend, nginx, postgres, and redis
containers, but it should also include lucky-frontend and lucky-bot since these
are now required containers in the deployment. Update the docker_compose logs
command within the print_targeted_logs() function to add lucky-frontend and
lucky-bot as additional container arguments to the existing command that
collects logs from backend nginx postgres redis.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@scripts/deploy.sh`:
- Around line 110-113: The print_targeted_logs() function currently only
collects logs from backend, nginx, postgres, and redis containers, but it should
also include lucky-frontend and lucky-bot since these are now required
containers in the deployment. Update the docker_compose logs command within the
print_targeted_logs() function to add lucky-frontend and lucky-bot as additional
container arguments to the existing command that collects logs from backend
nginx postgres redis.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9862ea06-6c56-4202-94b8-ce199490dde2

📥 Commits

Reviewing files that changed from the base of the PR and between 0d1db6d and ac45804.

📒 Files selected for processing (2)

• decisions/2026-06-24-deploy-frontend-health-gate.md
• scripts/deploy.sh

📜 Review details

⏰ Context from checks skipped due to timeout. (12)

• GitHub Check: Test — bot
• GitHub Check: Test — shared
• GitHub Check: Checks
• GitHub Check: Test — backend
• GitHub Check: Test — frontend
• GitHub Check: cubic · AI code reviewer
• GitHub Check: quality / Lint (lint)
• GitHub Check: quality / Dead code (knip)
• GitHub Check: quality / SAST (CodeQL) (javascript-typescript)
• GitHub Check: danger / danger
• GitHub Check: Build — backend
• GitHub Check: Build — frontend

🔇 Additional comments (3)

scripts/deploy.sh (2)

149-149: LGTM!

---

397-410: LGTM!

decisions/2026-06-24-deploy-frontend-health-gate.md (1)

1-62: LGTM!

[cubic-dev-ai]

1 issue found across 2 files

_{You’re at about 90% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.}

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="scripts/deploy.sh">

<violation number="1" location="scripts/deploy.sh:149">
P2: Frontend is now a required/gated service, but failure diagnostics still omit frontend logs. This makes frontend deploy failures harder to triage during rollback scenarios.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

0 issues found across 1 file (changes from recent commits).

_{You’re at about 91% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.}

<sub>Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.

Re-trigger cubic</sub>

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/bot/src/functions/music/commands/play/queryUtils.ts`:
- Line 4: The Spotify extractor id literal is duplicated across queryUtils,
resolveProvider, and resolveProvider.spec, so centralize it into one shared
constant and update all existing references to use that single symbol. Move the
identifier into the shared area used by the music command helpers, then have the
fallback logic in queryUtils and the expectations in resolveProvider/spec import
and reference that constant instead of repeating the string.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 21989fc5-8585-47af-8b60-5177d58f5622

📥 Commits

Reviewing files that changed from the base of the PR and between ac45804 and edf40e3.

📒 Files selected for processing (4)

• nginx/frontend.conf
• packages/bot/src/functions/music/commands/play/handlers/resolveProvider.spec.ts
• packages/bot/src/functions/music/commands/play/handlers/resolveProvider.ts
• packages/bot/src/functions/music/commands/play/queryUtils.ts

📜 Review details

⏰ Context from checks skipped due to timeout. (13)

• GitHub Check: Test — frontend
• GitHub Check: Test — backend
• GitHub Check: Test — shared
• GitHub Check: Checks
• GitHub Check: Test — bot
• GitHub Check: cubic · AI code reviewer
• GitHub Check: danger / danger
• GitHub Check: quality / Dead code (knip)
• GitHub Check: quality / Lint (lint)
• GitHub Check: quality / SAST (CodeQL) (javascript-typescript)
• GitHub Check: Build — bot
• GitHub Check: Build — frontend
• GitHub Check: Build — backend

🧰 Additional context used

🪛 GitHub Check: Semgrep OSS

nginx/frontend.conf

[warning] 10-10: Semgrep Finding: generic.nginx.security.header-redefinition.header-redefinition
The 'add_header' directive is called in a 'location' block after headers have been set at the server block. Calling 'add_header' in the location block will actually overwrite the headers defined in the server block, no matter which headers are set. To fix this, explicitly set all headers or set all headers in the server block.

---

[warning] 18-18: Semgrep Finding: generic.nginx.security.header-redefinition.header-redefinition
The 'add_header' directive is called in a 'location' block after headers have been set at the server block. Calling 'add_header' in the location block will actually overwrite the headers defined in the server block, no matter which headers are set. To fix this, explicitly set all headers or set all headers in the server block.

🔇 Additional comments (5)

nginx/frontend.conf (1)

7-18: LGTM!

packages/bot/src/functions/music/commands/play/handlers/resolveProvider.ts (2)

11-12: 📐 Maintainability & Code Quality

The duplicated SPOTIFY_EXTRACTOR_ID definition is covered by the shared-constant comment in queryUtils.ts.

---

67-90: LGTM!

packages/bot/src/functions/music/commands/play/queryUtils.ts (1)

182-185: LGTM!

packages/bot/src/functions/music/commands/play/handlers/resolveProvider.spec.ts (1)

92-118: LGTM!

Also applies to: 144-172

[cubic-dev-ai]

2 issues found across 3 files (changes from recent commits).

_{You’re at about 91% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.}

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/bot/src/functions/music/commands/play/handlers/resolveProvider.ts">

<violation number="1" location="packages/bot/src/functions/music/commands/play/handlers/resolveProvider.ts:73">
P2: Primary path should also block SpotifyExtractor when searchEngine is YouTube/SoundCloud. Same `validate()`-ignores-queryType defect applies there — if the caller passes a YouTube or SoundCloud search engine as the primary engine, the SpotifyExtractor can intercept before the fallbacks run.</violation>
</file>

<sub>Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic</sub>

[github-actions]

	Warnings
⚠️	User-facing change without a CHANGELOG.md update. Add a line under ## [Unreleased] if this should appear in release notes. (Or apply the skip-changelog label if this PR does not affect end users.)

Generated by 🚫 dangerJS against 99ebffb

[cubic-dev-ai]

0 issues found across 1 file (changes from recent commits).

_{You’re at about 91% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.}

<sub>Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.

Re-trigger cubic</sub>

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud