ci(release): gate release publish on tests (#1480)

[LucasSantana-Dev]

Part of #1480 (deploy posture). Addresses F4 (safe half).

Change

Remove continue-on-error: true from the Run tests step in release.yml. The Create GitHub Release step runs if: success() by default, so a failing test:ci now blocks the release publish (and the downstream deploy.yml release: published trigger) instead of being advisory.

Why

Before: merge to main (0 required reviews) → tag → release with tests that can't block → prod. Tests were decorative at the release gate.

Velocity preserved

The emergency hotfix fast-path uses workflow_dispatch on deploy.yml, not release.yml (docs/runbooks/hotfix.md), so a flaky release-test run cannot block an incident hotfix.

Scope note

The release-please ADR (#1478) is merged but not yet implemented — release.yml is still the live release mechanism, so this hardens the current path. Harmless if release.yml is later replaced by release-please.

Not included (operator/governance — see #1480 comment)

• F4 other half (require ≥1 review on main) — would break the solo-operator auto-merge ship-lane; deliberately not applied.

@cubic-dev-ai

---

Summary by cubic

Gate release publishing on passing tests by removing continue-on-error from the Run tests step in release.yml. A failing npm run test:ci now blocks Create GitHub Release and the downstream deploy trigger, aligning with #1480 (deploy posture F4).

^{Written for commit 3b98b14. Summary will update on new commits.}

Summary by CodeRabbit

• Chores
  • Updated release workflow to enforce test passage before creating releases, improving overall release reliability and preventing failed deployments.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
lucky	Ready	Preview, Comment	Jun 17, 2026 12:49pm

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[LucasSantana-Dev]

@cubic-dev-ai please review.

[cubic-dev-ai]

@cubic-dev-ai please review.

@LucasSantana-Dev I have started the AI code review. It will take a few minutes to complete.

[github-actions]

	Warnings
⚠️	Branch security/release-tests-gate-1480 doesn't follow the standard prefix convention (feature/, fix/, refactor/, chore/, docs/, ci/, test/, release/).

Generated by 🚫 dangerJS against 3b98b14

[cubic-dev-ai]

No issues found across 1 file

<sub>Requires human review: Removing continue-on-error: true from the tests step will block releases if tests fail.

Re-trigger cubic</sub>

[coderabbitai]

📝 Walkthrough

Walkthrough

The continue-on-error: true setting is removed from the "Run tests" step in .github/workflows/release.yml, making test failures block the release job instead of allowing it to proceed to version extraction and GitHub Release creation.

Changes

Release Workflow Test Gate

Layer / File(s)	Summary
Remove continue-on-error from Run tests step .github/workflows/release.yml	Deletes continue-on-error: true from the "Run tests" step so that test failures now stop the release job.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

size/m

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly reflects the main change: gating the release publish process on test passage by removing continue-on-error from the test step.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch security/release-tests-gate-1480

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud