fix(bot): harden youtube extractor registration (#1468)

[LucasSantana-Dev]

What

Closes #1468 — the #play "No results found" half of the 2026-06-16 incident.

Verification reversed the diagnosis

The prior ADR (#1471) guessed po_token / YouTube IP-blocking. I ran the verification gate from the home network's residential egress IP (same public IP the homelab uses), with the installed discord-player-youtubei@3.0.0-beta.4:

• raw youtubei.js getBasicInfo (full player) → playability: OK, 26 streaming formats, no po_token
• the extractor's real path (discord-player-youtubei on a real discord.js Client → Player, as the bot registers it), no po_token: watch?v= URL → 1 track + stream OK; youtu.be → 1 track + stream OK; text search → 19 tracks + stream OK

→ the IP is not blocked and po_token is not needed. ADR updated to record the reversal.

Actual root cause (playerFactory.ts)

Extractor registration is fire-and-forget, and YouTube was sequenced behind an awaited, un-timed play-dl.getFreeClientID() network call (play-dl is unmaintained). Registration failures were swallowed by warnLog. So a slow/hung play-dl init or a transient registration failure — likely right after the ~17:00 restart that also caused the #1467 auto-join — left the bot with no YouTube extractor, and every #play <url> returned "No results found" until restart.

Fix

• register YouTube before the play-dl SoundCloud init (extractor priority unchanged: Spotify → YouTube → SoundCloud …)
• bound play-dl.getFreeClientID() with a 10 s timeout (new dependency-free withTimeout helper)
• retry youtubei registration once; escalate a final failure to errorLog so the degraded state is visible instead of silently swallowed

Tests

• withTimeout.ts covered by 3 new cases in playerFactory.spec.ts (resolve / timeout / propagate-rejection) — 20/20 pass
• existing playerFactory.test.ts 11/11 pass; bot type-check clean
• live reproduction above confirms the extractor itself is healthy

@cubic-dev-ai

---

Summary by cubic

Hardened YouTube extractor registration to stop the “No results found” regression for #play. We register YouTube earlier, bound the play-dl SoundCloud init with a timeout, and added retry + clear error logging to avoid silent degraded boots.

• Bug Fixes

  • Register discord-player-youtubei before play-dl SoundCloud init; extractor priority unchanged.
  • Add withTimeout and bound play-dl.getFreeClientID() to 10s.
  • Retry YouTube extractor registration once and escalate a final failure to errorLog.
  • Updated ADR after verification: po_token not needed; added tests for withTimeout.

• Refactors

  • Simplified withTimeout by removing a dead timer guard.

^{Written for commit 2999d59. Summary will update on new commits.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
lucky	Ready	Preview, Comment	Jun 16, 2026 9:46pm

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[coderabbitai]

Warning

Review limit reached

@LucasSantana-Dev, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 58 minutes and 35 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1971980a-2eb4-4b7f-aa7e-021d54585400

📥 Commits

Reviewing files that changed from the base of the PR and between b07467e and 2999d59.

📒 Files selected for processing (4)

• decisions/2026-06-16-youtube-extraction-reliability.md
• packages/bot/src/handlers/player/playerFactory.spec.ts
• packages/bot/src/handlers/player/playerFactory.ts
• packages/bot/src/handlers/player/withTimeout.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/1468-harden-youtube-extractor-registration

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Failed to generate code suggestions for PR

[cubic-dev-ai]

No issues found across 4 files

<sub>Requires human review: This PR makes risky changes to core music bot init flow (registration, error handling, timing) that could break YouTube playback, and adds a timeout utility. It needs human review to assess correctness and blast radius.

Re-trigger cubic</sub>

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[cubic-dev-ai]

0 issues found across 1 file (changes from recent commits).

<sub>Requires human review: This PR changes core bot initialization and adds a withTimeout utility. Because a bug could disable YouTube extraction, it requires human review to ensure correctness and avoid regressions.

Re-trigger cubic</sub>

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud